X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=src%2FWorker%2FExpire.php;h=7c304a5b249227f5bcb11a3e4313107993128e02;hb=bf8fb215a9cc554b5ec5b774168a52fb56fa43e6;hp=713bfa25e0ad67f6a6f9caab456ba5de7375dffd;hpb=29fd15a4c6c5d30e39ec60189193dcaecb74d1ff;p=friendica.git

diff --git a/src/Worker/Expire.php b/src/Worker/Expire.php
index 713bfa25e0..7c304a5b24 100644
--- a/src/Worker/Expire.php
+++ b/src/Worker/Expire.php
@@ -1,89 +1,108 @@
 <?php
 /**
- * @file src/Worker/Expire.php
- * @brief Expires old item entries
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
 
 namespace Friendica\Worker;
 
-use Friendica\Core\Addon;
-use Friendica\Core\Config;
+use Friendica\Core\Hook;
+use Friendica\Core\Logger;
 use Friendica\Core\Worker;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
+use Friendica\DI;
 use Friendica\Model\Item;
-use dba;
 
-require_once 'include/dba.php';
-
-class Expire {
-	public static function execute($param = '', $hook_name = '') {
-		global $a;
-
-		require_once 'include/items.php';
+/**
+ * Expires old item entries
+ */
+class Expire
+{
+	public static function execute($param = '', $hook_function = '')
+	{
+		$a = DI::app();
 
-		Addon::loadHooks();
+		Hook::loadHooks();
 
 		if ($param == 'delete') {
-			logger('Delete expired items', LOGGER_DEBUG);
+			Logger::log('Delete expired items', Logger::DEBUG);
 			// physically remove anything that has been deleted for more than two months
-			$r = dba::p("SELECT `id`, `icid` FROM `item` WHERE `deleted` AND `changed` < UTC_TIMESTAMP() - INTERVAL 60 DAY");
-			while ($row = dba::fetch($r)) {
-				dba::delete('item', ['id' => $row['id']]);
-				if (!dba::exists('item', ['icid' => $row['icid']])) {
-					dba::delete('item-content', ['id' => $row['icid']]);
-				}
+			$condition = ["`deleted` AND `changed` < UTC_TIMESTAMP() - INTERVAL 60 DAY"];
+			$rows = DBA::select('item', ['id', 'guid'],  $condition);
+			while ($row = DBA::fetch($rows)) {
+				Logger::info('Delete expired item', ['id' => $row['id'], 'guid' => $row['guid']]);
+				DBA::delete('item', ['id' => $row['id']]);
 			}
-			dba::close($r);
+			DBA::close($rows);
 
-			logger('Delete expired items - done', LOGGER_DEBUG);
+			// Normally we shouldn't have orphaned data at all.
+			// If we do have some, then we have to check why.
+			Logger::log('Deleting orphaned item content - start', Logger::DEBUG);
+			$condition = ["NOT EXISTS (SELECT `icid` FROM `item` WHERE `item`.`icid` = `item-content`.`id`)"];
+			DBA::delete('item-content', $condition);
+			Logger::log('Orphaned item content deleted: ' . DBA::affectedRows(), Logger::DEBUG);
 
 			// make this optional as it could have a performance impact on large sites
-			if (intval(Config::get('system', 'optimize_items'))) {
-				dba::e("OPTIMIZE TABLE `item`");
+			if (intval(DI::config()->get('system', 'optimize_items'))) {
+				DBA::e("OPTIMIZE TABLE `item`");
 			}
+
+			Logger::log('Delete expired items - done', Logger::DEBUG);
 			return;
 		} elseif (intval($param) > 0) {
-			$user = dba::selectFirst('user', ['uid', 'username', 'expire'], ['uid' => $param]);
-			if (DBM::is_result($user)) {
-				logger('Expire items for user '.$user['uid'].' ('.$user['username'].') - interval: '.$user['expire'], LOGGER_DEBUG);
+			$user = DBA::selectFirst('user', ['uid', 'username', 'expire'], ['uid' => $param]);
+			if (DBA::isResult($user)) {
+				Logger::log('Expire items for user '.$user['uid'].' ('.$user['username'].') - interval: '.$user['expire'], Logger::DEBUG);
 				Item::expire($user['uid'], $user['expire']);
-				logger('Expire items for user '.$user['uid'].' ('.$user['username'].') - done ', LOGGER_DEBUG);
+				Logger::log('Expire items for user '.$user['uid'].' ('.$user['username'].') - done ', Logger::DEBUG);
 			}
 			return;
-		} elseif (!empty($hook_name) && ($param == 'hook') && is_array($a->hooks) && array_key_exists("expire", $a->hooks)) {
-			foreach ($a->hooks["expire"] as $hook) {
-				if ($hook[1] == $hook_name) {
-					logger("Calling expire hook '" . $hook[1] . "'", LOGGER_DEBUG);
-					Addon::callSingleHook($a, $hook_name, $hook, $data);
+		} elseif ($param == 'hook' && !empty($hook_function)) {
+			foreach (Hook::getByName('expire') as $hook) {
+				if ($hook[1] == $hook_function) {
+					Logger::log("Calling expire hook '" . $hook[1] . "'", Logger::DEBUG);
+					Hook::callSingle($a, 'expire', $hook, $data);
 				}
 			}
 			return;
 		}
 
-		logger('expire: start');
+		Logger::log('expire: start');
 
 		Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
 				'Expire', 'delete');
 
-		$r = dba::p("SELECT `uid`, `username` FROM `user` WHERE `expire` != 0");
-		while ($row = dba::fetch($r)) {
-			logger('Calling expiry for user '.$row['uid'].' ('.$row['username'].')', LOGGER_DEBUG);
+		$r = DBA::p("SELECT `uid`, `username` FROM `user` WHERE `expire` != 0");
+		while ($row = DBA::fetch($r)) {
+			Logger::log('Calling expiry for user '.$row['uid'].' ('.$row['username'].')', Logger::DEBUG);
 			Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
 					'Expire', (int)$row['uid']);
 		}
-		dba::close($r);
-
-		logger('expire: calling hooks');
+		DBA::close($r);
 
-		if (is_array($a->hooks) && array_key_exists('expire', $a->hooks)) {
-			foreach ($a->hooks['expire'] as $hook) {
-				logger("Calling expire hook for '" . $hook[1] . "'", LOGGER_DEBUG);
-				Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
-						'Expire', 'hook', $hook[1]);
-			}
+		Logger::log('expire: calling hooks');
+		foreach (Hook::getByName('expire') as $hook) {
+			Logger::log("Calling expire hook for '" . $hook[1] . "'", Logger::DEBUG);
+			Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
+					'Expire', 'hook', $hook[1]);
 		}
 
-		logger('expire: end');
+		Logger::log('expire: end');
 
 		return;
 	}