X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=tests%2Fsrc%2FConsole%2FConfigConsoleTest.php;h=b26b6baf3f853f0112441bd7715162b1793a2fd1;hb=dce86be58efad2db2e4a473bbf8dd4d1f281d5b7;hp=05ed3f3c1e83de9613fac9f90f16a055498e244b;hpb=097620b62799c96d610d73410ec07a6b8cdf82f0;p=friendica.git

diff --git a/tests/src/Console/ConfigConsoleTest.php b/tests/src/Console/ConfigConsoleTest.php
index 05ed3f3c1e..b26b6baf3f 100644
--- a/tests/src/Console/ConfigConsoleTest.php
+++ b/tests/src/Console/ConfigConsoleTest.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -24,7 +24,9 @@ namespace Friendica\Test\src\Console;
 use Friendica\App;
 use Friendica\App\Mode;
 use Friendica\Console\Config;
-use Friendica\Core\Config\IConfig;
+use Friendica\Core\Config\Capability\IManageConfigValues;
+use Mockery;
+use Mockery\LegacyMockInterface;
 use Mockery\MockInterface;
 
 class ConfigConsoleTest extends ConsoleTest
@@ -33,25 +35,27 @@ class ConfigConsoleTest extends ConsoleTest
 	 * @var App\Mode|MockInterface $appMode
 	 */
 	private $appMode;
+	/** @var IManageConfigValues|LegacyMockInterface|MockInterface */
+	private $configMock;
 
-	protected function setUp()
+	protected function setUp() : void
 	{
 		parent::setUp();
 
-		\Mockery::getConfiguration()->setConstantsMap([
+		Mockery::getConfiguration()->setConstantsMap([
 			Mode::class => [
-				'DBCONFIGAVAILABLE' => 0
-			]
+				'DBCONFIGAVAILABLE' => 0,
+			],
 		]);
 
-		$this->appMode = \Mockery::mock(App\Mode::class);
+		$this->appMode = Mockery::mock(App\Mode::class);
 		$this->appMode->shouldReceive('has')
-		        ->andReturn(true);
+					  ->andReturn(true);
 
-		$this->configMock = \Mockery::mock(IConfig::class);
+		$this->configMock = Mockery::mock(IManageConfigValues::class);
 	}
 
-	function testSetGetKeyValue()
+	public function testSetGetKeyValue()
 	{
 		$this->configMock
 			->shouldReceive('set')
@@ -61,15 +65,20 @@ class ConfigConsoleTest extends ConsoleTest
 		$this->configMock
 			->shouldReceive('get')
 			->with('config', 'test')
-			->andReturn('now')
+			->andReturn('old')
 			->twice();
+		$this->configMock
+			->shouldReceive('get')
+			->with('config', 'test')
+			->andReturn('now')
+			->once();
 
 		$console = new Config($this->appMode, $this->configMock, $this->consoleArgv);
 		$console->setArgument(0, 'config');
 		$console->setArgument(1, 'test');
 		$console->setArgument(2, 'now');
 		$txt = $this->dumpExecute($console);
-		$this->assertEquals("config.test <= now\n", $txt);
+		self::assertEquals("config.test <= now\n", $txt);
 
 		$this->configMock
 			->shouldReceive('get')
@@ -81,7 +90,7 @@ class ConfigConsoleTest extends ConsoleTest
 		$console->setArgument(0, 'config');
 		$console->setArgument(1, 'test');
 		$txt = $this->dumpExecute($console);
-		$this->assertEquals("config.test => now\n", $txt);
+		self::assertEquals("config.test => now\n", $txt);
 
 		$this->configMock
 			->shouldReceive('get')
@@ -93,10 +102,11 @@ class ConfigConsoleTest extends ConsoleTest
 		$console->setArgument(0, 'config');
 		$console->setArgument(1, 'test');
 		$txt = $this->dumpExecute($console);
-		$this->assertEquals("config.test => \n", $txt);
+		self::assertEquals("config.test => NULL\n", $txt);
 	}
 
-	function testSetArrayValue() {
+	public function testSetArrayValue()
+	{
 		$testArray = [1, 2, 3];
 		$this->configMock
 			->shouldReceive('get')
@@ -110,22 +120,41 @@ class ConfigConsoleTest extends ConsoleTest
 		$console->setArgument(2, 'now');
 		$txt = $this->dumpExecute($console);
 
-		$this->assertEquals("[Error] config.test is an array and can't be set using this command.\n", $txt);
+		self::assertEquals("[Error] config.test is an array and can't be set using this command.\n", $txt);
+	}
+
+	public function testSetExistingValue()
+	{
+		$this->configMock
+			->shouldReceive('get')
+			->with('config', 'test')
+			->andReturn('now')
+			->twice();
+
+		$console = new Config($this->appMode, $this->configMock, $this->consoleArgv);
+		$console->setArgument(0, 'config');
+		$console->setArgument(1, 'test');
+		$console->setArgument(2, 'now');
+		$txt = $this->dumpExecute($console);
+
+		self::assertEquals("[Error] config.test already set to now.\n", $txt);
 	}
 
-	function testTooManyArguments() {
+	public function testTooManyArguments()
+	{
 		$console = new Config($this->appMode, $this->configMock, $this->consoleArgv);
 		$console->setArgument(0, 'config');
 		$console->setArgument(1, 'test');
 		$console->setArgument(2, 'it');
 		$console->setArgument(3, 'now');
-		$txt = $this->dumpExecute($console);
+		$txt       = $this->dumpExecute($console);
 		$assertion = '[Warning] Too many arguments';
 		$firstline = substr($txt, 0, strlen($assertion));
-		$this->assertEquals($assertion, $firstline);
+		self::assertEquals($assertion, $firstline);
 	}
 
-	function testVerbose() {
+	public function testVerbose()
+	{
 		$this->configMock
 			->shouldReceive('get')
 			->with('test', 'it')
@@ -136,7 +165,7 @@ class ConfigConsoleTest extends ConsoleTest
 		$console->setArgument(1, 'it');
 		$console->setOption('v', 1);
 		$executable = $this->consoleArgv[0];
-		$assertion = <<<CONF
+		$assertion  = <<<CONF
 Executable: {$executable}
 Class: Friendica\Console\Config
 Arguments: array (
@@ -149,11 +178,12 @@ Options: array (
 test.it => now
 
 CONF;
-		$txt = $this->dumpExecute($console);
-		$this->assertEquals($assertion, $txt);
+		$txt        = $this->dumpExecute($console);
+		self::assertEquals($assertion, $txt);
 	}
 
-	function testUnableToSet() {
+	public function testUnableToSet()
+	{
 		$this->configMock
 			->shouldReceive('set')
 			->with('test', 'it', 'now')
@@ -162,14 +192,14 @@ CONF;
 		$this->configMock
 			->shouldReceive('get')
 			->with('test', 'it')
-			->andReturn(NULL)
-			->once();
+			->andReturn(null)
+			->twice();
 		$console = new Config($this->appMode, $this->configMock, [$this->consoleArgv]);
 		$console->setArgument(0, 'test');
 		$console->setArgument(1, 'it');
 		$console->setArgument(2, 'now');
 		$txt = $this->dumpExecute($console);
-		$this->assertSame("Unable to set test.it\n", $txt);
+		self::assertSame("Unable to set test.it\n", $txt);
 	}
 
 	public function testGetHelp()
@@ -210,6 +240,6 @@ HELP;
 
 		$txt = $this->dumpExecute($console);
 
-		$this->assertEquals($txt, $theHelp);
+		self::assertEquals($txt, $theHelp);
 	}
 }