]> git.mxchange.org Git - quix0rs-gnu-social.git/commit
Fix for failure/exception on subscription/subscriber lists when deleted profiles...
authorBrion Vibber <brion@pobox.com>
Fri, 11 Feb 2011 21:21:53 +0000 (13:21 -0800)
committerBrion Vibber <brion@pobox.com>
Fri, 11 Feb 2011 21:21:53 +0000 (13:21 -0800)
commit454a980bd4f1d32062775772d7ddd6f57e5a0864
tree644453a861aebd33dfadfa1921b08f83cc8c088b
parentffe2da4c80ccf8def9d6ff7f13c1e7ada15edf95
Fix for failure/exception on subscription/subscriber lists when deleted profiles are stuck in cached list.

Workaround for deleted profiles still appearing in cached subscriptions/subscribers lists: if we couldn't fetch them, don't include them in the ArrayWrapper.
ArrayWrapper doesn't deal well with null entries, which aren't meant to happen in how it works. This code has recently changed from dying directly with a PHP fatal error in that case to throwing an exception, which allows tracking down the caller.

It looks like there might be some cases where profiles and their matching subscriptions get deleted, but the subscription entries don't get properly cleared from cache... that still bears further investigation. The regular code path looks ok; calls Subscription::cancel() from code called in Profile::delete(); but if they're batch-deleted instead of one row at a time, that could fail to trigger.
classes/Profile.php