]> git.mxchange.org Git - friendica.git/commit
Fix review points
authorfabrixxm <fabrix.xm@gmail.com>
Fri, 20 Aug 2021 07:47:53 +0000 (09:47 +0200)
committerfabrixxm <fabrix.xm@gmail.com>
Fri, 20 Aug 2021 09:02:18 +0000 (11:02 +0200)
commit7f695197aae9d87f5c04c2f7801d97852d72a3bc
tree12bbefb18781057e3430bd3162516570c632bed7
parent5520f100b24043468e9eb276bd5d6000177e5be1
Fix review points

- Fix headers hierarchy
- Improve accessibility:
  - set mouse pointer
- make rows focusable
- open on key press
- add tooltip with "title"
- add role and aria attributes
- Rename `ParsedLog` to `ParsedLogLine`
- Add docs to `ReversedFileReader`'s implementation of `Iterator`'s methods
- Add docs to `ParsedLogIterator`'s implementation of `Iterator`'s methods
- Remove unnecessary comment
- Add more test for parsing log lines and fix some edge cases
- Fix function name in snake-case to camelCase
- Remove `DIRECTORY_SEPARATOR`
12 files changed:
src/Model/Log/ParsedLogIterator.php
src/Object/Log/ParsedLog.php [deleted file]
src/Object/Log/ParsedLogLine.php [new file with mode: 0644]
src/Util/ReversedFileReader.php
tests/src/Model/Log/ParsedLogIteratorTest.php
tests/src/Object/Log/ParsedLogLineTest.php [new file with mode: 0644]
tests/src/Object/Log/ParsedLogTest.php [deleted file]
view/js/module/admin/logs/view.js
view/templates/admin/logs/view.tpl
view/theme/frio/css/style.css
view/theme/frio/js/module/admin/logs/view.js
view/theme/frio/templates/admin/logs/view.tpl