Mathias Fröhlich:

This one, removes some virtual qualifiers at a private member class of
SGPropertyNode. These virtual qualifiers are really useless and stop the
compiler from inlineing these functions. I gain a single frame with my
favourite aircraft per second!

diff --git a/simgear/props/props.hxx b/simgear/props/props.hxx
index 9ce7df4bf52524d315366884ae72b97b292da427..deb4f14d3d9394b2b5cd56e48889be229759d176 100644 (file)
--- a/simgear/props/props.hxx
+++ b/simgear/props/props.hxx
@@ -1293,11 +1293,11 @@ private:
     class entry {
     public:
       entry ();
     class entry {
     public:
       entry ();

-      virtual ~entry ();
-      virtual const char * get_key () { return _key; }
-      virtual void set_key (const char * key);
-      virtual SGPropertyNode * get_value () { return _value; }
-      virtual void set_value (SGPropertyNode * value);
+      ~entry ();
+      const char * get_key () { return _key; }
+      void set_key (const char * key);
+      SGPropertyNode * get_value () { return _value; }
+      void set_value (SGPropertyNode * value);

     private:
       char * _key;
       SGPropertyNode * _value;
     private:
       char * _key;
       SGPropertyNode * _value;


@@ -1310,9 +1310,9 @@ private:
     class bucket {
     public:
       bucket ();
     class bucket {
     public:
       bucket ();

-      virtual ~bucket ();
-      virtual entry * get_entry (const char * key, bool create = false);
-      virtual void erase(const char * key);
+      ~bucket ();
+      entry * get_entry (const char * key, bool create = false);
+      void erase(const char * key);

     private:
       int _length;
       entry ** _entries;
     private:
       int _length;
       entry ** _entries;


@@ -1321,10 +1321,10 @@ private:
     friend class bucket;
 
     hash_table ();
     friend class bucket;
 
     hash_table ();

-    virtual ~hash_table ();
-    virtual SGPropertyNode * get (const char * key);
-    virtual void put (const char * key, SGPropertyNode * value);
-    virtual void erase(const char * key);
+    ~hash_table ();
+    SGPropertyNode * get (const char * key);
+    void put (const char * key, SGPropertyNode * value);
+    void erase(const char * key);

 
   private:
     unsigned int hashcode (const char * key);
 
   private:
     unsigned int hashcode (const char * key);