[REFACTOR] Added explicit return type to all instances of QueueHandler::handle

diff --git a/lib/accountmover.php b/lib/accountmover.php
index f8fb4512bd7c19d791e00266caad21fcbb79b15f..a5eb49bcc469d4d3a332d1069f9edd88d7dddb36 100644 (file)
--- a/lib/accountmover.php
+++ b/lib/accountmover.php
@@ -51,7 +51,7 @@ class AccountMover extends QueueHandler
         return 'acctmove';
     }
 
-    function handle($object)
+    function handle($object) : bool
     {
         list($user, $remote, $password) = $object;
 

diff --git a/lib/activityimporter.php b/lib/activityimporter.php
index c4dd797e6d8076e11767e1fcb9a950b05aca30fa..68b5873b0bf316ae66d5e0ee39d0c9a409ed4b7c 100644 (file)
--- a/lib/activityimporter.php
+++ b/lib/activityimporter.php
@@ -51,7 +51,7 @@ class ActivityImporter extends QueueHandler
      *
      * @return
      */
-    function handle($data)
+    function handle($data) : bool
     {
         list($user, $author, $activity, $trusted) = $data;
 

diff --git a/lib/activitymover.php b/lib/activitymover.php
index 74c5c68ad688d8d824394f2d414e66ae2e0dc72c..ed11925888e6af05d7d1a9d73011c6f7ffc6828b 100644 (file)
--- a/lib/activitymover.php
+++ b/lib/activitymover.php
@@ -51,7 +51,7 @@ class ActivityMover extends QueueHandler
         return 'actmove';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         list ($act, $sink, $userURI, $remoteURI) = $data;
 

diff --git a/lib/deluserqueuehandler.php b/lib/deluserqueuehandler.php
index 65866af4184d20fe43e48fdfeeba64156a5ee46b..90362a5b3b7f89c3db9c2773581d582e83f6c5fd 100644 (file)
--- a/lib/deluserqueuehandler.php
+++ b/lib/deluserqueuehandler.php
@@ -36,7 +36,7 @@ class DelUserQueueHandler extends QueueHandler
         return 'deluser';
     }
 
-    public function handle($user)
+    public function handle($user) : bool
     {
         if (!($user instanceof User)) {
             common_log(LOG_ERR, "Got a bogus user, not deleting");

diff --git a/lib/distribqueuehandler.php b/lib/distribqueuehandler.php
index 036d970f2af9c3be343ffa36d350265b690895ac..79d91533addbdcdb004ec94dbf30fa4def5f31c8 100644 (file)
--- a/lib/distribqueuehandler.php
+++ b/lib/distribqueuehandler.php
@@ -61,7 +61,7 @@ class DistribQueueHandler
      * @param Notice $notice
      * @return boolean true on success, false on failure
      */
-    public function handle(Notice $notice)
+    public function handle(Notice $notice) : bool
     {
         // We have to manually add attentions to non-profile subs and non-mentions
         $ptAtts = $notice->getAttentionsFromProfileTags();

diff --git a/lib/feedimporter.php b/lib/feedimporter.php
index b5807ee8b45d82384fe98e355a4f9cba864387dd..39e98c39e2ea11844956f92d96ac6a316c36c42a 100644 (file)
--- a/lib/feedimporter.php
+++ b/lib/feedimporter.php
@@ -59,7 +59,7 @@ class FeedImporter extends QueueHandler
         return 'feedimp';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         list($user, $xml, $trusted) = $data;
 

diff --git a/lib/imqueuehandler.php b/lib/imqueuehandler.php
index b1eeb0ac3656d46b7153a38c3f7eb918e5831cb4..e8421710c7dab162b7f9b4105d81c838755862d8 100644 (file)
--- a/lib/imqueuehandler.php
+++ b/lib/imqueuehandler.php
@@ -35,7 +35,7 @@ class ImQueueHandler extends QueueHandler
      * @param Notice $notice
      * @return boolean success
      */
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not broadcasting");

diff --git a/lib/imreceiverqueuehandler.php b/lib/imreceiverqueuehandler.php
index aa4a663b7a6a00ff9d5e0278082d99ba93cafb92..dfe0776e14f5ac19301edefa503e81f680906b2e 100644 (file)
--- a/lib/imreceiverqueuehandler.php
+++ b/lib/imreceiverqueuehandler.php
@@ -35,7 +35,7 @@ class ImReceiverQueueHandler extends QueueHandler
      * @param object $data
      * @return boolean success
      */
-    function handle($data)
+    function handle($data) : bool
     {
         return $this->plugin->receiveRawMessage($data);
     }

diff --git a/lib/imsenderqueuehandler.php b/lib/imsenderqueuehandler.php
index 790dd7b1071397d96c37d8bc5444b8461e78879c..f1b709bd074dc87892726653fb7a2e32ae715b1c 100644 (file)
--- a/lib/imsenderqueuehandler.php
+++ b/lib/imsenderqueuehandler.php
@@ -35,7 +35,7 @@ class ImSenderQueueHandler extends QueueHandler
      * @param object $data
      * @return boolean success
      */
-    function handle($data)
+    function handle($data) : bool
     {
         return $this->plugin->imManager->send_raw_message($data);
     }

diff --git a/lib/pingqueuehandler.php b/lib/pingqueuehandler.php
index 7f5b11ea6a9136b7db2e4c12edbfd5e930b85e33..0e62774bd54cbf67efe58ae052445ff9f44158aa 100644 (file)
--- a/lib/pingqueuehandler.php
+++ b/lib/pingqueuehandler.php
@@ -29,7 +29,7 @@ class PingQueueHandler extends QueueHandler {
         return 'ping';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not broadcasting");

diff --git a/lib/pluginqueuehandler.php b/lib/pluginqueuehandler.php
index 46b61d6a96f6e37732a2f241012fdf357b649559..36b7c07c1b9e7eb4bfe091536b96f4b34e469639 100644 (file)
--- a/lib/pluginqueuehandler.php
+++ b/lib/pluginqueuehandler.php
@@ -40,7 +40,7 @@ class PluginQueueHandler extends QueueHandler
         return 'plugin';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not broadcasting");

diff --git a/lib/queuehandler.php b/lib/queuehandler.php
index 47161a987cc3f6298f48190b5ab4d31c3c10468a..118b16dade2f880125a56b9200955c84d2704b20 100644 (file)
--- a/lib/queuehandler.php
+++ b/lib/queuehandler.php
@@ -46,7 +46,7 @@ class QueueHandler
      * @param mixed $object
      * @return boolean true on success, false on failure
      */
-    function handle($object): bool
+    function handle($object) : bool
     {
         return true;
     }

diff --git a/lib/smsqueuehandler.php b/lib/smsqueuehandler.php
index 1df7011e3c2399bae3e7f7f6a3d65b3e8849e803..007852c7f8adcbdb23d275b27502e22ecdaa2827 100644 (file)
--- a/lib/smsqueuehandler.php
+++ b/lib/smsqueuehandler.php
@@ -29,7 +29,7 @@ class SmsQueueHandler extends QueueHandler
         return 'sms';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not broadcasting");

diff --git a/plugins/Bookmark/lib/deliciousbackupimporter.php b/plugins/Bookmark/lib/deliciousbackupimporter.php
index c8caef689af36d37342fb56d8ed3bf45f6489206..aa0bb92b784eb3ff57b4388f150df13ce98f53be 100644 (file)
--- a/plugins/Bookmark/lib/deliciousbackupimporter.php
+++ b/plugins/Bookmark/lib/deliciousbackupimporter.php
@@ -70,7 +70,7 @@ class DeliciousBackupImporter extends QueueHandler
      *
      * @return boolean success value
      */
-    function handle($data)
+    function handle($data) : bool
     {
         list($user, $body) = $data;
 

diff --git a/plugins/Bookmark/lib/deliciousbookmarkimporter.php b/plugins/Bookmark/lib/deliciousbookmarkimporter.php
index eca9e96060549d8d807cfdf121cb284c4c68d654..5ebd39815f5091d53af38267bf2efcfc3551c23d 100644 (file)
--- a/plugins/Bookmark/lib/deliciousbookmarkimporter.php
+++ b/plugins/Bookmark/lib/deliciousbookmarkimporter.php
@@ -63,7 +63,7 @@ class DeliciousBookmarkImporter extends QueueHandler
      *
      * @return boolean success value
      */
-    function handle($data)
+    function handle($data) : bool
     {
         $profile = Profile::getKV('id', $data['profile_id']);
 

diff --git a/plugins/EmailReminder/lib/siteconfirmreminderhandler.php b/plugins/EmailReminder/lib/siteconfirmreminderhandler.php
index e5b4a5e2ab71848e40b30bc20b1bb0e8687630cf..df83ea3e3c32f0a1d5062e0b288fc721a407dbe8 100644 (file)
--- a/plugins/EmailReminder/lib/siteconfirmreminderhandler.php
+++ b/plugins/EmailReminder/lib/siteconfirmreminderhandler.php
@@ -63,7 +63,7 @@ class SiteConfirmReminderHandler extends QueueHandler
      * @param array $remitem type of reminder to send and any special options
      * @return boolean true on success, false on failure
      */
-    function handle($remitem)
+    function handle($remitem) : bool
     {
         list($type, $opts) = $remitem;
 

diff --git a/plugins/EmailReminder/lib/userreminderhandler.php b/plugins/EmailReminder/lib/userreminderhandler.php
index e9d38a00a7f8f7769d2f9b00bbebfc66b3915f45..6dc7beff899344ceaf46762759b9bdcf479fb0ae 100644 (file)
--- a/plugins/EmailReminder/lib/userreminderhandler.php
+++ b/plugins/EmailReminder/lib/userreminderhandler.php
@@ -46,7 +46,7 @@ class UserReminderHandler extends QueueHandler {
      * @param Confirm_address $confirm the confirmation email/code
      * @return boolean true on success, false on failure
      */
-    function handle($confirm) {
+    function handle($confirm) : bool {
         return $this->sendNextReminder($confirm);
     }
 

diff --git a/plugins/EmailSummary/lib/siteemailsummaryhandler.php b/plugins/EmailSummary/lib/siteemailsummaryhandler.php
index 37e1a227f39f8bff623626bcd866a7dd8ddb1767..839002bc5bcd57209f2b71d6e602a56e2878f437 100644 (file)
--- a/plugins/EmailSummary/lib/siteemailsummaryhandler.php
+++ b/plugins/EmailSummary/lib/siteemailsummaryhandler.php
@@ -64,7 +64,7 @@ class SiteEmailSummaryHandler extends QueueHandler
      * @param mixed $object
      * @return boolean true on success, false on failure
      */
-    function handle($object)
+    function handle($object) : bool
     {
         $qm = QueueManager::get();
 

diff --git a/plugins/EmailSummary/lib/useremailsummaryhandler.php b/plugins/EmailSummary/lib/useremailsummaryhandler.php
index 143d6c1bd222382e12b1160e4b8111cf97eaba5e..ed90f0ede8103ce5593e4cb0bd31071bd23db4ec 100644 (file)
--- a/plugins/EmailSummary/lib/useremailsummaryhandler.php
+++ b/plugins/EmailSummary/lib/useremailsummaryhandler.php
@@ -64,7 +64,7 @@ class UserEmailSummaryHandler extends QueueHandler
      * @param mixed $object
      * @return boolean true on success, false on failure
      */
-    function handle($user_id)
+    function handle($user_id) : bool
     {
         // Skip if they've asked not to get summaries
 

diff --git a/plugins/FeedPoller/lib/feedpollqueuehandler.php b/plugins/FeedPoller/lib/feedpollqueuehandler.php
index f0441a5700a84f8511ef7c7f67a1e9bb6ca5a3d3..38e6cc97703626ef881a2b98535380519a8c829a 100644 (file)
--- a/plugins/FeedPoller/lib/feedpollqueuehandler.php
+++ b/plugins/FeedPoller/lib/feedpollqueuehandler.php
@@ -14,7 +14,7 @@ class FeedPollQueueHandler extends QueueHandler
         return FeedPoll::QUEUE_CHECK;
     }
 
-    public function handle($item)
+    public function handle($item) : bool
     {
         $feedsub = FeedSub::getKV('id', $item['id']);
         if (!$feedsub instanceof FeedSub) {

diff --git a/plugins/OStatus/lib/hubconfqueuehandler.php b/plugins/OStatus/lib/hubconfqueuehandler.php
index 6c06e677fe1c3b7f9b1c5aa3201cc1dcb90f91be..09911622f42a56d581564f10f289705ab5a7f88a 100644 (file)
--- a/plugins/OStatus/lib/hubconfqueuehandler.php
+++ b/plugins/OStatus/lib/hubconfqueuehandler.php
@@ -33,7 +33,7 @@ class HubConfQueueHandler extends QueueHandler
         return 'hubconf';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         $sub = $data['sub'];
         $mode = $data['mode'];

diff --git a/plugins/OStatus/lib/huboutqueuehandler.php b/plugins/OStatus/lib/huboutqueuehandler.php
index 91ac30e65011e26499db0be7223cc0298f4776c6..daf92d39952b215d35190f1a4c146def9aa09b3c 100644 (file)
--- a/plugins/OStatus/lib/huboutqueuehandler.php
+++ b/plugins/OStatus/lib/huboutqueuehandler.php
@@ -31,7 +31,7 @@ class HubOutQueueHandler extends QueueHandler
         return 'hubout';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         assert(array_key_exists('atom', $data));
         assert(is_string($data['atom']));

diff --git a/plugins/OStatus/lib/hubprepqueuehandler.php b/plugins/OStatus/lib/hubprepqueuehandler.php
index f11ca42e62d56ff8dfdf04b01826738dc28a410a..a9a821457e5ace739175d13562a7a75358acb693 100644 (file)
--- a/plugins/OStatus/lib/hubprepqueuehandler.php
+++ b/plugins/OStatus/lib/hubprepqueuehandler.php
@@ -43,7 +43,7 @@ class HubPrepQueueHandler extends QueueHandler
         return 'hubprep';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         $topic = $data['topic'];
         $atom = $data['atom'];

diff --git a/plugins/OStatus/lib/ostatusqueuehandler.php b/plugins/OStatus/lib/ostatusqueuehandler.php
index 74db1924fa452a0b2028a6613743480f80b9c2f7..21a9a37e3ca8fae987b3eb90d31362ab8ebbd7ba 100644 (file)
--- a/plugins/OStatus/lib/ostatusqueuehandler.php
+++ b/plugins/OStatus/lib/ostatusqueuehandler.php
@@ -44,7 +44,7 @@ class OStatusQueueHandler extends QueueHandler
         return 'ostatus';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not distributing");

diff --git a/plugins/OStatus/lib/pushinqueuehandler.php b/plugins/OStatus/lib/pushinqueuehandler.php
index 0ffb43b14af52a8840f6fcaba3a0ff195d717b89..60bf6aa69d07fd590f972f5c2d8ea018b4952565 100644 (file)
--- a/plugins/OStatus/lib/pushinqueuehandler.php
+++ b/plugins/OStatus/lib/pushinqueuehandler.php
@@ -31,7 +31,7 @@ class PushInQueueHandler extends QueueHandler
         return 'pushin';
     }
 
-    function handle($data): bool
+    function handle($data) : bool
     {
         if (!is_array($data)) {
             common_log(LOG_ERR, "Got bogus data, not processing");

diff --git a/plugins/OStatus/lib/pushrenewqueuehandler.php b/plugins/OStatus/lib/pushrenewqueuehandler.php
index 31df9b5f63cac4f19b58d4027b85f908523121ed..1b5574865b3d65ca6096f5e323426cf7847a78fe 100644 (file)
--- a/plugins/OStatus/lib/pushrenewqueuehandler.php
+++ b/plugins/OStatus/lib/pushrenewqueuehandler.php
@@ -30,7 +30,7 @@ class PushRenewQueueHandler extends QueueHandler
         return 'pushrenew';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         $feedsub_id = $data['feedsub_id'];
         $feedsub = FeedSub::getKV('id', $feedsub_id);

diff --git a/plugins/OStatus/lib/salmonqueuehandler.php b/plugins/OStatus/lib/salmonqueuehandler.php
index b5142a94243ba09a1829c231d90229c5875ae1d1..7fd63b8c46e66fe841bc77239fe9e08a3b59dc26 100644 (file)
--- a/plugins/OStatus/lib/salmonqueuehandler.php
+++ b/plugins/OStatus/lib/salmonqueuehandler.php
@@ -33,7 +33,7 @@ class SalmonQueueHandler extends QueueHandler
         return 'salmon';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         assert(is_array($data));
         assert(is_string($data['salmonuri']));

diff --git a/plugins/OfflineBackup/lib/offlinebackupqueuehandler.php b/plugins/OfflineBackup/lib/offlinebackupqueuehandler.php
index 9f96193d95758ed85c67db31bfd4a4c6216a42c2..6f2816c6788fc5c617c2f2b7a5e914bb3152f4c8 100644 (file)
--- a/plugins/OfflineBackup/lib/offlinebackupqueuehandler.php
+++ b/plugins/OfflineBackup/lib/offlinebackupqueuehandler.php
@@ -52,7 +52,7 @@ class OfflineBackupQueueHandler extends QueueHandler
         return 'backoff';
     }
 
-    function handle($object)
+    function handle($object) : bool
     {
         $userId = $object;
 

diff --git a/plugins/RSSCloud/lib/rsscloudqueuehandler.php b/plugins/RSSCloud/lib/rsscloudqueuehandler.php
index 63f6559412f718e401957c5f66bff45462fa95af..90efca4fbbd6c2112034f4eecf031f8be82c76db 100644 (file)
--- a/plugins/RSSCloud/lib/rsscloudqueuehandler.php
+++ b/plugins/RSSCloud/lib/rsscloudqueuehandler.php
@@ -26,7 +26,7 @@ class RSSCloudQueueHandler extends QueueHandler
         return 'rsscloud';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not using");

diff --git a/plugins/SubMirror/SubMirrorPlugin.php b/plugins/SubMirror/SubMirrorPlugin.php
index 3bad0911ecb31cc1f8ea94e453e02a2c26ec5f9c..2ddfefa9c20c7e7e9482d7a638f7328b05d118ae 100644 (file)
--- a/plugins/SubMirror/SubMirrorPlugin.php
+++ b/plugins/SubMirror/SubMirrorPlugin.php
@@ -47,7 +47,7 @@ class SubMirrorPlugin extends Plugin
         return true;
     }
 
-    function handle($notice)
+    function handle($notice) : bool
     {
         // Is anybody mirroring?
         $mirror = new SubMirror();

diff --git a/plugins/SubMirror/lib/mirrorqueuehandler.php b/plugins/SubMirror/lib/mirrorqueuehandler.php
index abdc259d8f18ce4c81a85425ed5921951f028ea4..016a1f7b9de24ef35c04ca7437cc1c843c2ac68a 100644 (file)
--- a/plugins/SubMirror/lib/mirrorqueuehandler.php
+++ b/plugins/SubMirror/lib/mirrorqueuehandler.php
@@ -32,7 +32,7 @@ class MirrorQueueHandler extends QueueHandler
         return 'mirror';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not mirroring");

diff --git a/plugins/TwitterBridge/lib/tweetinqueuehandler.php b/plugins/TwitterBridge/lib/tweetinqueuehandler.php
index 69ce5a61e97302518ee4011b8b15749adb34c414..394fa6c37aea8011d5115f028534b8cb7c540a69 100644 (file)
--- a/plugins/TwitterBridge/lib/tweetinqueuehandler.php
+++ b/plugins/TwitterBridge/lib/tweetinqueuehandler.php
@@ -40,7 +40,7 @@ class TweetInQueueHandler extends QueueHandler
         return 'tweetin';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         // JSON object with Twitter data
         $status = $data['status'];

diff --git a/plugins/TwitterBridge/lib/twitterqueuehandler.php b/plugins/TwitterBridge/lib/twitterqueuehandler.php
index 2c6c36906f9921a8a2ec702d077e08fdf72100ff..80bcd610f46745e89a1d3f84541c73709a6fdc3d 100644 (file)
--- a/plugins/TwitterBridge/lib/twitterqueuehandler.php
+++ b/plugins/TwitterBridge/lib/twitterqueuehandler.php
@@ -28,7 +28,7 @@ class TwitterQueueHandler extends QueueHandler
         return 'twitter';
     }
 
-    function handle($notice): bool
+    function handle($notice) : bool
     {
         if (!($notice instanceof Notice)) {
             common_log(LOG_ERR, "Got a bogus notice, not broadcasting");

diff --git a/plugins/TwitterBridge/tweetctlqueuehandler.php b/plugins/TwitterBridge/tweetctlqueuehandler.php
index d7636c373e64c4aa85cf5e210eee8ce673777fcb..f4bc8cd75cc0f3c11edaa8915063d651cb40c9ec 100644 (file)
--- a/plugins/TwitterBridge/tweetctlqueuehandler.php
+++ b/plugins/TwitterBridge/tweetctlqueuehandler.php
@@ -40,7 +40,7 @@ class TweetCtlQueueHandler extends QueueHandler
         return 'tweetctl';
     }
 
-    function handle($data)
+    function handle($data) : bool
     {
         // A user has activated or deactivated their Twitter bridge
         // import status.