use better SQL date, fix security problem with OpenID logins

darcs-hash:20080825184104-84dde-5735c1791002a12c3417603dc85da31ea868f263.gz

diff --git a/classes/User.php b/classes/User.php
index 491f68df24e77cde5d2c5650d77005da527ab36c..1a650c4242f603a5c93c417180fbac14d6afbcbb 100644 (file)
--- a/classes/User.php
+++ b/classes/User.php
@@ -148,6 +148,8 @@ class User extends DB_DataObject
        
        static function register($fields) {
 
+               # MAGICALLY put fields into current scope
+               
                extract($fields);
                
                $profile = new Profile();
@@ -169,7 +171,8 @@ class User extends DB_DataObject
                if ($location) {
                        $profile->location = $location;
                }
-               $profile->created = DB_DataObject_Cast::dateTime(); # current time
+               
+               $profile->created = common_sql_now();
                
                $id = $profile->insert();
 
@@ -182,8 +185,12 @@ class User extends DB_DataObject
                
                $user->id = $id;
                $user->nickname = $nickname;
-               $user->password = common_munge_password($password, $id);
-               $user->created =  DB_DataObject_Cast::dateTime(); # current time
+
+               if ($password) { # may not have a password for OpenID users
+                       $user->password = common_munge_password($password, $id);
+               }
+               
+               $user->created = common_sql_now();
                $user->uri = common_user_uri($user);
 
                $result = $user->insert();