Dequeue notice when we hit any Facebook error.

diff --git a/plugins/Facebook/facebookutil.php b/plugins/Facebook/facebookutil.php
index 0f24f5441ed5e039a656d4b4428f6cd6c0dc400c..c7b0f02c31df6d1d0f2049e50b01e68dd789658f 100644 (file)
--- a/plugins/Facebook/facebookutil.php
+++ b/plugins/Facebook/facebookutil.php
@@ -229,8 +229,8 @@ function handleFacebookError($e, $notice, $flink)
      default:
         $msg = "FacebookPlugin - Facebook returned an error we don't know how to deal with while trying to "
             . "post notice %d. Error code: %d, error message: \"%s\". (Notice details: "
-            . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Re-queueing "
-            . "notice, and will try to send again later.";
+            . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Removing notice "
+           . "from the Facebook queue for safety.";
         common_log(
             LOG_ERR, sprintf(
                 $msg,
@@ -243,8 +243,7 @@ function handleFacebookError($e, $notice, $flink)
                 $notice->content
             )
         );
-        // Re-queue and try again later
-        return false;
+        return true; // dequeue
         break;
     }
 }