Guard against saved bad terrasync path.

- warn when the terrasync path is not writeable, with a message box.

diff --git a/src/Main/options.cxx b/src/Main/options.cxx
index 48efc9c50c7cd9b8a6c560432cefa07e6a3a200e..7ba86d8271300227891ac0896bcdc6d75a66b5a4 100644 (file)
--- a/src/Main/options.cxx
+++ b/src/Main/options.cxx
@@ -41,6 +41,7 @@
 
 #include <iostream>
 #include <string>
+#include <sstream>
 
 #include <simgear/math/sg_random.h>
 #include <simgear/props/props_io.hxx>
@@ -2225,7 +2226,7 @@ OptionResult Options::processOptions()
   }
     
 // terrasync directory fixup
-  string terrasyncDir = fgGetString("/sim/terrasync/scenery-dir");
+    string terrasyncDir = simgear::strutils::strip(fgGetString("/sim/terrasync/scenery-dir"));
   if (terrasyncDir.empty()) {
          terrasyncDir = defaultTerrasyncDir();
          // auto-save it for next time
@@ -2249,6 +2250,17 @@ OptionResult Options::processOptions()
   if (!objectsDir.exists()) {
       objectsDir.create(0755);
   }
+
+    // check the above actuall worked
+    if (!objectsDir.exists() || !terrainDir.exists()) {
+        std::stringstream ss;
+        ss << "Scenery download will be disabled. The configured location is '" << terrasyncDir << "'.";
+        flightgear::modalMessageBox("Invalid scenery download location",
+                                    "Automatic scenery download is configured to use a location (path) which invalid.",
+                                    ss.str());
+        fgSetBool("/sim/terrasync/enabled", false);
+    }
+
   if (fgGetBool("/sim/terrasync/enabled")) {
     const string_list& scenery_paths(globals->get_fg_scenery());
     if (std::find(scenery_paths.begin(), scenery_paths.end(), terrasyncDir) == scenery_paths.end()) {