Change (P)Config::set return value to bool

diff --git a/src/Core/Config.php b/src/Core/Config.php
index 3c1d3245fd2256e3bde8fdd3801d4181ce84e8de..1e7fb9202bbd2ae7935ddb18bfa741449af246a0 100644 (file)
--- a/src/Core/Config.php
+++ b/src/Core/Config.php
@@ -95,7 +95,7 @@ class Config extends BaseObject
         * @param string $key    The configuration key to set
         * @param mixed  $value  The value to store
         *
-        * @return mixed Stored $value or false if the database update failed
+        * @return bool Operation success
         */
        public static function set($family, $key, $value)
        {

diff --git a/src/Core/Config/IConfigAdapter.php b/src/Core/Config/IConfigAdapter.php
index d1bb60033166fb97322cfcfb27bf28be985e6c33..4bd8eac264167269d411aa8b1071b72bb50fb690 100644 (file)
--- a/src/Core/Config/IConfigAdapter.php
+++ b/src/Core/Config/IConfigAdapter.php
@@ -53,7 +53,7 @@ interface IConfigAdapter
         * @param string $key    The configuration key to set
         * @param mixed  $value  The value to store
         *
-        * @return mixed Stored $value or false if the database update failed
+        * @return bool Operation success
         */
        public function set($cat, $k, $value);
 

diff --git a/src/Core/Config/IPConfigAdapter.php b/src/Core/Config/IPConfigAdapter.php
index a0f0c9a94c10040956b8a8086be37ca66154e4f8..b912418432e1eb86d15005a4da20911b3cd84bbd 100644 (file)
--- a/src/Core/Config/IPConfigAdapter.php
+++ b/src/Core/Config/IPConfigAdapter.php
@@ -57,7 +57,7 @@ interface IPConfigAdapter
         * @param string $k     The configuration key to set
         * @param string $value The value to store
         *
-        * @return mixed Stored $value or false
+        * @return bool Operation success
         */
        public function set($uid, $cat, $k, $value);
 

diff --git a/src/Core/Config/JITConfigAdapter.php b/src/Core/Config/JITConfigAdapter.php
index 0e7731690bf4dcca109e08aaca7208ed5846bf53..81a0c9890df3dd968636123e6756abe025b2ac7c 100644 (file)
--- a/src/Core/Config/JITConfigAdapter.php
+++ b/src/Core/Config/JITConfigAdapter.php
@@ -106,7 +106,6 @@ class JITConfigAdapter extends BaseObject implements IConfigAdapter
 
                if ($result) {
                        $this->in_db[$cat][$k] = true;
-                       return $value;
                }
 
                return $result;

diff --git a/src/Core/Config/JITPConfigAdapter.php b/src/Core/Config/JITPConfigAdapter.php
index ce9c5b6462d95d58a346620a6474f1eba5568408..ffd807a3628a0f67e1e42f2f90e0d3f47ae2afee 100644 (file)
--- a/src/Core/Config/JITPConfigAdapter.php
+++ b/src/Core/Config/JITPConfigAdapter.php
@@ -98,7 +98,6 @@ class JITPConfigAdapter extends BaseObject implements IPConfigAdapter
 
                if ($result) {
                        $this->in_db[$uid][$cat][$k] = true;
-                       return $value;
                }
 
                return $result;

diff --git a/src/Core/PConfig.php b/src/Core/PConfig.php
index 274122deda4513dd63acaeded4414989b0d7fd21..2f7bd926f4adff4b18f006de1fbe78a2e1036b39 100644 (file)
--- a/src/Core/PConfig.php
+++ b/src/Core/PConfig.php
@@ -93,7 +93,7 @@ class PConfig extends BaseObject
         * @param string $key    The configuration key to set
         * @param string $value  The value to store
         *
-        * @return mixed Stored $value or false
+        * @return bool Operation success
         */
        public static function set($uid, $family, $key, $value)
        {