Catch and report exceptions from notice_to_omb_notice() instead of letting the OMB...

diff --git a/lib/omb.php b/lib/omb.php
index 49496b774ef017406ba4bc1e4b5ed278a9e63ed7..e2a6d9f3f529f6004ef51c3846ad68a1b31143a6 100644 (file)
--- a/lib/omb.php
+++ b/lib/omb.php
@@ -67,7 +67,14 @@ function omb_hmac_sha1()
 function omb_broadcast_notice($notice)
 {
 
-    $omb_notice = notice_to_omb_notice($notice);
+    try {
+        $omb_notice = notice_to_omb_notice($notice);
+    } catch (Exception $e) {
+        // @fixme we should clean up or highlight the problem item
+        common_log(LOG_ERR, 'Invalid OMB outgoing notice for notice ' . $notice->id);
+        common_log(LOG_ERR, 'Error status '.$e);
+        return true;
+    }
 
     /* Get remote users subscribed to this profile. */
     $rp = new Remote_profile();