Issue 14478: Improved logging

diff --git a/src/Module/OAuth/Authorize.php b/src/Module/OAuth/Authorize.php
index 266f00402eb1328e8173fc39efbc58c1d0351da9..cd7b274ba66accd5fd63bce664f9a1e2e6422e14 100644 (file)
--- a/src/Module/OAuth/Authorize.php
+++ b/src/Module/OAuth/Authorize.php
@@ -36,17 +36,18 @@ class Authorize extends BaseApi
                ], $request);
 
                if ($request['response_type'] != 'code') {
-                       Logger::warning('Unsupported or missing response type', ['request' => $_REQUEST]);
+                       Logger::warning('Unsupported or missing response type', ['request' => $request]);
                        $this->logAndJsonError(422, $this->errorFactory->UnprocessableEntity($this->t('Unsupported or missing response type')));
                }
 
                if (empty($request['client_id']) || empty($request['redirect_uri'])) {
-                       Logger::warning('Incomplete request data', ['request' => $_REQUEST]);
+                       Logger::warning('Incomplete request data', ['request' => $request]);
                        $this->logAndJsonError(422, $this->errorFactory->UnprocessableEntity($this->t('Incomplete request data')));
                }
 
                $application = OAuth::getApplication($request['client_id'], $request['client_secret'], $request['redirect_uri']);
                if (empty($application)) {
+                       Logger::warning('An application could not be fetched.', ['request' => $request]);
                        $this->logAndJsonError(422, $this->errorFactory->UnprocessableEntity());
                }
 

diff --git a/src/Security/OAuth.php b/src/Security/OAuth.php
index a24bb0e8d08b19d0607a79299d88dd319a15c0f1..2add1ce584f687f74916f24d2190dd8a6cb266b5 100644 (file)
--- a/src/Security/OAuth.php
+++ b/src/Security/OAuth.php
@@ -131,6 +131,7 @@ class OAuth
 
                // The redirect_uri could contain several URI that are separated by spaces.
                if (($application['redirect_uri'] != $redirect_uri) && !in_array($redirect_uri, explode(' ', $application['redirect_uri']))) {
+                       Logger::warning('Redirection uri does not match', ['redirect_uri' => $redirect_uri, 'application-redirect_uri' => $application['redirect_uri']]);
                        return [];
                }