Avoid no needed call on parse2str() when there is nothing to parse (#5476)

diff --git a/mod/settings.php b/mod/settings.php
index 6c7d0fafe77d5a3d9b0c49be66d40c1b5c421f7d..e8e1eddc213dfcaa21a00a17d5fb97c72002d4ec 100644 (file)
--- a/mod/settings.php
+++ b/mod/settings.php
@@ -527,10 +527,10 @@ function settings_post(App $a)
                date_default_timezone_set($timezone);
        }
 
-       $str_group_allow   = perms2str(defaults($_POST, 'group_allow'  , ''));
-       $str_contact_allow = perms2str(defaults($_POST, 'contact_allow', ''));
-       $str_group_deny    = perms2str(defaults($_POST, 'group_deny'   , ''));
-       $str_contact_deny  = perms2str(defaults($_POST, 'contact_deny' , ''));
+       $str_group_allow   = !empty($_POST['group_allow'])   ? perms2str($_POST['group_allow'])   : '';
+       $str_contact_allow = !empty($_POST['contact_allow']) ? perms2str($_POST['contact_allow']) : '';
+       $str_group_deny    = !empty($_POST['group_deny'])    ? perms2str($_POST['group_deny'])    : '';
+       $str_contact_deny  = !empty($_POST['contact_deny'])  ? perms2str($_POST['contact_deny'])  : '';
 
        $openidserver = $a->user['openidserver'];
        //$openid = normalise_openid($openid);