We never accept a user without a Profile

diff --git a/classes/User.php b/classes/User.php
index e9f1d1b2cfc0499caafe8e4688084cbf2154bccd..ca3281107e65ea0fc0e9f5144bd39fe75c2f8f54 100644 (file)
--- a/classes/User.php
+++ b/classes/User.php
@@ -120,16 +120,18 @@ class User extends Managed_DataObject
         );
     }
 
-    protected $_profile = -1;
+    protected $_profile = null;
 
     /**
      * @return Profile
+     *
+     * @throws UserNoProfileException if user has no profile
      */
-    function getProfile()
+    public function getProfile()
     {
-        if (is_int($this->_profile) && $this->_profile == -1) { // invalid but distinct from null
+        if (!($this->_profile instanceof Profile)) {
             $this->_profile = Profile::getKV('id', $this->id);
-            if (empty($this->_profile)) {
+            if (!($this->_profile instanceof Profile)) {
                 throw new UserNoProfileException($this);
             }
         }