Fix Lock-Unlink

- Check if .sem file exists before unlinking it
- Fixing https://github.com/friendica/friendica/issues/7298#issuecomment-521670482

diff --git a/src/Core/Lock/SemaphoreLock.php b/src/Core/Lock/SemaphoreLock.php
index 75c7284a5fd8085c64aba0c485def8bdad92d9da..0f41f9f309556cf7355016044ce7ba85294d3f93 100644 (file)
--- a/src/Core/Lock/SemaphoreLock.php
+++ b/src/Core/Lock/SemaphoreLock.php
@@ -68,8 +68,10 @@ class SemaphoreLock extends Lock
 
                if (!empty(self::$semaphore[$key])) {
                        try {
-                               $success = @sem_release(self::$semaphore[$key]) &&
-                                          unlink(self::keyToFile($key));
+                               $success = @sem_release(self::$semaphore[$key]);
+                               if (file_exists(self::keyToFile($key)) && $success) {
+                                       $success = unlink(self::keyToFile($key));
+                               }
                                unset(self::$semaphore[$key]);
                                $this->markRelease($key);
                        } catch (\Exception $exception) {