Don't add PHPSESSID parameter onto notice and conversation URIs if we save a notice...

This was being triggered by welcomebot messages created at account creation time, then propagated through replies.

diff --git a/classes/Conversation.php b/classes/Conversation.php
index ea8bd87b5636907893101255dccc67dac81942d4..f540004ef39b6f9de2c7299ad80fbcd492626aff 100755 (executable)
--- a/classes/Conversation.php
+++ b/classes/Conversation.php
@@ -63,7 +63,8 @@ class Conversation extends Memcached_DataObject
         }
 
         $orig = clone($conv);
-        $orig->uri = common_local_url('conversation', array('id' => $id));
+        $orig->uri = common_local_url('conversation', array('id' => $id),
+                                      null, null, false);
         $result = $orig->update($conv);
 
         if (empty($result)) {

diff --git a/lib/util.php b/lib/util.php
index a30d69100289f08a94ba8e850bbcb1ed6f127e2e..795997868305ff09b2ada3614cf7a9a8d1089cf3 100644 (file)
--- a/lib/util.php
+++ b/lib/util.php
@@ -1529,7 +1529,8 @@ function common_user_uri(&$user)
 function common_notice_uri(&$notice)
 {
     return common_local_url('shownotice',
-                            array('notice' => $notice->id));
+                            array('notice' => $notice->id),
+                            null, null, false);
 }
 
 // 36 alphanums - lookalikes (0, O, 1, I) = 32 chars = 5 bits