handle empty subscription list

darcs-hash:20080517192447-84dde-f8dc1f4befde5d7624887b13eb7f5730f693c72c.gz

diff --git a/actions/showstream.php b/actions/showstream.php
index bc16b4d51ff754b77795c065303c2614174d318c..03e8de29c884ae9a4f49033f2468a70741897a53 100644 (file)
--- a/actions/showstream.php
+++ b/actions/showstream.php
@@ -1,18 +1,18 @@
 <?php
-/* 
+/*
  * Laconica - a distributed open-source microblogging tool
  * Copyright (C) 2008, Controlez-Vous, Inc.
- * 
+ *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU Affero General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Affero General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
@@ -27,7 +27,7 @@ define('SUBSCRIPTIONS', 80);
 class ShowstreamAction extends StreamAction {
 
        function handle($args) {
-               
+
                parent::handle($args);
 
                $nickname = common_canonical_nickname($this->arg('nickname'));
@@ -35,24 +35,24 @@ class ShowstreamAction extends StreamAction {
 
                if (!$user) {
                        $this->no_such_user();
-               } 
+               }
 
                $profile = $user->getProfile();
 
                if (!$profile) {
                        common_server_error(_t('User record exists without profile.'));
                }
-               
+
                # Looks like we're good; show the header
-               
+
                common_show_header($profile->nickname);
 
                $cur = common_current_user();
-               
+
                if ($cur && $profile->id == $cur->id) {
                        $this->notice_form();
                }
-       
+
                $this->show_profile($profile);
 
                $this->show_last_notice($profile);
@@ -64,20 +64,20 @@ class ShowstreamAction extends StreamAction {
                                $this->show_subscribe_form($profile);
                        }
                }
-               
+
                $this->show_statistics($profile);
 
                $this->show_subscriptions($profile);
-               
+
                $this->show_notices($profile);
-               
+
                common_show_footer();
        }
-       
+
        function no_such_user() {
                common_user_error('No such user');
        }
-       
+
        function notice_form() {
                common_element_start('form', array('id' => 'newnotice', 'method' => 'POST',
                                                                                   'action' => common_local_url('newnotice')));
@@ -85,7 +85,7 @@ class ShowstreamAction extends StreamAction {
                common_element('input', array('type' => 'submit'), 'Send');
                common_element_end('form');
        }
-       
+
        function show_profile($profile) {
                common_element_start('div', 'profile');
                $avatar = $profile->getAvatar(AVATAR_PROFILE_SIZE);
@@ -99,7 +99,7 @@ class ShowstreamAction extends StreamAction {
                common_element('span', 'nickname', $profile->nickname);
                if ($profile->fullname) {
                        if ($profile->homepage) {
-                               common_element('a', array('href' => $profile->homepage, 
+                               common_element('a', array('href' => $profile->homepage,
                                                                                  'class' => 'fullname'),
                                                           $profile->fullname);
                        } else {
@@ -135,42 +135,45 @@ class ShowstreamAction extends StreamAction {
                common_element('input', array('type' => 'submit'), _t('unsubscribe'));
                common_element_end('form');
        }
-       
+
        function show_subscriptions($profile) {
-               
+
                # XXX: add a limit
                $subs = $profile->getLink('id', 'subscription', 'subscriber');
+
                common_element_start('div', 'subscriptions');
-               
+
                $cnt = 0;
-               
-               while ($subs->fetch()) {
-                       $cnt++;
-                       if ($cnt % SUBSCRIPTIONS_PER_ROW == 1) {
-                               common_element_start('div', 'row');
-                       }
 
-                       common_element_start('a', array('title' => $subs->fullname ||
-                                                                                                  $subs->nickname,
-                                                                                       'href' => $subs->profileurl,
-                                                                                       'class' => 'subscription'));
-                       $avatar = $subs->getAvatar(AVATAR_MINI_SIZE);
-                       common_element('img', array('src' => (($avatar) ? $avatar->url : DEFAULT_MINI_AVATAR),
-                                                                               'width' => AVATAR_MINI_SIZE,
+               if ($subs) {
+                       while ($subs->fetch()) {
+                               $cnt++;
+                               if ($cnt % SUBSCRIPTIONS_PER_ROW == 1) {
+                                       common_element_start('div', 'row');
+                               }
+
+                               common_element_start('a', array('title' => $subs->fullname ||
+                                                                                               $subs->nickname,
+                                                                                               'href' => $subs->profileurl,
+                                                                                               'class' => 'subscription'));
+                               $avatar = $subs->getAvatar(AVATAR_MINI_SIZE);
+                               common_element('img', array('src' => (($avatar) ? $avatar->url : DEFAULT_MINI_AVATAR),
+                                                                                       'width' => AVATAR_MINI_SIZE,
                                                                                'height' => AVATAR_MINI_SIZE,
-                                                                               'class' => 'avatar mini'));
-                       common_element_end('a');
-                       
-                       if ($cnt % SUBSCRIPTIONS_PER_ROW == 0) {
-                               common_element_end('div');
-                       }
-                       
-                       if ($cnt == SUBSCRIPTIONS) {
-                               break;
+                                                                                       'class' => 'avatar mini'));
+                               common_element_end('a');
+
+                               if ($cnt % SUBSCRIPTIONS_PER_ROW == 0) {
+                                       common_element_end('div');
+                               }
+
+                               if ($cnt == SUBSCRIPTIONS) {
+                                       break;
+                               }
                        }
                }
 
-               common_element('a', array('href' => common_local_url('subscriptions', 
+               common_element('a', array('href' => common_local_url('subscriptions',
                                                                                                                         array('nickname' => $profile->nickname)),
                                                                  'class' => 'moresubscriptions'),
                                           _t('All subscriptions'));
@@ -184,15 +187,15 @@ class ShowstreamAction extends StreamAction {
                $subs = DB_DataObject::factory('subscription');
                $subs->subscriber = $profile->id;
                $subs_count = $subs->count();
-               
+
                $subbed = DB_DataObject::factory('subscription');
                $subbed->subscribed = $profile->id;
                $subbed_count = $subbed->count();
-               
+
                $notices = DB_DataObject::factory('notice');
                $notices->profile_id = $profile->id;
                $notice_count = $notices->count();
-               
+
                # Other stats...?
                common_element_start('dl', 'statistics');
                common_element('dt', _t('Subscriptions'));
@@ -203,39 +206,39 @@ class ShowstreamAction extends StreamAction {
                common_element('dd', $notice_count);
                common_element_end('dl');
        }
-       
+
        function show_notices($profile) {
 
                $notice = DB_DataObject::factory('notice');
                $notice->profile_id = $profile->id;
-               
+
                $notice->orderBy('created DESC');
-               
+
                $page = $this->arg('page') || 1;
-               
+
                $notice->limit((($page-1)*NOTICES_PER_PAGE) + 1, NOTICES_PER_PAGE);
-               
+
                $notice->find();
 
                common_element_start('div', 'notices');
-               
+
                while ($notice->fetch()) {
                        $this->show_notice($notice);
                }
-               
+
                common_element_end('div');
        }
-       
+
        function show_last_notice($profile) {
                $notice = DB_DataObject::factory('notice');
                $notice->profile_id = $profile->id;
                $notice->orderBy('created DESC');
                $notice->limit(1, 1);
                $notice->find();
-               
+
                while ($notice->fetch()) {
                        # FIXME: URL, image, video, audio
-                       common_element('span', array('class' => 'content'), 
+                       common_element('span', array('class' => 'content'),
                                                   $notice->content);
                        common_element('span', array('class' => 'date'),
                                                   common_date_string($notice->created));