Some fixes:

- varbinary() is not needed when clear-text words like 'xmpp' are used for them,
  it also hinders using external tools like Adminer/phpMyAdmin to search for
  them as e.g. Adminer wraps a HEX() call (SQL) around `k` and `cat` (see table
  `pconfig`)
- added missing UPDATE::SUCCESS

Signed-off-by: Roland Häder <roland@mxchange.org>

diff --git a/static/dbstructure.config.php b/static/dbstructure.config.php
old mode 100755 (executable)
new mode 100644 (file)
index 67b3020..9fb0c99
--- a/static/dbstructure.config.php
+++ b/static/dbstructure.config.php
@@ -54,7 +54,7 @@
 use Friendica\Database\DBA;
 
 if (!defined('DB_UPDATE_VERSION')) {
-       define('DB_UPDATE_VERSION', 1373);
+       define('DB_UPDATE_VERSION', 1374);
 }
 
 return [
@@ -1050,11 +1050,11 @@ return [
        "pconfig" => [
                "comment" => "personal (per user) configuration storage",
                "fields" => [
-                       "id" => ["type" => "int unsigned", "not null" => "1", "extra" => "auto_increment", "primary" => "1", "comment" => ""],
+                       "id" => ["type" => "int unsigned", "not null" => "1", "extra" => "auto_increment", "primary" => "1", "comment" => "Primary key"],
                        "uid" => ["type" => "mediumint unsigned", "not null" => "1", "default" => "0", "foreign" => ["user" => "uid"], "comment" => "User id"],
-                       "cat" => ["type" => "varbinary(50)", "not null" => "1", "default" => "", "comment" => ""],
-                       "k" => ["type" => "varbinary(100)", "not null" => "1", "default" => "", "comment" => ""],
-                       "v" => ["type" => "mediumtext", "comment" => ""],
+                       "cat" => ["type" => "varchar(50)", "not null" => "1", "default" => "", "comment" => "Category"],
+                       "k" => ["type" => "varchar(100)", "not null" => "1", "default" => "", "comment" => "Key"],
+                       "v" => ["type" => "mediumtext", "comment" => "Value"],
                ],
                "indexes" => [
                        "PRIMARY" => ["id"],

diff --git a/static/dbview.config.php b/static/dbview.config.php
old mode 100755 (executable)
new mode 100644 (file)

diff --git a/update.php b/update.php
index ec6a94f0e3ce982b21ab288e06749860641af10f..7c773f4ee51f806d6daaccb41bc8e6ba235c0cdb 100644 (file)
--- a/update.php
+++ b/update.php
@@ -747,4 +747,5 @@ function pre_update_1365()
                return Update::FAILED;
        }
 
+       return UPDATE::SUCCESS;
 }