]> git.mxchange.org Git - friendica.git/commitdiff
Merge pull request #3927 from rabuzarus/20171121_-_fix_reg_notifs
authorHypolite Petovan <mrpetovan@gmail.com>
Tue, 21 Nov 2017 04:54:11 +0000 (23:54 -0500)
committerGitHub <noreply@github.com>
Tue, 21 Nov 2017 04:54:11 +0000 (23:54 -0500)
Bugfix: show no registrations notifs if there are none

include/Emailer.php [deleted file]
include/enotify.php
mod/item.php
src/Util/Emailer.php [new file with mode: 0644]

diff --git a/include/Emailer.php b/include/Emailer.php
deleted file mode 100644 (file)
index 978b192..0000000
+++ /dev/null
@@ -1,85 +0,0 @@
-<?php
-
-use Friendica\Core\PConfig;
-
-require_once('include/email.php');
-
-class Emailer {
-       /**
-        * Send a multipart/alternative message with Text and HTML versions
-        *
-        * @param fromName                      name of the sender
-        * @param fromEmail                     email fo the sender
-        * @param replyTo                       replyTo address to direct responses
-        * @param toEmail                       destination email address
-        * @param messageSubject        subject of the message
-        * @param htmlVersion           html version of the message
-        * @param textVersion           text only version of the message
-        * @param additionalMailHeader  additions to the smtp mail header
-        * @param optional uid      user id of the destination user
-        */
-       public static function send($params) {
-
-               call_hooks('emailer_send_prepare', $params);
-
-               $email_textonly = False;
-               if (x($params,"uid")) {
-                       $email_textonly = PConfig::get($params['uid'], "system", "email_textonly");
-               }
-
-               $fromName = email_header_encode(html_entity_decode($params['fromName'],ENT_QUOTES,'UTF-8'),'UTF-8');
-               $messageSubject = email_header_encode(html_entity_decode($params['messageSubject'],ENT_QUOTES,'UTF-8'),'UTF-8');
-
-               // generate a mime boundary
-               $mimeBoundary   =rand(0,9)."-"
-                               .rand(100000000,999999999)."-"
-                               .rand(100000000,999999999)."=:"
-                               .rand(10000,99999);
-
-               // generate a multipart/alternative message header
-               $messageHeader =
-                       $params['additionalMailHeader'] .
-                       "From: $fromName <{$params['fromEmail']}>\n" .
-                       "Reply-To: $fromName <{$params['replyTo']}>\n" .
-                       "MIME-Version: 1.0\n" .
-                       "Content-Type: multipart/alternative; boundary=\"{$mimeBoundary}\"";
-
-               // assemble the final multipart message body with the text and html types included
-               $textBody       =       chunk_split(base64_encode($params['textVersion']));
-               $htmlBody       =       chunk_split(base64_encode($params['htmlVersion']));
-               $multipartMessageBody =
-                       "--" . $mimeBoundary . "\n" .                                   // plain text section
-                       "Content-Type: text/plain; charset=UTF-8\n" .
-                       "Content-Transfer-Encoding: base64\n\n" .
-                       $textBody . "\n";
-
-               if (!$email_textonly && !is_null($params['htmlVersion'])){
-                       $multipartMessageBody .=
-                               "--" . $mimeBoundary . "\n" .                           // text/html section
-                               "Content-Type: text/html; charset=UTF-8\n" .
-                               "Content-Transfer-Encoding: base64\n\n" .
-                               $htmlBody . "\n";
-               }
-               $multipartMessageBody .=
-                       "--" . $mimeBoundary . "--\n";                                  // message ending
-
-               // send the message
-               $hookdata = array(
-                       'to' => $params['toEmail'],
-                       'subject' => $messageSubject,
-                       'body' => $multipartMessageBody,
-                       'headers' => $messageHeader
-               );
-               //echo "<pre>"; var_dump($hookdata); killme();
-               call_hooks("emailer_send", $hookdata);
-               $res = mail(
-                       $hookdata['to'],                                                        // send to address
-                       $hookdata['subject'],                                           // subject
-                       $hookdata['body'],                                                      // message body
-                       $hookdata['headers']                                            // message headers
-               );
-               logger("header " . 'To: ' . $params['toEmail'] . "\n" . $messageHeader, LOGGER_DEBUG);
-               logger("return value " . (($res)?"true":"false"), LOGGER_DEBUG);
-               return $res;
-       }
-}
index 7de2027ca8342fafd5e84f3cf791b336f7939603..dc030fa8b8985b77ed7a446dafcf864c6869586d 100644 (file)
@@ -1,14 +1,16 @@
 <?php
-
+/**
+ * @file include/enotify.php
+ */
 use Friendica\App;
 use Friendica\Core\Config;
 use Friendica\Core\System;
 use Friendica\Database\DBM;
+use Friendica\Util\Emailer;
 
-require_once('include/Emailer.php');
-require_once('include/email.php');
-require_once('include/bbcode.php');
-require_once('include/html2bbcode.php');
+require_once 'include/email.php';
+require_once 'include/bbcode.php';
+require_once 'include/html2bbcode.php';
 
 /**
  * @brief Creates a notification entry and possibly sends a mail
@@ -637,7 +639,8 @@ function notification($params) {
 
                // use the Emailer class to send the message
 
-               return Emailer::send(array(
+               return Emailer::send(
+                       array(
                        'uid' => $params['uid'],
                        'fromName' => $sender_name,
                        'fromEmail' => $sender_email,
@@ -646,11 +649,11 @@ function notification($params) {
                        'messageSubject' => $datarray['subject'],
                        'htmlVersion' => $email_html_body,
                        'textVersion' => $email_text_body,
-                       'additionalMailHeader' => $datarray['headers'],
-               ));
+                       'additionalMailHeader' => $datarray['headers'])
+               );
        }
 
-    return False;
+       return false;
 }
 
 /**
index 8055d63aec2d3e8c82d044871e06807e420c3579..97c26b5f9bad7807474a2bbde97d7de9a05fea9a 100644 (file)
@@ -24,6 +24,7 @@ use Friendica\Model\GlobalContact;
 use Friendica\Network\Probe;
 use Friendica\Object\Contact;
 use Friendica\Protocol\Diaspora;
+use Friendica\Util\Emailer;
 
 require_once 'include/crypto.php';
 require_once 'include/enotify.php';
@@ -1036,13 +1037,13 @@ function item_post(App $a) {
                                $message = '<html><body>' . $link . $html . $disclaimer . '</body></html>';
                                include_once 'include/html2plain.php';
                                $params = array (
-                                   'fromName' => $a->user['username'],
-                                   'fromEmail' => $a->user['email'],
-                                   'toEmail' => $addr,
-                                   'replyTo' => $a->user['email'],
-                                   'messageSubject' => $subject,
-                                   'htmlVersion' => $message,
-                                   'textVersion' => html2plain($html.$disclaimer),
+                                       'fromName' => $a->user['username'],
+                                       'fromEmail' => $a->user['email'],
+                                       'toEmail' => $addr,
+                                       'replyTo' => $a->user['email'],
+                                       'messageSubject' => $subject,
+                                       'htmlVersion' => $message,
+                                       'textVersion' => html2plain($html.$disclaimer)
                                );
                                Emailer::send($params);
                        }
diff --git a/src/Util/Emailer.php b/src/Util/Emailer.php
new file mode 100644 (file)
index 0000000..a2be983
--- /dev/null
@@ -0,0 +1,94 @@
+<?php
+/**
+ * @file src/Util/Emailer.php
+ */
+namespace Friendica\Util;
+
+use Friendica\Core\PConfig;
+
+require_once 'include/email.php';
+
+/**
+ * @breif class to handle emailing
+ */
+class Emailer
+{
+       /**
+        * Send a multipart/alternative message with Text and HTML versions
+        *
+        * @param array $params parameters
+        *                      fromName name of the sender
+        *                      fromEmail                        email fo the sender
+        *                      replyTo                      replyTo address to direct responses
+        *                      toEmail                      destination email address
+        *                      messageSubject       subject of the message
+        *                      htmlVersion                  html version of the message
+        *                      textVersion                  text only version of the message
+        *                      additionalMailHeader additions to the smtp mail header
+        *                      optional             uid user id of the destination user
+        *
+        * @return object
+        */
+       public static function send($params)
+       {
+               call_hooks('emailer_send_prepare', $params);
+
+               $email_textonly = false;
+               if (x($params, "uid")) {
+                       $email_textonly = PConfig::get($params['uid'], "system", "email_textonly");
+               }
+
+               $fromName = email_header_encode(html_entity_decode($params['fromName'], ENT_QUOTES, 'UTF-8'), 'UTF-8');
+               $messageSubject = email_header_encode(html_entity_decode($params['messageSubject'], ENT_QUOTES, 'UTF-8'), 'UTF-8');
+
+               // generate a mime boundary
+               $mimeBoundary   =rand(0, 9)."-"
+                               .rand(100000000, 999999999)."-"
+                               .rand(100000000, 999999999)."=:"
+                               .rand(10000, 99999);
+
+               // generate a multipart/alternative message header
+               $messageHeader = $params['additionalMailHeader'] .
+                                               "From: $fromName <{$params['fromEmail']}>\n" .
+                                               "Reply-To: $fromName <{$params['replyTo']}>\n" .
+                                               "MIME-Version: 1.0\n" .
+                                               "Content-Type: multipart/alternative; boundary=\"{$mimeBoundary}\"";
+
+               // assemble the final multipart message body with the text and html types included
+               $textBody       =       chunk_split(base64_encode($params['textVersion']));
+               $htmlBody       =       chunk_split(base64_encode($params['htmlVersion']));
+               $multipartMessageBody = "--" . $mimeBoundary . "\n" .                                   // plain text section
+                                                               "Content-Type: text/plain; charset=UTF-8\n" .
+                                                               "Content-Transfer-Encoding: base64\n\n" .
+                                                               $textBody . "\n";
+
+               if (!$email_textonly && !is_null($params['htmlVersion'])) {
+                       $multipartMessageBody .=
+                               "--" . $mimeBoundary . "\n" .                           // text/html section
+                               "Content-Type: text/html; charset=UTF-8\n" .
+                               "Content-Transfer-Encoding: base64\n\n" .
+                               $htmlBody . "\n";
+               }
+               $multipartMessageBody .=
+                       "--" . $mimeBoundary . "--\n";                                  // message ending
+
+               // send the message
+               $hookdata = array(
+                       'to' => $params['toEmail'],
+                       'subject' => $messageSubject,
+                       'body' => $multipartMessageBody,
+                       'headers' => $messageHeader
+               );
+               //echo "<pre>"; var_dump($hookdata); killme();
+               call_hooks("emailer_send", $hookdata);
+               $res = mail(
+                       $hookdata['to'],                                                        // send to address
+                       $hookdata['subject'],                                           // subject
+                       $hookdata['body'],                                                      // message body
+                       $hookdata['headers']                                            // message headers
+               );
+               logger("header " . 'To: ' . $params['toEmail'] . "\n" . $messageHeader, LOGGER_DEBUG);
+               logger("return value " . (($res)?"true":"false"), LOGGER_DEBUG);
+               return $res;
+       }
+}