]> git.mxchange.org Git - jcontacts-core.git/commitdiff
Continued:
authorRoland Häder <roland@mxchange.org>
Sun, 22 Jan 2023 03:22:03 +0000 (04:22 +0100)
committerRoland Häder <roland@mxchange.org>
Sun, 22 Jan 2023 03:22:03 +0000 (04:22 +0100)
- fixed some flaws found by NetBeans' inspector

test/org/mxchange/jcontacts/ContactTestData.java
test/org/mxchange/jcontacts/model/contact/UserContactObjectTest.java
test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java

index 05cff2f1375905c983f3d596b31946cdc9efb71d..5bd0ffe2af21d6524d21178bf6e3fc45018bbbca 100644 (file)
@@ -80,9 +80,9 @@ public class ContactTestData {
 
        public static final String CONTACT_TITLE2 = "PHD"; //NOI18N
 
-       public static final Integer CONTACT_ZIP_CODE1 = 12345;
+       public static final Integer CONTACT_ZIP_CODE1 = 12_345;
 
-       public static final Integer CONTACT_ZIP_CODE2 = 67890;
+       public static final Integer CONTACT_ZIP_CODE2 = 67_890;
 
        static {
                // Fake ids
index 56f4baa0fd3e40a4e60e2feb1cb13da35dc2f0cc..803df74f040a53655aa8b839f462b4a7ec812d0e 100644 (file)
@@ -426,7 +426,7 @@ public class UserContactObjectTest {
                          );
 
                // Should always be false
-               Assert.assertFalse(contact.equals(null));
+               Assert.assertFalse(contact == null);
        }
 
        @Test (description = "Tests Contact.equals() with null and set primary key")
@@ -590,7 +590,7 @@ public class UserContactObjectTest {
                                          ContactTestData.CONTACT_COUNTRY1,
                                          Boolean.FALSE,
                                          ContactTestData.CONTACT_STREET_NAME1,
-                                         Short.parseShort("-1"), //NOI18N
+                                         Short.valueOf("-1"), //NOI18N
                                          ContactTestData.CONTACT_HOUSE_NUMBER_EXTENSION1,
                                          ContactTestData.CONTACT_ZIP_CODE1,
                                          ContactTestData.CONTACT_CITY1,
index 3ed874de27d279b342ba1f845a6911f46e52934a..4bcb947b6d683fa7fc273adb0c1eb54f26c83173 100644 (file)
@@ -327,7 +327,7 @@ public class ContactUtilsTest {
                                ContactTestData.CONTACT_STREET_NAME1,
                                ContactTestData.CONTACT_HOUSE_NUMBER1,
                                ContactTestData.CONTACT_HOUSE_NUMBER_EXTENSION1,
-                               67890,
+                               67_890,
                                ContactTestData.CONTACT_CITY1,
                                ContactTestData.CONTACT_EMAIL1,
                                ContactTestData.CONTACT_TITLE1,