Fix delivery data increment in APDelivery

- Avoid incrementing the queue done if Transmitter::createCachedActivityFromItem fails

diff --git a/src/Worker/APDelivery.php b/src/Worker/APDelivery.php
index 634a9446ebfc85ba63a04805bc49ef9ebc6daf35..2048b97d02259261d5dc71eabdafd9fc115c7035 100644 (file)
--- a/src/Worker/APDelivery.php
+++ b/src/Worker/APDelivery.php
@@ -41,10 +41,9 @@ class APDelivery extends BaseObject
                        $data = ActivityPub\Transmitter::createCachedActivityFromItem($target_id);
                        if (!empty($data)) {
                                $success = HTTPSignature::transmit($data, $inbox, $uid);
-                       }
-
-                       if ($success && in_array($cmd, [Delivery::POST, Delivery::COMMENT])) {
-                               ItemDeliveryData::incrementQueueDone($target_id);
+                               if ($success && in_array($cmd, [Delivery::POST, Delivery::COMMENT])) {
+                                       ItemDeliveryData::incrementQueueDone($target_id);
+                               }
                        }
                }