Leave failed image URLs in place

diff --git a/mailstream/mailstream.php b/mailstream/mailstream.php
index b513cf367b686d1800b7535e19f53f1d9493bfc2..4056aac61359e11521036a05cb2e26971f242c1e 100644 (file)
--- a/mailstream/mailstream.php
+++ b/mailstream/mailstream.php
@@ -220,6 +220,11 @@ function mailstream_do_images(array &$item, array &$attachments)
                $cookiejar = tempnam(System::getTempPath(), 'cookiejar-mailstream-');
                try {
                        $curlResult = DI::httpClient()->fetchFull($url, HttpClientAccept::DEFAULT, 0, $cookiejar);
+                       if (!$curlResult->isSuccess()) {
+                               Logger::debug('mailstream: fetch image url failed', [
+                                       'url' => $url, 'item_id' => $item['id'], 'return_code' => $curlResult->getReturnCode()]);
+                               continue;
+                       }
                } catch (InvalidArgumentException $e) {
                        Logger::error('mailstream_do_images exception fetching url', ['url' => $url, 'item_id' => $item['id']]);
                        continue;