NoHttpResponseException needed instead of HTTP_Request2_Exception

HTTP_Request2_Exception assumed an HTTP response status code/line

diff --git a/lib/httpclient.php b/lib/httpclient.php
index 98e5d0426b74627f9d15502a6e2cb0d700fd9eb5..5fe0e9f32994301f8713a8140389586282812494 100644 (file)
--- a/lib/httpclient.php
+++ b/lib/httpclient.php
@@ -290,7 +290,7 @@ class HTTPClient extends HTTP_Request2
         $response = $this->send();
         if (is_null($response)) {
             // TRANS: Failed to retrieve a remote web resource, %s is the target URL.
-            throw new HTTP_Request2_Exception(sprintf(_m('HTTP request failed without response to URL: %s'), var_export($target, true)));
+            throw new NoHttpResponseException($url);
         }
         return $response;
     }

diff --git a/lib/nohttpresponseexception.php b/lib/nohttpresponseexception.php
new file mode 100644 (file)
index 0000000..1555fb9
--- /dev/null
+++ b/lib/nohttpresponseexception.php
@@ -0,0 +1,43 @@
+<?php
+/**
+ * StatusNet, the distributed open-source microblogging tool
+ *
+ * Class for an exception when an HTTP request gets no response (DNS failure etc.)
+ *
+ * PHP version 5
+ *
+ * LICENCE: This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @category  Exception
+ * @package   GNUsocial
+ * @author    Mikael Nordfeldth <mmn@hethane.se>
+ * @copyright 2013 Free Software Foundation, Inc.
+ * @license   http://www.fsf.org/licensing/licenses/agpl-3.0.html AGPLv3
+ * @link      http://www.gnu.org/software/social/
+ */
+
+if (!defined('GNUSOCIAL')) { exit(1); }
+
+// Can't extend HTTP_Request2_Exception since it requires an HTTP status code which we didn't get
+class NoHttpResponseException extends Exception
+{
+    public $url;    // target URL
+
+    public function __construct($url)
+    {
+        $this->url = $url;
+        // We could log an entry here with the search parameters
+        parent::__construct(sprintf(_('No HTTP response from URL %s.'), _ve($url)));
+    }
+}

diff --git a/lib/queuemonitor.php b/lib/queuemonitor.php
index ecc76197cfe777b2ba42febf3a7b4ba07734c422..cb68dee930ce81f50fbe28bae7afebce4227c3f6 100644 (file)
--- a/lib/queuemonitor.php
+++ b/lib/queuemonitor.php
@@ -102,8 +102,8 @@ class QueueMonitor
             if (!$result->isOk()) {
                 common_log(LOG_ERR, __METHOD__ . ' HTTP ' . $result->getStatus() . ': ' . $result->getBody());
             }
-        } catch (HTTP_Request2_Exception $e) {
-                common_log(LOG_ERR, __METHOD__ . ' HTTP request generated PHP level error (check logs, could be DNS failure etc.). URL: '.var_export($target,true));
+        } catch (NoHttpResponseException $e) {
+            common_log(LOG_ERR, __METHOD__ . ':'.$e->getMessage());
         }
     }
 

diff --git a/plugins/OStatus/lib/discoveryhints.php b/plugins/OStatus/lib/discoveryhints.php
index d95bd8e78fca88035afeb9094bee76411f6985c4..5bd9fcbe4803a94d2646a2b3287ea8cfa87cfe35 100644 (file)
--- a/plugins/OStatus/lib/discoveryhints.php
+++ b/plugins/OStatus/lib/discoveryhints.php
@@ -64,7 +64,7 @@ class DiscoveryHints {
             if (!$response->isOk()) {
                 return null;
             }
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (NoHttpResponseException $e) {
             // Any HTTPClient error that might've been thrown
             return null;
         }

diff --git a/plugins/OStatus/tests/slap.php b/plugins/OStatus/tests/slap.php
index ba4af4e6a1e734d0859ffbedea0642a0d9189074..84447bfd15b9c2797376ec46f2d61f2bbebcfe73 100755 (executable)
--- a/plugins/OStatus/tests/slap.php
+++ b/plugins/OStatus/tests/slap.php
@@ -80,7 +80,7 @@ if (have_option('--verify')) {
 
         print $response->getStatus() . "\n\n";
         print $response->getBody() . "\n\n";
-    } catch (HTTP_Request2_Exception $e) {
+    } catch (NoHttpResponseException $e) {
         print 'Failed POST to URL '.var_export($url, true).': '.$e->getMessage();
     }
 }