]> git.mxchange.org Git - friendica.git/commitdiff
Avoid PHP warning with a missing key
authorMichael <heluecht@pirati.ca>
Thu, 26 Apr 2018 20:41:06 +0000 (20:41 +0000)
committerMichael <heluecht@pirati.ca>
Thu, 26 Apr 2018 20:41:06 +0000 (20:41 +0000)
src/Protocol/Diaspora.php

index 6f03c0df87ad559cd0137034cb2d9d6f0f8d5a93..70728a71baab94f0ec608091a3adf9b8c32222ac 100644 (file)
@@ -832,6 +832,10 @@ class Diaspora
 
                if (isset($parent_author_signature)) {
                        $key = self::key($msg["author"]);
+                       if (empty($key)) {
+                               logger("No key found for parent author ".$msg["author"], LOGGER_DEBUG);
+                               return false;
+                       }
 
                        if (!Crypto::rsaVerify($signed_data, $parent_author_signature, $key, "sha256")) {
                                logger("No valid parent author signature for parent author ".$msg["author"]. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$parent_author_signature, LOGGER_DEBUG);
@@ -840,6 +844,10 @@ class Diaspora
                }
 
                $key = self::key($fields->author);
+               if (empty($key)) {
+                       logger("No key found for author ".$fields->author, LOGGER_DEBUG);
+                       return false;
+               }
 
                if (!Crypto::rsaVerify($signed_data, $author_signature, $key, "sha256")) {
                        logger("No valid author signature for author ".$fields->author. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$author_signature, LOGGER_DEBUG);