Using empty on a function return value (thanks mrvdb)

Source: https://gist.github.com/mrvdb/0b49dd3c580bcfbe1358

diff --git a/actions/newnotice.php b/actions/newnotice.php
index 81438502fa67639d4ba28a9934ff22bae960dcd0..3dab96daf3caecbf39bebd6466a5c6080ea9077b 100644 (file)
--- a/actions/newnotice.php
+++ b/actions/newnotice.php
@@ -69,7 +69,7 @@ class NewnoticeAction extends FormAction
     protected function doPreparation()
     {
         foreach(array('inreplyto') as $opt) {
-            if (!empty($this->trimmed($opt))) {
+            if ($this->trimmed($opt)) {
                 $this->formOpts[$opt] = $this->trimmed($opt);
             }
         }