Merge pull request #11734 from Quix0r/fixes/added-final-check-link_item

$link_item might be boolean (no record found) under rare conditions

diff --git a/src/Navigation/Notifications/Factory/Notification.php b/src/Navigation/Notifications/Factory/Notification.php
index 10c8b54a0e7073018dc2c624370d11a4ec6ad7ac..5c1f74df4fea981d21d6d3a084278b923b697b49 100644 (file)
--- a/src/Navigation/Notifications/Factory/Notification.php
+++ b/src/Navigation/Notifications/Factory/Notification.php
@@ -183,6 +183,13 @@ class Notification extends BaseFactory implements ICanCreateFromTableRow
                                }
                        }
 
+                       // Final check on $link_item
+                       // @see https://github.com/friendica/friendica/issues/11632#issuecomment-1183365937
+                       if (empty($link_item)) {
+                               $this->logger->info('Link item is still empty. Dumping whole Notification object:', [$Notification]);
+                               return $message;
+                       }
+
                        $link = $this->baseUrl . '/display/' . urlencode($link_item['guid']);
 
                        $body = BBCode::toPlaintext($item['body'], false);