Properly defined globals, $_PEAR caused install to fail. (thanks DRiKE)

diff --git a/lib/framework.php b/lib/framework.php
index 4e9078845f7fad84e2e4d524c28a82e48c32758d..33ceba8768996ac516f8beb80d2b82a6d2aea140 100644 (file)
--- a/lib/framework.php
+++ b/lib/framework.php
@@ -73,10 +73,17 @@ if (!function_exists('dl')) {
 
 // global configuration object
 
-require_once('PEAR.php');
-require_once('PEAR/Exception.php');
-require_once('DB/DataObject.php');
-require_once('DB/DataObject/Cast.php'); # for dates
+require_once 'PEAR.php';
+require_once 'PEAR/Exception.php';
+global $_PEAR;
+$_PEAR = new PEAR;
+$_PEAR->setErrorHandling(PEAR_ERROR_CALLBACK, 'PEAR_ErrorToPEAR_Exception');
+
+require_once 'DB.php';
+require_once 'DB/DataObject.php';
+require_once 'DB/DataObject/Cast.php'; # for dates
+global $_DB;
+$_DB = new DB;
 
 require_once(INSTALLDIR.'/lib/language.php');
 
@@ -173,6 +180,3 @@ function PEAR_ErrorToPEAR_Exception($err)
     }
     throw new PEAR_Exception($err->getMessage());
 }
-
-/* global */ $_PEAR = new PEAR;
-$_PEAR->setErrorHandling(PEAR_ERROR_CALLBACK, 'PEAR_ErrorToPEAR_Exception');

diff --git a/lib/installer.php b/lib/installer.php
index 78f03b49dd4a96054f1be5c8fe8704e2c54723b6..e3135764295adf59be7328dd46b9bdbe4d127d5a 100644 (file)
--- a/lib/installer.php
+++ b/lib/installer.php
@@ -340,10 +340,8 @@ abstract class Installer
      */
     function connectDatabase($dsn)
     {
-        // @fixme move this someplace more sensible
-        //set_include_path(INSTALLDIR . '/extlib' . PATH_SEPARATOR . get_include_path());
-        require_once 'DB.php';
-        return DB::connect($dsn);
+        global $_DB;
+        return $_DB->connect($dsn);
     }
 
     /**