Various feedback items

- Add logger call on theme install failure
- Add todo in Module\Admin\DBSync

diff --git a/src/Core/Theme.php b/src/Core/Theme.php
index 37e673e404fd88a301357584a53a8f0ebed3b081..61798a3969d99e7345dc2f0559c9018db488bc96 100644 (file)
--- a/src/Core/Theme.php
+++ b/src/Core/Theme.php
@@ -177,6 +177,7 @@ class Theme
 
                        return true;
                } catch (\Exception $e) {
+                       Logger::error('Theme installation failed', ['theme' => $theme, 'error' => $e->getMessage()]);
                        return false;
                }
        }

diff --git a/src/Module/Admin/DBSync.php b/src/Module/Admin/DBSync.php
index a9c2cb6dbb963d29cbd2ea469b811386729e66e8..69001b9ce4640ce29dd236b794499a14250204a9 100644 (file)
--- a/src/Module/Admin/DBSync.php
+++ b/src/Module/Admin/DBSync.php
@@ -36,6 +36,7 @@ class DBSync extends BaseAdminModule
 \r
                if ($a->argc > 2) {\r
                        if ($a->argv[2] === 'check') {\r
+                               // @TODO Seems like a similar logic like Update::check()\r
                                $retval = DBStructure::update($a->getBasePath(), false, true);\r
                                if ($retval === '') {\r
                                        $o .= L10n::t("Database structure update %s was successfully applied.", DB_UPDATE_VERSION) . "<br />";\r