Continued with locking user accounts: (please cherry-pick)

- added user to (by JSF) called methods as he this user needs to be locked
- implemented lockUserAccount() including calling EJB (which still needs implementing)
- this method redirects back to the user's admin-profile page

Signed-off-by: Roland Häder <roland@haeder.net>
Signed-off-by: Roland Häder <roland@mxchange.org>

diff --git a/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestBean.java b/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestBean.java
index 4b12a3a2f0f7d0121470755a962b9550baccf589..13388fc4bd0069aa7f6a45e24c92fdc91cac2b4c 100644 (file)
--- a/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestBean.java
+++ b/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestBean.java
@@ -22,6 +22,7 @@ import javax.enterprise.context.RequestScoped;
 import javax.enterprise.event.Event;
 import javax.enterprise.event.Observes;
 import javax.enterprise.inject.Any;
+import javax.faces.FacesException;
 import javax.faces.view.facelets.FaceletException;
 import javax.inject.Inject;
 import javax.inject.Named;
@@ -29,6 +30,7 @@ import javax.naming.Context;
 import javax.naming.InitialContext;
 import javax.naming.NamingException;
 import org.mxchange.addressbook.beans.BaseAddressbookController;
+import org.mxchange.addressbook.beans.contact.AddressbookAdminContactWebRequestController;
 import org.mxchange.addressbook.beans.contact.AddressbookContactWebSessionController;
 import org.mxchange.addressbook.beans.helper.AddressbookWebRequestController;
 import org.mxchange.jcontacts.contact.Contact;
@@ -42,7 +44,11 @@ import org.mxchange.jusercore.events.user.update.AdminUpdatedUserDataEvent;
 import org.mxchange.jusercore.events.user.update.AdminUserDataUpdatedEvent;
 import org.mxchange.jusercore.exceptions.EmailAddressAlreadyRegisteredException;
 import org.mxchange.jusercore.exceptions.UserNameAlreadyRegisteredException;
+import org.mxchange.jusercore.exceptions.UserNotFoundException;
 import org.mxchange.jusercore.exceptions.UserPasswordRepeatMismatchException;
+import org.mxchange.jusercore.exceptions.UserStatusLockedException;
+import org.mxchange.jusercore.exceptions.UserStatusUnconfirmedException;
+import org.mxchange.jusercore.model.user.AdminUserSessionBeanRemote;
 import org.mxchange.jusercore.model.user.LoginUser;
 import org.mxchange.jusercore.model.user.User;
 import org.mxchange.jusercore.model.user.UserSessionBeanRemote;
@@ -72,7 +78,18 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
        private Event<AdminAddedUserEvent> addedUserEvent;
 
        /**
-        * Bean helper instance
+        * Regular contact controller
+        */
+       @Inject
+       private AddressbookAdminContactWebRequestController adminContactController;
+
+       /**
+        * Administrative user EJB
+        */
+       private final AdminUserSessionBeanRemote adminUserBean;
+
+       /**
+        * Admin helper instance
         */
        @Inject
        private AddressbookWebRequestController beanHelper;
@@ -91,7 +108,7 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
        private Event<AdminUpdatedUserDataEvent> updatedUserDataEvent;
 
        /**
-        * Remote user bean
+        * General user EJB
         */
        private final UserSessionBeanRemote userBean;
 
@@ -145,6 +162,7 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
 
                        // Try to lookup
                        this.userBean = (UserSessionBeanRemote) context.lookup("java:global/addressbook-ejb/user!org.mxchange.jusercore.model.user.UserSessionBeanRemote"); //NOI18N
+                       this.adminUserBean = (AdminUserSessionBeanRemote) context.lookup("java:global/addressbook-ejb/user!org.mxchange.jusercore.model.user.AdminUserSessionBeanRemote"); //NOI18N
                } catch (final NamingException e) {
                        // Throw again
                        throw new FaceletException(e);
@@ -173,8 +191,8 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
                                throw new NullPointerException("contactController.firstName is null"); //NOI18N //NOI18N
                        } else if (this.contactController.getFirstName().isEmpty()) {
                                // ... and again
-                               throw new IllegalArgumentException("contactController.firstName is empty");
-                       } else if (this.contactController.getFamilyName() == null) {
+                               throw new IllegalArgumentException("contactController.firstName is empty"); //NOI18N
+                       } else if (this.adminContactController.getFamilyName() == null) {
                                // ... and again
                                throw new NullPointerException("contactController.familyName is null"); //NOI18N
                        } else if (this.contactController.getFamilyName().isEmpty()) {
@@ -182,8 +200,8 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
                                throw new IllegalArgumentException("contactController.familyName is empty"); //NOI18N //NOI18N
                        } else if (this.contactController.getEmailAddress() == null) {
                                // ... and again
-                               throw new NullPointerException("contactController.emailAddress is null");
-                       } else if (this.contactController.getEmailAddress().isEmpty()) {
+                               throw new NullPointerException("contactController.emailAddress is null"); //NOI18N
+                       } else if (this.adminContactController.getEmailAddress().isEmpty()) {
                                // ... and again
                                throw new IllegalArgumentException("contactController.emailAddress is empty"); //NOI18N //NOI18N
                        } else if (this.contactController.getEmailAddressRepeat() == null) {
@@ -251,7 +269,7 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
                        // Now, that all is set, call EJB
                        if (this.beanHelper.getContact() instanceof Contact) {
                                // Link contact with this user
-                               User updatedUser = this.userBean.linkUser(user);
+                               User updatedUser = this.adminUserBean.linkUser(user);
 
                                // Fire event
                                this.userLinkedEvent.fire(new AdminUserLinkedEvent(updatedUser));
@@ -260,7 +278,7 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
                                this.beanHelper.setContact(null);
                        } else {
                                // Add new contact
-                               User updatedUser = this.userBean.addUser(user);
+                               User updatedUser = this.adminUserBean.addUser(user);
 
                                // Fire event
                                this.addedUserEvent.fire(new AdminUserAddedEvent(updatedUser));
@@ -425,6 +443,44 @@ public class AddressbookAdminUserWebRequestBean extends BaseAddressbookControlle
                this.userPasswordRepeat = userPasswordRepeat;
        }
 
+       @Override
+       public String lockUserAccount (final User user) {
+               // Is the user instance valid and CONFIRMED?
+               if (null == user) {
+                       // Throw NPE
+                       throw new NullPointerException("user is null"); //NOI18N
+               } else if (user.getUserId() == null) {
+                       // Throw again
+                       throw new NullPointerException("user.userId is null"); //NOI18N
+               } else if (user.getUserId() < 1) {
+                       // Invalid id number
+                       throw new IllegalArgumentException(MessageFormat.format("user.userId={0} is not valid", user.getUserId())); //NOI18N
+               } else if (user.getUserAccountStatus() == UserAccountStatus.LOCKED) {
+                       // User account is locked
+                       throw new FacesException(new UserStatusLockedException(user));
+               } else if (user.getUserAccountStatus() == UserAccountStatus.UNCONFIRMED) {
+                       // User account is locked
+                       throw new FaceletException(new UserStatusUnconfirmedException(user));
+               } else if (this.getUserLockReason() == null) {
+                       // Throw NPE again
+                       throw new NullPointerException("this.userLockReason is null"); //NOI18N
+               } else if (this.getUserLockReason().isEmpty()) {
+                       // Empty lock reason
+                       throw new IllegalArgumentException("this.userLockReason is empty"); //NOI18N
+               }
+
+               try {
+                       // Call EJB to lock account
+                       this.adminUserBean.lockUserAccount(user, this.getUserLockReason());
+               } catch (final UserStatusLockedException | UserStatusUnconfirmedException | UserNotFoundException ex) {
+                       // Throw again
+                       throw new FaceletException(ex);
+               }
+
+               // Should go fine at this point, redirect to user profile
+               return "admin_show_user?faces-redirect=true&includeViewParams=true"; //NOI18N
+       }
+
        /**
         * Clears this bean
         */

diff --git a/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestController.java b/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestController.java
index 7c4526573fa0c5ed4a4e34b024fd498c317a6976..33ed3f4e1c07a15d5e865d76aaef9ac105dfb3c2 100644 (file)
--- a/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestController.java
+++ b/src/java/org/mxchange/addressbook/beans/user/AddressbookAdminUserWebRequestController.java
@@ -18,6 +18,7 @@ package org.mxchange.addressbook.beans.user;
 
 import java.io.Serializable;
 import org.mxchange.jusercore.events.registration.UserRegisteredEvent;
+import org.mxchange.jusercore.model.user.User;
 
 /**
  * An interface for user beans
@@ -49,6 +50,16 @@ public interface AddressbookAdminUserWebRequestController extends Serializable {
         */
        String editUserData ();
 
+       /**
+        * Locks selected user's account. This method makes sure that a lock reason
+        * is provided that th user later can read on login attempts.
+        * <p>
+        * @param user User instance to be locked
+        * <p>
+        * @return Redirect outcome
+        */
+       String lockUserAccount (final User user);
+
        /**
         * Getter for user name
         * <p>

diff --git a/web/admin/user/admin_user_unlock.xhtml b/web/admin/user/admin_user_unlock.xhtml
index 06f86a245d5f6ae911c0de136f9405d0e329527b..19ec057cd5a3ce69a1a42190403e31610eabc2d3 100644 (file)
--- a/web/admin/user/admin_user_unlock.xhtml
+++ b/web/admin/user/admin_user_unlock.xhtml
@@ -78,9 +78,9 @@
                                        <div class="table_footer">
                                                <h:commandButton styleClass="reset" type="reset" value="#{msg.BUTTON_RESET_FORM}" />
 
-                                               <h:commandButton styleClass="submit" type="submit" action="#{adminUserController.lockUserAccount()}" value="#{msg.BUTTON_ADMIN_LOCK_USER_ACCOUNT}" rendered="#{beanHelper.user.userAccountStatus == UserAccountStatus.CONFIRMED}" />
+                                               <h:commandButton styleClass="submit" type="submit" action="#{adminUserController.lockUserAccount(beanHelper.user)}" value="#{msg.BUTTON_ADMIN_LOCK_USER_ACCOUNT}" rendered="#{beanHelper.user.userAccountStatus == UserAccountStatus.CONFIRMED}" />
 
-                                               <h:commandButton styleClass="submit" type="submit" action="#{adminUserController.unlockUserAccount()}" value="#{msg.BUTTON_ADMIN_UNLOCK_USER_ACCOUNT}" rendered="#{beanHelper.user.userAccountStatus == UserAccountStatus.LOCKED}" />
+                                               <h:commandButton styleClass="submit" type="submit" action="#{adminUserController.unlockUserAccount(beanHelper.user)}" value="#{msg.BUTTON_ADMIN_UNLOCK_USER_ACCOUNT}" rendered="#{beanHelper.user.userAccountStatus == UserAccountStatus.LOCKED}" />
 
                                                <h:outputText value="#{msg.ERROR_CANNOT_UN_LOCK_USER_ACCOUNT_UNCONFIRMED}" rendered="#{beanHelper.user.userAccountStatus == UserAccountStatus.UNCONFIRMED}" />
                                        </div>