]> git.mxchange.org Git - jfinancials-war.git/commitdiff
Please cherry-pick:
authorRoland Häder <roland@mxchange.org>
Thu, 22 Jun 2017 20:52:09 +0000 (22:52 +0200)
committerRoland Häder <roland@mxchange.org>
Thu, 22 Jun 2017 20:52:09 +0000 (22:52 +0200)
- New feature to allow users on registration entering no password. The
  application will then generate a random password for the user and also sends
  it in clear-text to the EJB (HTTPS is not meant here) so the bean can deliver
  it to the user.
- user registration page will now show proper messages for above feature
- removed obsolete template (seems to be still around?)
- ifBothPasswordsEmptyAllowed() implemented
- added missing i18n strings

Signed-off-by: Roland Häder <roland@mxchange.org>
src/java/org/mxchange/jfinancials/beans/user/FinancialsUserWebSessionBean.java
src/java/org/mxchange/jfinancials/beans/user/FinancialsUserWebSessionController.java
src/java/org/mxchange/jfinancials/beans/user/register/FinancialsUserRegisterWebSessionBean.java
src/java/org/mxchange/localization/bundle_de_DE.properties
src/java/org/mxchange/localization/bundle_en_US.properties
web/WEB-INF/templates/guest/user/guest_registration_form.tpl [deleted file]
web/WEB-INF/templates/guest/user/register/guest_form_register_page1.tpl
web/WEB-INF/templates/guest/user/register/guest_form_register_single.tpl
web/WEB-INF/web.xml
web/guest/user/user_register.xhtml

index 1015eb0c155bf7298676382f481dbeabc0424ef0..7b6d0136f078c4a552cbdc497609bdb670d8db49 100644 (file)
@@ -660,6 +660,14 @@ public class FinancialsUserWebSessionBean extends BaseFinancialsController imple
                this.userProfileMode = userProfileMode;
        }
 
+       @Override
+       public boolean ifBothPasswordsEmptyAllowed () {
+               // Check feature first
+               return ((this.featureController.isFeatureEnabled("allow_user_registration_empty_password")) &&
+                               ((this.getUserPassword() == null) || (this.getUserPassword().isEmpty())) &&
+                               ((this.getUserPasswordRepeat() == null) || (this.getUserPasswordRepeat().isEmpty())));
+       }
+
        /**
         * Post-initialization of this class
         */
index a29638538b21b79970b579605f18f1aa8dfebf93..336fef983d771ceef5c3489b64e0839ecf3ea8f2 100644 (file)
@@ -36,6 +36,16 @@ public interface FinancialsUserWebSessionController extends Serializable {
         */
        public static final Integer MINIMUM_PASSWORD_LENGTH = 5;
 
+       /**
+        * Checks if both user passwords are left empty and if this is enabled
+        * (allowed) in context parameter. If true, the calling bean should create a
+        * random password (preferable with UserUtils.createRandomPassword() and set
+        * it in both user password fields.
+        * <p>
+        * @return Whether empty passwords are allowed
+        */
+       boolean ifBothPasswordsEmptyAllowed ();
+
        /**
         * All users
         * <p>
index 6342b72433f6dedca96acafaf3ee2a3c1ba59c86..dd52b07b395c6969b5680106de106f32240e44b9 100644 (file)
@@ -40,7 +40,7 @@ import org.mxchange.jusercore.events.registration.UserRegisteredEvent;
 import org.mxchange.jusercore.exceptions.DataRepeatMismatchException;
 import org.mxchange.jusercore.exceptions.EmailAddressAlreadyRegisteredException;
 import org.mxchange.jusercore.exceptions.UserNameAlreadyRegisteredException;
-import org.mxchange.jusercore.model.register.UserRegistrationSessionBeanRemote;
+import org.mxchange.jusercore.model.user.register.UserRegistrationSessionBeanRemote;
 import org.mxchange.jusercore.model.user.User;
 import org.mxchange.jusercore.model.user.UserUtils;
 import org.mxchange.jusercore.model.user.status.UserAccountStatus;
@@ -114,6 +114,9 @@ public class FinancialsUserRegisterWebSessionBean extends BaseFinancialsControll
                // Get user instance
                User user = this.userController.createUserInstance(true);
 
+               // Null random password means registration requires user-entered password
+               String randomPassword = null;
+
                // Is the user already used?
                if (null == user) {
                        // user must be set
@@ -122,17 +125,53 @@ public class FinancialsUserRegisterWebSessionBean extends BaseFinancialsControll
                        // Not all required fields are set
                        throw new FaceletException("Not all required fields are set."); //NOI18N
                } else if ((this.featureController.isFeatureEnabled("user_name_required")) && (this.userController.isUserNameRegistered(user))) { //NOI18N
-                       // User name is already used
-                       throw new FaceletException(new UserNameAlreadyRegisteredException(user));
+                       // Is multi-page enabled?
+                       if (this.featureController.isFeatureEnabled("user_register_multiple_page")) { //NOI18N
+                               // User name is already used, should not happen here
+                               throw new FaceletException(new UserNameAlreadyRegisteredException(user));
+                       } else {
+                               // May happen here, reset field
+                               this.userController.setUserName(null);
+                               this.showFacesMessage("form_register_single:userName", "ERROR_USER_NAME_ALREADY_USED"); //NOI18N
+                               return ""; //NOI18N
+                       }
                } else if (this.contactController.isEmailAddressRegistered(user.getUserContact())) {
-                       // Email address has already been taken
-                       throw new FaceletException(new EmailAddressAlreadyRegisteredException(user));
+                       // Is multi-page enabled?
+                       if (this.featureController.isFeatureEnabled("user_register_multiple_page")) { //NOI18N
+                               // Email address has already been taken, should not happen here
+                               throw new FaceletException(new EmailAddressAlreadyRegisteredException(user));
+                       } else {
+                               // May happen here, reset fields
+                               this.contactController.setEmailAddress(null);
+                               this.contactController.setEmailAddressRepeat(null);
+                               this.showFacesMessage("form_register_single:emailAddressRepeat", "ERROR_EMAIL_ADDRESS_ALREADY_USED"); //NOI18N
+                               return ""; //NOI18N
+                       }
                } else if (!this.contactController.isSameEmailAddressEntered()) {
-                       // Not same email address entered
-                       throw new FaceletException(new DataRepeatMismatchException(MessageFormat.format("Email addresses not matching: {0} != {1}", this.contactController.getEmailAddress(), this.contactController.getEmailAddressRepeat()))); //NOI18N
+                       // Is multi-page enabled?
+                       if (this.featureController.isFeatureEnabled("user_register_multiple_page")) { //NOI18N
+                               // Not same email address entered, should not happen here
+                               throw new FaceletException(new DataRepeatMismatchException(MessageFormat.format("Email addresses not matching: {0} != {1}", this.contactController.getEmailAddress(), this.contactController.getEmailAddressRepeat()))); //NOI18N
+                       } else {
+                               // May happen here, reset fields
+                               this.contactController.setEmailAddress(null);
+                               this.contactController.setEmailAddressRepeat(null);
+                               this.showFacesMessage("form_register_single:emailAddressRepeat", "ERROR_EMAIL_ADDRESSES_MISMATCHING"); //NOI18N
+                               return ""; //NOI18N
+                       }
                } else if (!this.userController.isSamePasswordEntered()) {
-                       // Not same password entered
-                       throw new FaceletException(new DataRepeatMismatchException("Passwords not matching.")); //NOI18N
+                       // Is multi-page enabled?
+                       if (this.featureController.isFeatureEnabled("user_register_multiple_page")) { //NOI18N
+                               // Not same password entered, should no longer happen here
+                               throw new FaceletException(new DataRepeatMismatchException("Passwords not matching.")); //NOI18N
+                       } else if (this.userController.ifBothPasswordsEmptyAllowed()) {
+                               // Both passwords are left empty and is allowed, then generate a random password
+                               randomPassword = UserUtils.createRandomPassword(FinancialsUserWebSessionController.MINIMUM_PASSWORD_LENGTH);
+
+                               // Set it in both fields
+                               this.userController.setUserPassword(randomPassword);
+                               this.userController.setUserPasswordRepeat(randomPassword);
+                       }
                }
 
                // Encrypt password
@@ -161,7 +200,7 @@ public class FinancialsUserRegisterWebSessionBean extends BaseFinancialsControll
                        String baseUrl = FacesUtils.generateBaseUrl();
 
                        // Call bean
-                       User registeredUser = this.registerBean.registerUser(user, baseUrl);
+                       User registeredUser = this.registerBean.registerUser(user, baseUrl, randomPassword);
 
                        // The id number should be set
                        assert (registeredUser.getUserId() instanceof Long) : "registeredUser.userId is null after registerUser() was called."; //NOI18N
@@ -193,11 +232,35 @@ public class FinancialsUserRegisterWebSessionBean extends BaseFinancialsControll
                        // user must be set
                        throw new NullPointerException("user is null after createUserInstance() was called"); //NOI18N
                } else if ((this.featureController.isFeatureEnabled("user_name_required")) && (this.userController.isUserNameRegistered(user))) { //NOI18N
-                       // User name is already used
-                       throw new FaceletException(new UserNameAlreadyRegisteredException(user));
+                       // User name is already used, so clear it
+                       this.userController.setUserName(null);
+                       this.showFacesMessage("form_register_page1:userName", "ERROR_USER_NAME_ALREADY_USED"); //NOI18N
+                       return ""; //NOI18N
                } else if (!this.contactController.isSameEmailAddressEntered()) {
-                       // Not same email address entered
-                       throw new FaceletException(new DataRepeatMismatchException(MessageFormat.format("Email addresses not matching: {0} != {1}", this.contactController.getEmailAddress(), this.contactController.getEmailAddressRepeat()))); //NOI18N
+                       // Not same email address entered, clear both
+                       this.contactController.setEmailAddress(null);
+                       this.contactController.setEmailAddressRepeat(null);
+                       this.showFacesMessage("form_register_page1:emailAddressRepeat", "ERROR_EMAIL_ADDRESSES_MISMATCHING"); //NOI18N
+                       return ""; //NOI18N
+               } else if (!this.userController.isSamePasswordEntered()) {
+                       // Is multi-page enabled?
+                       if (this.featureController.isFeatureEnabled("user_register_multiple_page")) { //NOI18N
+                               // Unset both
+                               this.userController.setUserPassword(null);
+                               this.userController.setUserPasswordRepeat(null);
+
+                               // Output faces message
+                               this.showFacesMessage("form_register_page1:userPassword", "ERROR_USER_PASSWORD_EMPTY"); //NOI18N
+                               this.showFacesMessage("form_register_page1:userPasswordRepeat", "ERROR_USER_PASSWORD_REPEAT_EMPTY"); //NOI18N
+                               return ""; //NOI18N
+                       } else if (this.userController.ifBothPasswordsEmptyAllowed()) {
+                               // Both passwords are left empty and is allowed, then generate a random password
+                               String randomPassword = UserUtils.createRandomPassword(FinancialsUserWebSessionController.MINIMUM_PASSWORD_LENGTH);
+
+                               // Set it in both fields
+                               this.userController.setUserPassword(randomPassword);
+                               this.userController.setUserPasswordRepeat(randomPassword);
+                       }
                }
 
                // Create half contact instance with email address
@@ -209,12 +272,15 @@ public class FinancialsUserRegisterWebSessionBean extends BaseFinancialsControll
 
                // Check if email address is registered
                if (this.contactController.isEmailAddressRegistered(user.getUserContact())) {
-                       // Email address has already been taken
-                       throw new FaceletException(new EmailAddressAlreadyRegisteredException(user));
+                       // Email address has already been taken, clear both
+                       this.contactController.setEmailAddress(null);
+                       this.contactController.setEmailAddressRepeat(null);
+                       this.showFacesMessage("form_register_page1:emailAddress", "ERROR_EMAIL_ADDRESS_ALREADY_USED"); //NOI18N
+                       return ""; //NOI18N
                }
 
                // Now only redirect to next page as the JSF does it
-               return "user_register_page2"; //NOI18N
+               return "register_page2"; //NOI18N
        }
 
        /**
index f01073a86946fefc45c549d0c1de40c30cedadb1..0a205e181a63294e0487ac69021a16116e204274 100644 (file)
@@ -800,3 +800,10 @@ FIELD_FINANCIAL_INCOME_SINGLE_VALUE_REQUIRED=Feld "Einkommensbetrag" bitte ausfu
 LOGIN_FINANCIAL_INCOME_TITLE=Bezeichnung der Einkommensart:
 #@TODO Please fix German umlauts!
 FIELD_FINANCIAL_INCOME_TITLE_REQUIRED=Feld "Title" muss ausgefuellt werden.
+#@TODO Please fix German umlauts!
+ERROR_USER_PASSWORD_EMPTY=Sie muessen ein Passwort eingeben.
+#@TODO Please fix German umlauts!
+ERROR_USER_PASSWORD_REPEAT_EMPTY=Sie muessen das eingegebene Passwort wiederholen.
+GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_ALLOWED=Lassen Sie beide Passwortfelder leer, wird Ihnen ein Passwort per Zufall generiert.
+#@TODO Please fix German umlauts!
+GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_NOT_ALLOWED=Sie muessen selbst ein Passwort vergeben. Bitte geben Sie dies zur Bestaetigung zweimal ein.
index fbbb2376fa5dc0cf033832c04cccd7aa4de6b9da..b57c0e5d70390501da52c38205fffd448af142ab 100644 (file)
@@ -786,3 +786,7 @@ LOGIN_FINANCIAL_INCOME_SINGLE_VALUE=Income value:
 FIELD_FINANCIAL_INCOME_SINGLE_VALUE_REQUIRED=Field "Income value" must be filled out.
 LOGIN_FINANCIAL_INCOME_TITLE=Title of income type:
 FIELD_FINANCIAL_INCOME_TITLE_REQUIRED=Field "Title" must be filled out.
+ERROR_USER_PASSWORD_EMPTY=You have to enter a password.
+ERROR_USER_PASSWORD_REPEAT_EMPTY=You have to repeat the entered password.
+GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_ALLOWED=If you left both password fields empty, a random password will generated for you.
+GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_NOT_ALLOWED=You have to enter an own password. Please enter it twice for confirmation.
diff --git a/web/WEB-INF/templates/guest/user/guest_registration_form.tpl b/web/WEB-INF/templates/guest/user/guest_registration_form.tpl
deleted file mode 100644 (file)
index 7c46749..0000000
+++ /dev/null
@@ -1,108 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
-<ui:composition
-       xmlns="http://www.w3.org/1999/xhtml"
-       xmlns:f="http://java.sun.com/jsf/core"
-       xmlns:h="http://java.sun.com/jsf/html"
-       xmlns:ui="http://xmlns.jcp.org/jsf/facelets">
-
-       <h:form id="register_page2_form">
-               <div class="table">
-                       <div class="table_header">
-                               <h:outputText value="#{msg.GUEST_REGISTRATION_PAGE2_TITLE}" />
-                       </div>
-
-                       <ui:include src="/WEB-INF/templates/contact/form_contact_data.tpl" />
-
-                       <div class="para">
-                               <fieldset id="login_data">
-                                       <legend title="#{msg.GUEST_REGISTRATION_EMAIL_LEGEND_TITLE}">#{msg.GUEST_REGISTRATION_EMAIL_LEGEND}</legend>
-
-                                       <div class="table_row">
-                                               <div class="table_left">
-                                                       <h:outputLabel for="userName" value="#{msg.GUEST_REGISTRATION_ENTER_USER_NAME}" />
-                                               </div>
-
-                                               <div class="table_right">
-                                                       <h:inputText styleClass="input" id="userName" size="20" maxlength="255" value="#{userController.userName}" required="true" requiredMessage="#{msg.GUEST_REGISTRATION_USER_NAME_NOT_ENTERED}" />
-                                               </div>
-
-                                               <div class="clear"></div>
-                                       </div>
-
-                                       <h:panelGroup styleClass="error_container" layout="block">
-                                               <h:message for="userName" errorClass="errors" fatalClass="errors" warnClass="errors" />
-                                       </h:panelGroup>
-
-                                       <div class="table_row">
-                                               <div class="table_left">
-                                                       <h:outputLabel for="emailAddress" value="#{msg.GUEST_REGISTRATION_ENTER_EMAIL1}" />
-                                               </div>
-
-                                               <div class="table_right">
-                                                       <h:inputText styleClass="input" id="emailAddress" size="20" maxlength="255" value="#{contactController.emailAddress}" required="true" requiredMessage="#{msg.EMAIL_ADDRESS_NOT_ENTERED}" />
-                                               </div>
-
-                                               <div class="clear"></div>
-                                       </div>
-
-                                       <h:panelGroup styleClass="error_container" layout="block">
-                                               <h:message for="emailAddress" errorClass="errors" fatalClass="errors" warnClass="errors" />
-                                       </h:panelGroup>
-
-                                       <div class="table_row">
-                                               <div class="table_left">
-                                                       <h:outputLabel for="emailAddressRepeat" value="#{msg.GUEST_REGISTRATION_ENTER_EMAIL2}" />
-                                               </div>
-
-                                               <div class="table_right">
-                                                       <h:inputText styleClass="input" id="emailAddressRepeat" size="20" maxlength="255" value="#{contactController.emailAddressRepeat}" required="true" requiredMessage="#{msg.EMAIL_ADDRESS_REPEAT_NOT_ENTERED}" />
-                                               </div>
-
-                                               <div class="clear"></div>
-                                       </div>
-
-                                       <h:panelGroup styleClass="error_container" layout="block">
-                                               <h:message for="emailAddressRepeat" errorClass="errors" fatalClass="errors" warnClass="errors" />
-                                       </h:panelGroup>
-
-                                       <div class="para"></div>
-
-                                       <div class="table_row">
-                                               <div class="table_left">
-                                                       <h:outputLabel for="userPassword" value="#{msg.GUEST_REGISTRATION_ENTER_PASSWORD}" />
-                                               </div>
-
-                                               <div class="table_right">
-                                                       <h:inputSecret styleClass="input" id="userPassword" size="10" maxlength="255" value="#{userController.userPassword}" />
-                                               </div>
-
-                                               <div class="clear"></div>
-                                       </div>
-
-                                       <div class="table_row">
-                                               <div class="table_left">
-                                                       <h:outputLabel for="userPasswordRepeat" value="#{msg.GUEST_REGISTRATION_ENTER_PASSWORD_REPEAT}" />
-                                               </div>
-
-                                               <div class="table_right">
-                                                       <h:inputSecret styleClass="input" id="userPasswordRepeat" size="10" maxlength="255" value="#{userController.userPasswordRepeat}" />
-                                               </div>
-
-                                               <div class="clear"></div>
-                                       </div>
-
-                                       <div class="para notice">
-                                               <h:outputText value="#{msg.GUEST_REGISTRATION_USER_NAME_NOTICE}" />
-                                       </div>
-                               </fieldset>
-                       </div>
-
-                       <ui:include src="/WEB-INF/templates/guest/guest_privacy_terms.tpl" />
-
-                       <div class="table_footer">
-                               <h:commandButton styleClass="reset" type="reset" value="#{msg.BUTTON_RESET_FORM}" />
-                               <h:commandButton styleClass="submit" type="submit" id="register" value="#{msg.BUTTON_FINISH_REGISTRATION}" action="#{registerController.doFinishRegistration()}" />
-                       </div>
-               </div>
-       </h:form>
-</ui:composition>
index aba8452c9e5d261380db4e7dc93ae146344babf3..e53ce9ecf917faffeac681e164d12330a3cc0cf8 100644 (file)
                                                </h:panelGroup>
 
                                                <div class="para notice">
-                                                       <h:outputText value="#{msg.GUEST_REGISTRATION_USER_NAME_NOTICE}" />
+                                                       <ul>
+                                                               <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_NAME_NOTICE}" /></li>
+                                                               <ui:fragment rendered="#{featureController.isFeatureEnabled('allow_user_registration_empty_password')}">
+                                                                       <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_ALLOWED}" /></li>
+                                                               </ui:fragment>
+                                                               <ui:fragment rendered="#{not featureController.isFeatureEnabled('allow_user_registration_empty_password')}">
+                                                                       <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_NOT_ALLOWED}" /></li>
+                                                               </ui:fragment>
+                                                       </ul>
                                                </div>
                                        </ui:fragment>
                                </fieldset>
index 9a1dd99aa7841f2697504bd01e7e799d5e1e12dd..312d8ab10295b0d22239532eef944eddb9f4dbbb 100644 (file)
                                                </h:panelGroup>
 
                                                <div class="para notice">
-                                                       <h:outputText value="#{msg.GUEST_REGISTRATION_USER_NAME_NOTICE}" />
+                                                       <ul>
+                                                               <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_NAME_NOTICE}" /></li>
+                                                               <ui:fragment rendered="#{featureController.isFeatureEnabled('allow_user_registration_empty_password')}">
+                                                                       <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_ALLOWED}" /></li>
+                                                               </ui:fragment>
+                                                               <ui:fragment rendered="#{not featureController.isFeatureEnabled('allow_user_registration_empty_password')}">
+                                                                       <li><h:outputText value="#{msg.GUEST_REGISTRATION_USER_PASSWORDS_EMPTY_NOT_ALLOWED}" /></li>
+                                                               </ui:fragment>
+                                                       </ul>
                                                </div>
                                        </ui:fragment>
                                </fieldset>
index b7721a268f15c1c681d19a567b6b899391c7cbc6..cb0e2256c02e7e7bc87d1db4e3d17f4d96242499 100644 (file)
         <param-name>is_feature_user_registration_in_index_enabled</param-name>
         <param-value>false</param-value>
     </context-param>
+    <context-param>
+        <description>Whether user can leave both passwords empty on registration.</description>
+        <param-name>allow_user_registration_empty_password</param-name>
+        <param-value>false</param-value>
+    </context-param>
     <context-param>
         <description>Maximum passwords that must be different.</description>
         <param-name>max_user_password_history</param-name>
index a2a30bfd94fd940f60ed654d3d35c1843a1271e3..7d238fb582e1bb6d8a493acd4a0c9de7972e8372 100644 (file)
                <ui:define name="content">
                        <ui:fragment rendered="#{not featureController.isFeatureEnabled('user_registration_in_index') and featureController.isFeatureEnabled('user_registration')}">
                                <ui:fragment rendered="#{featureController.isFeatureEnabled('user_name_required')}">
-                                       <div class="para">
+                                       <h:panelGroup styleClass="para" layout="block">
                                                <h:outputText value="#{msg.GUEST_ALREADY_USER_CONTINUE_LOGIN_1}" />
                                                <h:outputText value="&nbsp;" />
                                                <h:link outcome="user_login" value="#{msg.CLICK_HERE}" />
                                                <h:outputText value="&nbsp;" />
                                                <h:outputText value="#{msg.GUEST_ALREADY_USER_CONTINUE_LOGIN_2}" />
-                                       </div>
+                                       </h:panelGroup>
                                </ui:fragment>
 
                                <h:panelGroup layout="block" styleClass="registration_form">