base class is_readonly() now returns false by default

darcs-hash:20080722212056-ca946-e4bd9eef8e3d8991414932e9fc7b8c9a31f818c0.gz

diff --git a/actions/avatar.php b/actions/avatar.php
index b1697f97bbb734a3e09d1f5d1bd6bc91de95cfd9..ebfbd72952e9d1bec9ec315d3c958c948de38e4b 100644 (file)
--- a/actions/avatar.php
+++ b/actions/avatar.php
@@ -23,10 +23,6 @@ require_once(INSTALLDIR.'/lib/settingsaction.php');
 
 class AvatarAction extends SettingsAction {
 
-       function is_readonly() {
-               return false;
-       }
-
     function get_instructions() {
                return _('Upload a new "avatar" (user image) here. You can\'t edit the picture after you upload it, so make sure it\'s more or less square. It must be under the site license, also. Use a picture that belongs to you and that you want to share.');
        }

diff --git a/actions/confirmaddress.php b/actions/confirmaddress.php
index 66a41d9d7da051aaf7e48509a714a9f2a922068c..3cffda8710b59c15efa87ca347c22e087df3e073 100644 (file)
--- a/actions/confirmaddress.php
+++ b/actions/confirmaddress.php
@@ -21,10 +21,6 @@ if (!defined('LACONICA')) { exit(1); }
 
 class ConfirmaddressAction extends Action {
 
-       function is_readonly() {
-               return false;
-       }
-
     function handle($args) {
         parent::handle($args);
         if (!common_logged_in()) {

diff --git a/actions/finishaddopenid.php b/actions/finishaddopenid.php
index af96635d624a63a455fc342d0ecb27adc26edfe2..54d81b0b4e538efd0ba3c60d43f7d22566daaf53 100644 (file)
--- a/actions/finishaddopenid.php
+++ b/actions/finishaddopenid.php
@@ -31,10 +31,6 @@ class FinishaddopenidAction extends Action {
                        $this->try_login();
                }
        }
-
-       function is_readonly() {
-               return false;
-       }
        
        function try_login() {
 

diff --git a/actions/finishremotesubscribe.php b/actions/finishremotesubscribe.php
index bce2447ac7a256a05d53e3983582956da0989530..ba5156a204ff770bb25218e43b4fc190259af739 100644 (file)
--- a/actions/finishremotesubscribe.php
+++ b/actions/finishremotesubscribe.php
@@ -23,10 +23,6 @@ require_once(INSTALLDIR.'/lib/omb.php');
 
 class FinishremotesubscribeAction extends Action {
 
-       function is_readonly() {
-               return false;
-       }
-
        function handle($args) {
 
                parent::handle($args);

diff --git a/actions/foaf.php b/actions/foaf.php
index 8de4c75028bb1f3855383eb5112d08ea18f49f25..c64617e5f04c566bc7edbb00b3265154019daf2f 100644 (file)
--- a/actions/foaf.php
+++ b/actions/foaf.php
@@ -25,6 +25,10 @@ define('BOTH', 0);
 
 class FoafAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
 

diff --git a/actions/login.php b/actions/login.php
index 0f2dec1a41e38ba9403f4eedcde91b9a0b83e7ed..aa25a0cec5fb3a179524100c5a0af15dd25290a2 100644 (file)
--- a/actions/login.php
+++ b/actions/login.php
@@ -21,6 +21,10 @@ if (!defined('LACONICA')) { exit(1); }
 
 class LoginAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
                if (common_is_real_login()) {

diff --git a/actions/logout.php b/actions/logout.php
index fb61689ee8ccf06aeea7390845c1d8f5e0077322..f00fa0ba7f2f39298e77cdd365099b3d53cb8954 100644 (file)
--- a/actions/logout.php
+++ b/actions/logout.php
@@ -22,6 +22,11 @@ if (!defined('LACONICA')) { exit(1); }
 require_once(INSTALLDIR.'/lib/openid.php');
 
 class LogoutAction extends Action {
+       
+       function is_readonly() {
+               return true;
+       }
+       
        function handle($args) {
                parent::handle($args);
                if (!common_logged_in()) {

diff --git a/actions/newnotice.php b/actions/newnotice.php
index 487396e4e16cfcbfd9c6423fdbea720a6cbb8c1f..711b77e0a9b261a98cec1144509ee2c159ad5de0 100644 (file)
--- a/actions/newnotice.php
+++ b/actions/newnotice.php
@@ -20,11 +20,7 @@
 if (!defined('LACONICA')) { exit(1); }
 
 class NewnoticeAction extends Action {
-
-       function is_readonly() {
-               return false;
-       }
-
+       
        function handle($args) {
                parent::handle($args);
                # XXX: Ajax!

diff --git a/actions/postnotice.php b/actions/postnotice.php
index 3b5a4ee1536264ad24da69956fd0128838d27187..ab12277bbdd5fe734eed61290a52befdf05b2a43 100644 (file)
--- a/actions/postnotice.php
+++ b/actions/postnotice.php
@@ -21,10 +21,6 @@ if (!defined('LACONICA')) { exit(1); }
 
 require_once(INSTALLDIR.'/lib/omb.php');
 
-function is_readonly() {
-       return false;
-}
-
 class PostnoticeAction extends Action {
        function handle($args) {
                parent::handle($args);

diff --git a/actions/publicxrds.php b/actions/publicxrds.php
index 29c8e13145f25ded8c342c9b866ba12fc1250516..951434c8783015f114079d75fd038cfd85e75522 100644 (file)
--- a/actions/publicxrds.php
+++ b/actions/publicxrds.php
@@ -25,6 +25,10 @@ require_once(INSTALLDIR.'/lib/openid.php');
 
 class PublicxrdsAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
 
                parent::handle($args);

diff --git a/actions/recoverpassword.php b/actions/recoverpassword.php
index 0d85163d74d03bbaf0b640ff7773c108a6df51c1..9c34ff3d84149ea1a28f8bdb5dddd47337fbc321 100644 (file)
--- a/actions/recoverpassword.php
+++ b/actions/recoverpassword.php
@@ -25,10 +25,6 @@ define(MAX_RECOVERY_TIME, 24 * 60 * 60);
 
 class RecoverpasswordAction extends Action {
 
-       function is_readonly() {
-               return false;
-       }
-
     function handle($args) {
         parent::handle($args);
         if (common_logged_in()) {

diff --git a/actions/register.php b/actions/register.php
index 0d6338797c4cd8da837cce40893f21f795bc542d..6ac28305953fc7b1644c48bdcb297ea984cf1fff 100644 (file)
--- a/actions/register.php
+++ b/actions/register.php
@@ -21,10 +21,6 @@ if (!defined('LACONICA')) { exit(1); }
 
 class RegisterAction extends Action {
 
-       function is_readonly() {
-               return false;
-       }
-
        function handle($args) {
                parent::handle($args);
 

diff --git a/actions/requesttoken.php b/actions/requesttoken.php
index 0e233ff1794d1ab094a814db94b841e6feaf8109..09ce5a6425f71671e29b07a7e1d2b80cb806c865 100644 (file)
--- a/actions/requesttoken.php
+++ b/actions/requesttoken.php
@@ -22,6 +22,11 @@ if (!defined('LACONICA')) { exit(1); }
 require_once(INSTALLDIR.'/lib/omb.php');
 
 class RequesttokenAction extends Action {
+       
+       function is_readonly() {
+               return true;
+       }
+       
        function handle($args) {
                parent::handle($args);
                try {

diff --git a/actions/subscribe.php b/actions/subscribe.php
index 7ce50dac8cb0ecf944657ce9d0f71f8b5cda5539..e292fdd6be94cfb2725ce7c84af0549f9d1530a1 100644 (file)
--- a/actions/subscribe.php
+++ b/actions/subscribe.php
@@ -21,10 +21,6 @@ if (!defined('LACONICA')) { exit(1); }
 
 class SubscribeAction extends Action {
        
-       function is_readonly() {
-               return false;
-       }
-       
        function handle($args) {
                parent::handle($args);
 

diff --git a/actions/twitapidirect_messages.php b/actions/twitapidirect_messages.php
index e7f3e1266657b830089038dbe4782c4ebb3e5b7d..9a84082e6d1293be39d9b628062b45402936ff55 100644 (file)
--- a/actions/twitapidirect_messages.php
+++ b/actions/twitapidirect_messages.php
@@ -23,6 +23,21 @@ require_once(INSTALLDIR.'/lib/twitterapi.php');
 
 class Twitapidirect_messagesAction extends TwitterapiAction {
 
+
+       function is_readonly() {
+               
+               static $write_methods = array(  'direct_messages', 
+                                                                               'sent');
+               
+               $cmdtext = explode('.', $this->arg('method'));          
+               
+               if (in_array($cmdtext[0], $write_methods)) {                    
+                       return false;
+               }
+                               
+               return true;
+       }
+
        function direct_messages($args, $apidata) {
                parent::handle($args);
                common_server_error("API method under construction.", $code=501);

diff --git a/actions/twitapifavorites.php b/actions/twitapifavorites.php
index a4afa732a00a9024c2fd48ca25a213c9e8ef3c6a..4de5676034764fde61fb7db195398030560e0b09 100644 (file)
--- a/actions/twitapifavorites.php
+++ b/actions/twitapifavorites.php
@@ -23,6 +23,19 @@ require_once(INSTALLDIR.'/lib/twitterapi.php');
 
 class TwitapifavoritesAction extends TwitterapiAction {
 
+       function is_readonly() {
+               
+               static $write_methods = array('favorites');
+               
+               $cmdtext = explode('.', $this->arg('method'));          
+               
+               if (in_array($cmdtext[0], $write_methods)) {                    
+                       return false;
+               }
+                               
+               return true;
+       }
+
        function favorites($args, $apidata) {
                parent::handle($args);
                common_server_error("API method under construction.", $code=501);

diff --git a/actions/twitapihelp.php b/actions/twitapihelp.php
index e07c9b6672ef8b4b80280557777294e9a59bdf63..7695190fca1f6212bf9894b9e17510383bd6657c 100644 (file)
--- a/actions/twitapihelp.php
+++ b/actions/twitapihelp.php
@@ -23,6 +23,10 @@ require_once(INSTALLDIR.'/lib/twitterapi.php');
 
 class TwitapihelpAction extends TwitterapiAction {
 
+       function is_readonly() {                
+               return true;
+       }
+
        /* Returns the string "ok" in the requested format with a 200 OK HTTP status code.
         * URL:http://identi.ca/api/help/test.format
         * Formats: xml, json

diff --git a/actions/twitapinotifications.php b/actions/twitapinotifications.php
index 45a33427bc389e1d95c735e7bcf913951160fb38..95fe550b1266a55b86100a4ec6014cd42eb8e270 100644 (file)
--- a/actions/twitapinotifications.php
+++ b/actions/twitapinotifications.php
@@ -24,7 +24,6 @@ require_once(INSTALLDIR.'/lib/twitterapi.php');
 # This naming convention looks real sick
 class TwitapinotificationsAction extends TwitterapiAction {
 
-
        function follow($args, $apidata) {
                parent::handle($args);
                common_server_error("API method under construction.", $code=501);

diff --git a/actions/unsubscribe.php b/actions/unsubscribe.php
index 69d5139073a60c2a3d1fd47e1594a732ba86e772..3863a3a5e382c90aff37631b2f726b41c4f2a0b2 100644 (file)
--- a/actions/unsubscribe.php
+++ b/actions/unsubscribe.php
@@ -19,10 +19,6 @@
 
 class UnsubscribeAction extends Action {
        
-       function is_readonly() {
-               return false;
-       }
-       
        function handle($args) {
                parent::handle($args);
                if (!common_logged_in()) {

diff --git a/actions/updateprofile.php b/actions/updateprofile.php
index 72246dab884a4dfc5c56e43d019c0d3d0b1623b1..7e604f6b10fdd04ca8fcf238bc08f11dbcd6bb4d 100644 (file)
--- a/actions/updateprofile.php
+++ b/actions/updateprofile.php
@@ -22,10 +22,6 @@ if (!defined('LACONICA')) { exit(1); }
 require_once(INSTALLDIR.'/lib/omb.php');
 
 class UpdateprofileAction extends Action {
-
-       function is_readonly() {
-               return false;
-       }
        
        function handle($args) {
                parent::handle($args);

diff --git a/actions/userauthorization.php b/actions/userauthorization.php
index b02fe96ceebafff990fbd35d5a05c4572a04bceb..6ae3434a6d5863b7c3a141a6a4b1dba7b9cb84cb 100644 (file)
--- a/actions/userauthorization.php
+++ b/actions/userauthorization.php
@@ -23,10 +23,6 @@ require_once(INSTALLDIR.'/lib/omb.php');
 define('TIMESTAMP_THRESHOLD', 300);
 
 class UserauthorizationAction extends Action {
-
-       function is_readonly() {
-               return false;
-       }
        
        function handle($args) {
                parent::handle($args);

diff --git a/actions/userbyid.php b/actions/userbyid.php
index 7b95d0725966ec9791b77103fa08e2109597ee1a..c42cad0836567049818a066fd82b0834f201834a 100644 (file)
--- a/actions/userbyid.php
+++ b/actions/userbyid.php
@@ -20,6 +20,11 @@
 if (!defined('LACONICA')) { exit(1); }
 
 class UserbyidAction extends Action {
+       
+       function is_readonly() {                                
+               return true;
+       }
+       
     function handle($args) {
         parent::handle($args);
         $id = $this->trimmed('id');

diff --git a/actions/xrds.php b/actions/xrds.php
index 70a18a6b9ba37b1ea4405646222662885e04d2a5..1d516aab72e78d6681e7b6d614f71810fc146eb5 100644 (file)
--- a/actions/xrds.php
+++ b/actions/xrds.php
@@ -23,6 +23,10 @@ require_once(INSTALLDIR.'/lib/omb.php');
 
 class XrdsAction extends Action {
 
+       function is_readonly() {                                
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
                $nickname = $this->trimmed('nickname');

diff --git a/lib/action.php b/lib/action.php
index 1dca596eb851a19699b3aa8dd6e23436bd43b713..1d3614ae1d6f57b044472e8061eb6f3b6728edfa 100644 (file)
--- a/lib/action.php
+++ b/lib/action.php
@@ -27,7 +27,7 @@ class Action { // lawsuit
        }
 
        function is_readonly() {
-               return true;
+               return false;
        }
 
        function arg($key, $def=NULL) {

diff --git a/lib/gallery.php b/lib/gallery.php
index 4f3c18ff91466135384f86e0b8a7a30df2c339fa..c6f1585b4bb77886ae198f764e9fcfc2e7858625 100644 (file)
--- a/lib/gallery.php
+++ b/lib/gallery.php
@@ -25,6 +25,10 @@ define('AVATARS_PER_PAGE', 80);
 
 class GalleryAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
                $nickname = $this->arg('nickname');

diff --git a/lib/rssaction.php b/lib/rssaction.php
index e8a3aca70bd3ea500ce9ba1b76feded45dfce064..76859a876ad0d31b3841ca02ad70da72d31e140d 100644 (file)
--- a/lib/rssaction.php
+++ b/lib/rssaction.php
@@ -25,6 +25,10 @@ class Rss10Action extends Action {
 
        # This will contain the details of each feed item's author and be used to generate SIOC data.
        var $creators = array();
+
+       function is_readonly() {
+               return true;
+       }
        
        function handle($args) {
                parent::handle($args);

diff --git a/lib/searchaction.php b/lib/searchaction.php
index 729cfe6d402d4f2e9f1da19f8df20fec02c4bd95..46779bf7acdc63e69484b77e6acda63bf5d5c103 100644 (file)
--- a/lib/searchaction.php
+++ b/lib/searchaction.php
@@ -21,6 +21,10 @@ if (!defined('LACONICA')) { exit(1); }
 
 class SearchAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
                $this->show_form();

diff --git a/lib/settingsaction.php b/lib/settingsaction.php
index 0e39a7459763e8e366c8fd2e5ee65c2f3c6ca94e..a71c9e9bc3e8384f9cb0db98e120eb6a2096d928 100644 (file)
--- a/lib/settingsaction.php
+++ b/lib/settingsaction.php
@@ -21,10 +21,6 @@ if (!defined('LACONICA')) { exit(1); }
 
 class SettingsAction extends Action {
 
-       function is_readonly() {
-               return false;
-       }
-
     function handle($args) {
         parent::handle($args);
         if (!common_logged_in()) {

diff --git a/lib/stream.php b/lib/stream.php
index a595958e44e27a8e806a49f205064b8917bdfd8f..fefd77a46176316526a39bce60db051d33e61353 100644 (file)
--- a/lib/stream.php
+++ b/lib/stream.php
@@ -21,6 +21,10 @@ if (!defined('LACONICA')) { exit(1); }
 
 class StreamAction extends Action {
 
+       function is_readonly() {
+               return true;
+       }
+
        function handle($args) {
                parent::handle($args);
        }