Some fixes:

- let's use more $() instead of ``
- only fetch, not pull (which includes a merge)

Signed-off-by: Roland Häder <roland@mxchange.org>

diff --git a/cherry-jprojects.sh b/cherry-jprojects.sh
index 38b989023e04c0361898f3362c81af39c9ca4bf8..627d59d5daa7135c18eadb73c29f6cd7ec19d530 100755 (executable)
--- a/cherry-jprojects.sh
+++ b/cherry-jprojects.sh
@@ -19,13 +19,13 @@ for project in ${LIST}; do
                continue
        fi
 
-       COMMIT_IDS=`cat "${COMMITS_FILE}"`
+       COMMIT_IDS=$(cat "${COMMITS_FILE}")
 
        if [ -n "${COMMIT_IDS}" ]
        then
                cd "${JPROJECTS_HOME}/${project}"
-               echo "$0: Pulling all for project '${project}' ..."
-               git pull --all
+               echo "$0: Fetching all for project '${project}' ..."
+               git fetch --all
        else
                echo "$0: Nothing to cherry-pick for '${project}'."
                rm "${COMMITS_FILE}"
@@ -35,7 +35,7 @@ for project in ${LIST}; do
        echo "$0: Cherry-picking on project '${project}' ..."
        for commit in ${COMMIT_IDS}; do
                echo "$0: Working on commit '${commit}' ..."
-               FOUND_ID=`git rev-list "${commit}" --max-count=1 2>&1`
+               FOUND_ID=$(git rev-list "${commit}" --max-count=1 2>&1)
                STATUS="$?"
 
                if [ "${STATUS}" != "0" ]
@@ -48,7 +48,7 @@ for project in ${LIST}; do
                git cherry-pick -S "${commit}" || exit 255
 
                echo "$0: Removing commit from list ..."
-               REMAINING_IDS=`cat ${COMMITS_FILE} | grep -v "${commit}"`
+               REMAINING_IDS=$(cat ${COMMITS_FILE} | grep -v "${commit}")
                echo "${REMAINING_IDS}" > ${COMMITS_FILE}
        done