Renaming GeonamesPlugin::NAMESPACE to GeonamesPlugin::LOCATION_NS to avoid parse...

diff --git a/plugins/GeonamesPlugin.php b/plugins/GeonamesPlugin.php
index e18957c36d9dd561cca16fee49fd8d45a1250cf9..1d7381a802d9b5c5182ae5138731a8ac03819a1c 100644 (file)
--- a/plugins/GeonamesPlugin.php
+++ b/plugins/GeonamesPlugin.php
@@ -49,7 +49,7 @@ if (!defined('STATUSNET')) {
 
 class GeonamesPlugin extends Plugin
 {
-    const NAMESPACE = 1;
+    const LOCATION_NS = 1;
 
     /**
      * convert a name into a Location object
@@ -85,7 +85,7 @@ class GeonamesPlugin extends Plugin
                 $location->lon              = $n->lng;
                 $location->names[$language] = $n->name;
                 $location->location_id      = $n->geonameId;
-                $location->location_ns      = self::NAMESPACE;
+                $location->location_ns      = self::LOCATION_NS;
 
                 // handled, don't continue processing!
                 return false;
@@ -109,7 +109,7 @@ class GeonamesPlugin extends Plugin
 
     function onLocationFromId($id, $ns, $language, &$location)
     {
-        if ($ns != self::NAMESPACE) {
+        if ($ns != self::LOCATION_NS) {
             // It's not one of our IDs... keep processing
             return true;
         }
@@ -144,7 +144,7 @@ class GeonamesPlugin extends Plugin
                 $location = new Location();
 
                 $location->location_id      = $last->geonameId;
-                $location->location_ns      = self::NAMESPACE;
+                $location->location_ns      = self::LOCATION_NS;
                 $location->lat              = $last->lat;
                 $location->lon              = $last->lng;
                 $location->names[$language] = implode(', ', array_reverse($parts));
@@ -205,7 +205,7 @@ class GeonamesPlugin extends Plugin
                 }
 
                 $location->location_id = $n->geonameId;
-                $location->location_ns = self::NAMESPACE;
+                $location->location_ns = self::LOCATION_NS;
                 $location->lat         = $lat;
                 $location->lon         = $lon;
 
@@ -237,7 +237,7 @@ class GeonamesPlugin extends Plugin
 
     function onLocationNameLanguage($location, $language, &$name)
     {
-        if ($location->location_ns != self::NAMESPACE) {
+        if ($location->location_ns != self::LOCATION_NS) {
             // It's not one of our IDs... keep processing
             return true;
         }
@@ -292,7 +292,7 @@ class GeonamesPlugin extends Plugin
 
     function onLocationUrl($location, &$url)
     {
-        if ($location->location_ns != self::NAMESPACE) {
+        if ($location->location_ns != self::LOCATION_NS) {
             // It's not one of our IDs... keep processing
             return true;
         }

diff --git a/tests/LocationTest.php b/tests/LocationTest.php
index 62849eb9f4a2a9ed9535dc7a85ff8e3abbfe4728..1badecb5db4de7152731bc4bff2e172df6c61264 100644 (file)
--- a/tests/LocationTest.php
+++ b/tests/LocationTest.php
@@ -48,8 +48,8 @@ class LocationTest extends PHPUnit_Framework_TestCase
 
     static public function locationIds()
     {
-        return array(array(6077243, GeonamesPlugin::NAMESPACE, 'en', null),
-                     array(5391959, GeonamesPlugin::NAMESPACE, 'en', null));
+        return array(array(6077243, GeonamesPlugin::LOCATION_NS, 'en', null),
+                     array(5391959, GeonamesPlugin::LOCATION_NS, 'en', null));
     }
 
     /**