File-related functions not declared static

diff --git a/classes/File_redirection.php b/classes/File_redirection.php
index ea9db8e89154912a27fdb31f191811a2196a7716..ba516e462325698847294a89cf965bb7f395b214 100644 (file)
--- a/classes/File_redirection.php
+++ b/classes/File_redirection.php
@@ -94,7 +94,7 @@ class File_redirection extends Managed_DataObject
      *                size (optional): byte size from Content-Length header
      *                time (optional): timestamp from Last-Modified header
      */
-    public function lookupWhere($short_url, $redirs = 10, $protected = false) {
+    static function lookupWhere($short_url, $redirs = 10, $protected = false) {
         if ($redirs < 0) return false;
 
         if(strpos($short_url,'://') === false){
@@ -249,7 +249,7 @@ class File_redirection extends Managed_DataObject
         }
     }
 
-    function _userMakeShort($long_url, User $user=null, $force = false) {
+    static function _userMakeShort($long_url, User $user=null, $force = false) {
         $short_url = common_shorten_url($long_url, $user, $force);
         if (!empty($short_url) && $short_url != $long_url) {
             $short_url = (string)$short_url;
@@ -304,7 +304,7 @@ class File_redirection extends Managed_DataObject
      * @param string $default_scheme if given a bare link; defaults to 'http://'
      * @return string
      */
-    function _canonUrl($in_url, $default_scheme = 'http://') {
+    static function _canonUrl($in_url, $default_scheme = 'http://') {
         if (empty($in_url)) return false;
         $out_url = $in_url;
         $p = parse_url($out_url);
@@ -342,7 +342,7 @@ class File_redirection extends Managed_DataObject
         return $out_url;
     }
 
-    function saveNew($data, $file_id, $url) {
+    static function saveNew($data, $file_id, $url) {
         $file_redir = new File_redirection;
         $file_redir->urlhash = File::hashurl($short_url);
         $file_redir->url = $url;

diff --git a/classes/File_to_post.php b/classes/File_to_post.php
index e06e34aa46fae2df132cb15454116a3b50377f0c..bf201756f493b8630a4a7f702bad96451f4339fe 100644 (file)
--- a/classes/File_to_post.php
+++ b/classes/File_to_post.php
@@ -56,7 +56,7 @@ class File_to_post extends Managed_DataObject
         );
     }
 
-    function processNew(File $file, Notice $notice) {
+    static function processNew(File $file, Notice $notice) {
         static $seen = array();
 
         $file_id = $file->getID();

diff --git a/plugins/Oembed/classes/File_oembed.php b/plugins/Oembed/classes/File_oembed.php
index 3fc655e1705dbd0dca2c9cf4d2a6851e257a18ff..0e84c6dca8376401f26dab4b476fce245a5f3a2c 100644 (file)
--- a/plugins/Oembed/classes/File_oembed.php
+++ b/plugins/Oembed/classes/File_oembed.php
@@ -67,7 +67,7 @@ class File_oembed extends Managed_DataObject
         );
     }
 
-    function _getOembed($url) {
+    static function _getOembed($url) {
         $parameters = array(
             'maxwidth' => common_config('thumbnail', 'width'),
             'maxheight' => common_config('thumbnail', 'height'),