use a static rather than a constant for code chars

darcs-hash:20080622163458-34904-1be378ff9765dcfdf491ea8d38ef6c157ebe99ce.gz

diff --git a/lib/util.php b/lib/util.php
index 18043e867083cd44aab31b199461da433439136c..d990b8e1f0970973ae2db300d6852ea48293603a 100644 (file)
--- a/lib/util.php
+++ b/lib/util.php
@@ -930,15 +930,15 @@ function common_notice_uri(&$notice) {
 
 # 36 alphanums - lookalikes (0, O, 1, I) = 32 chars = 5 bits
 
-define('CODECHARS', '23456789ABCDEFGHJKLMNPQRSTUVWXYZ');
-
 function common_confirmation_code($bits) {
+       # 36 alphanums - lookalikes (0, O, 1, I) = 32 chars = 5 bits
+       static $codechars = '23456789ABCDEFGHJKLMNPQRSTUVWXYZ';
        $chars = ceil($bits/5);
        $code = '';
        for ($i = 0; $i < $chars; $i++) {
                # XXX: convert to string and back
                $num = hexdec(common_good_rand(1));
-               $code .= CODECHARS[$num%32];
+               $code .= $codechars[$num%32];
        }
        return $code;
 }