]> git.mxchange.org Git - quix0rs-gnu-social.git/commitdiff
Correct a logic-inverting typo in handling of replies to group-posts.
authorJoshua Judson Rosen <rozzin@geekspace.com>
Sun, 29 Jul 2012 21:54:48 +0000 (17:54 -0400)
committerMikael Nordfeldth <mmn@hethane.se>
Sun, 29 Sep 2013 21:14:00 +0000 (23:14 +0200)
The typo causes a tautology, which makes replies to group-posts always (or almost-always) go to the group(s).
cf. http://status.net/open-source/issues/3638

classes/Notice.php

index 1aba98b7bc8aca41d067e52ce55d9ba4e1a228e2..f6b9587c8744b7ef6b2b1e2dcd7b6e11a421a8bf 100644 (file)
@@ -463,7 +463,7 @@ class Notice extends Managed_DataObject
                 // If the original is private to a group, and notice has no group specified,
                 // make it to the same group(s)
 
-                if (empty($groups) && ($reply->scope | Notice::GROUP_SCOPE)) {
+                if (empty($groups) && ($reply->scope & Notice::GROUP_SCOPE)) {
                     $groups = array();
                     $replyGroups = $reply->getGroups();
                     foreach ($replyGroups as $group) {