$requester_id = Contact::getIdForURL($requester, $owner['uid']);
if (!empty($requester_id)) {
$permissionSets = DI::permissionSet()->selectByContactId($requester_id, $owner['uid']);
- if (!empty($permissionSets)) {
+ if ($permissionSets->getTotalCount() > 0) {
$condition = ['psid' => array_merge($permissionSets->column('id'),
[DI::permissionSet()->selectPublicForUser($owner['uid'])])];
}
continue;
}
+ $result = [];
+
if (!$serverfail) {
$result = self::deliverToInbox($post['command'], 0, $inbox, $owner, $post['receivers'], $post['uri-id']);
$serverfail = $response->isTimeout();
} catch (\Throwable $th) {
Logger::notice('Got exception', ['code' => $th->getCode(), 'message' => $th->getMessage()]);
+ $response = null;
$success = false;
$serverfail = true;
}
$runtime = microtime(true) - $timestamp;
- if (!$success) {
+ if ($success === false) {
// 5xx errors are problems on the server. We don't need to continue delivery then.
if (!$serverfail && ($response->getReturnCode() >= 500) && ($response->getReturnCode() <= 599)) {
$serverfail = true;
if (!DI::config()->get('system', 'decoupled_receiver')) {
return;
}
-
+
$replies = [$item['thr-parent']];
if (!empty($item['parent-uri'])) {
$replies[] = $item['parent-uri'];
if (in_array($activity['reply-to-id'], $activity['children'] ?? [])) {
Logger::notice('reply-to-id is already in the list of children', ['id' => $activity['reply-to-id'], 'children' => $activity['children'], 'depth' => count($activity['children'])]);
return '';
- }
+ }
self::addActivityId($activity['reply-to-id']);
}
$hash = substr($tag['name'], 0, 1);
+ $type = 0;
if ($tag['type'] == 'Mention') {
if (in_array($hash, [Tag::TAG_CHARACTER[Tag::MENTION],
return [];
}
- if (!self::isValidObject($object, $url)) {
+ if (!self::isValidObject($object)) {
return [];
}
return '';
}
- if (empty($curlResult)) {
- return '';
- }
-
$body = $curlResult->getBodyString();
if (!$curlResult->isSuccess() || empty($body)) {
if (in_array($curlResult->getReturnCode(), [403, 404, 406, 410])) {
return null;
}
- if (!self::isValidObject($object, $url)) {
+ if (!self::isValidObject($object)) {
return null;
}
$ldactivity['children'] = $child['children'] ?? [];
$ldactivity['callstack'] = $child['callstack'] ?? [];
// This check is mostly superfluous, since there are similar checks before. This covers the case, when the fetched id doesn't match the url
- if (in_array($activity['id'], $ldactivity['children'])) {
+ if (in_array($activity['id'], $ldactivity['children'])) {
Logger::notice('Fetched id is already in the list of children. It will not be processed.', ['id' => $activity['id'], 'children' => $ldactivity['children'], 'depth' => count($ldactivity['children'])]);
return null;
}
Logger::notice('Fetch replies - start', ['replies' => $url, 'callstack' => $child['callstack'], 'system' => $callstack]);
$fetched = 0;
foreach ($replies as $reply) {
+ $id = '';
+
if (is_array($reply)) {
$ldobject = JsonLD::compact($reply);
$id = JsonLD::fetchElement($ldobject, '@id');
self::transmitPendingEvents($cid, $owner['uid']);
}
- if (empty($contact)) {
- Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
- }
+ Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
+
Logger::notice('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
Queue::remove($activity);
}
*/
public static function acceptFollowUser(array $activity)
{
+ $check_id = false;
+
if (!empty($activity['object_actor'])) {
$uid = User::getIdForURL($activity['object_actor']);
$check_id = false;
{
$entries = DBA::select('inbox-entry', ['id'], ["NOT `trust` AND `wid` IS NULL"], ['order' => ['id' => true]]);
while ($entry = DBA::fetch($entries)) {
- $data = self::reprepareActivityById($entry['id'], false);
+ $data = self::reprepareActivityById($entry['id']);
if ($data['trust']) {
DBA::update('inbox-entry', ['trust' => true], ['id' => $entry['id']]);
}
*/
public static function prepareObjectData(array $activity, int $uid, bool $push, bool &$trust_source, string $original_actor = ''): array
{
- $id = JsonLD::fetchElement($activity, '@id');
- $type = JsonLD::fetchElement($activity, '@type');
- $object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
+ $id = JsonLD::fetchElement($activity, '@id');
+ $type = JsonLD::fetchElement($activity, '@type');
+ $object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
+ $object_type = '';
if (!empty($object_id) && in_array($type, ['as:Create', 'as:Update'])) {
$fetch_id = $object_id;
$id = JsonLD::fetchElement($activity, '@id');
$object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
- if (!empty($published) && !empty($object_id) && in_array($type, ['as:Create', 'as:Update']) && in_array($object_type, self::CONTENT_TYPES)
+ if (!empty($published) && $object_id !== null && in_array($type, ['as:Create', 'as:Update']) && in_array($object_type, self::CONTENT_TYPES)
&& ($push || ($completion != self::COMPLETION_MANUAL)) && DI::contentItem()->isTooOld($published) && !Post::exists(['uri' => $object_id])) {
Logger::debug('Activity is too old. It will not be processed', ['push' => $push, 'completion' => $completion, 'type' => $type, 'object-type' => $object_type, 'published' => $published, 'id' => $id, 'object-id' => $object_id]);
return true;
// Test the provided signatures against the actor and "attributedTo"
if ($trust_source) {
- if (!empty($attributed_to) && !empty($actor)) {
+ if (!empty($attributed_to) && $actor !== null) {
$trust_source = (in_array($actor, $signer) && in_array($attributed_to, $signer));
} else {
$trust_source = in_array($actor, $signer);
}
$parent_followers = '';
+ $parent_profile = [];
+
$parent = Post::selectFirstPost(['parent-author-link'], ['uri' => $reply]);
if (!empty($parent['parent-author-link'])) {
$parent_profile = APContact::getByURL($parent['parent-author-link']);
$exclusive = false;
$mention = false;
$audience = [];
+ $owner = false;
// Check if we should always deliver our stuff via BCC
if (!empty($item['uid'])) {
$owner = User::getOwnerDataById($item['uid']);
- if (!empty($owner)) {
+ if (is_array($owner)) {
$always_bcc = $owner['hide-friends'];
$is_group = ($owner['account-type'] == User::ACCOUNT_TYPE_COMMUNITY);
$type = self::getTypeOfItem($item);
if (!$object_mode) {
- $data = ['@context' => $context ?? ActivityPub::CONTEXT];
+ $data = ['@context' => ActivityPub::CONTEXT];
if ($item['deleted'] && ($item['gravity'] == Item::GRAVITY_ACTIVITY)) {
$type = 'Undo';
$title = $item['title'];
$summary = $item['content-warning'] ?: BBCode::toPlaintext(BBCode::getAbstract($item['body'], Protocol::ACTIVITYPUB));
+ $type = '';
if ($item['event-type'] == 'event') {
$type = 'Event';
use Friendica\Core\Logger;
use Friendica\Core\Protocol;
use Friendica\Core\Worker;
-use Friendica\Database\Database;
use Friendica\Database\DBA;
use Friendica\DI;
use Friendica\Model\Contact;
$top_level = false;
$followup = false;
$public_message = false;
+ $parent = false;
+ $thr_parent = false;
$items = [];
if ($cmd == self::MAIL) {
*/
private static function validPosting(array $msg)
{
- $data = XML::parseString($msg['message']);
+ $element = XML::parseString($msg['message']);
- if (!is_object($data)) {
+ if (!is_object($element)) {
Logger::info('No valid XML', ['message' => $msg['message']]);
return false;
}
+ $oldXML = false;
+
// Is this the new or the old version?
- if ($data->getName() == 'XML') {
+ if ($element->getName() === 'XML') {
$oldXML = true;
- foreach ($data->post->children() as $child) {
+ foreach ($element->post->children() as $child) {
$element = $child;
}
- } else {
- $oldXML = false;
- $element = $data;
}
$type = $element->getName();
*/
foreach ($matches as $match) {
- if (empty($match)) {
+ if ($match === '') {
continue;
}
// The "addr" field should always be filled.
// If this isn't the case, it will raise a notice some lines later.
// And in the log we will see where it came from, and we can handle it there.
- Logger::notice('Empty addr', ['contact' => $contact ?? []]);
+ Logger::notice('Empty addr', ['contact' => $contact]);
}
$envelope = self::buildMessage($msg, $owner, $contact, $owner['uprvkey'], $pubkey ?? '', $public_batch);
*/
public static function sendFollowup(array $item, array $owner, array $contact, bool $public_batch = false): int
{
+ $type = '';
+
if (in_array($item['verb'], [Activity::ATTEND, Activity::ATTENDNO, Activity::ATTENDMAYBE])) {
$message = self::constructAttend($item, $owner);
$type = 'event_participation';
Logger::info('Feed is too old', ['created' => $item['created'], 'uid' => $item['uid'], 'uri' => $item['uri']]);
continue;
}
-
+
if (!empty($item['plink'])) {
$fetch_further_information = $contact['fetch_further_information'] ?? LocalRelationship::FFI_NONE;
} else {
$publish_at = date(DateTimeFormat::MYSQL, $publish_time);
if (Post\Delayed::add($posting['item']['uri'], $posting['item'], $posting['notify'], Post\Delayed::PREPARED, $publish_at, $posting['taglist'], $posting['attachments'])) {
- DI::pConfig()->set($item['uid'], 'system', 'last_publish', $publish_time);
+ DI::pConfig()->set($posting['item']['uid'], 'system', 'last_publish', $publish_time);
}
}
}
$contact = Contact::getByURL($item['author-link']) ?: $owner;
$contact['nickname'] = $contact['nickname'] ?? $contact['nick'];
- $author = self::addAuthor($doc, $contact, false);
+ $author = self::addAuthor($doc, $contact);
$entry->appendChild($author);
}
} else {
* @param $type
* @param $type_value
*
- * @return string fetched element
+ * @return string|null fetched element
*/
public static function fetchElement($array, $element, $key = '@id', $type = null, $type_value = null)
{
projects / friendica.git / commitdiff