Catch NoHttpResponseException when using HTTPClient

diff --git a/lib/httpclient.php b/lib/httpclient.php
index 5fe0e9f32994301f8713a8140389586282812494..4c7a4a9c6493b3d88f702e6c5508d27a58d2a630 100644 (file)
--- a/lib/httpclient.php
+++ b/lib/httpclient.php
@@ -27,12 +27,7 @@
  * @link      http://status.net/
  */
 
-if (!defined('GNUSOCIAL')) {
-    exit(1);
-}
-
-require_once 'HTTP/Request2.php';
-require_once 'HTTP/Request2/Response.php';
+if (!defined('GNUSOCIAL')) { exit(1); }
 
 /**
  * Useful structure for HTTP responses
@@ -332,7 +327,7 @@ class HTTPClient extends HTTP_Request2
         do {
             try {
                 $response = parent::send();
-            } catch (HTTP_Request2_Exception $e) {
+            } catch (Exception $e) {
                 $this->log(LOG_ERR, $e->getMessage());
                 throw $e;
             }
@@ -355,6 +350,8 @@ class HTTPClient extends HTTP_Request2
                     continue;
                 } catch (HTTP_Request2_Exception $e) {
                     common_log(LOG_ERR, __CLASS__ . ": Invalid $code redirect from $url to $target");
+                } catch (NoHttpResponseException $e) {
+                    common_log(LOG_ERR, __CLASS__ . ": {$e->getMessage()}");
                 }
             } else {
                 $reason = $response->getReasonPhrase();

diff --git a/plugins/Diaspora/DiasporaPlugin.php b/plugins/Diaspora/DiasporaPlugin.php
index 376ad098b20dbfda085730646765f84e2b7d7aa6..e80153e7adf918c8f7757631f5999aaf8ef8fb10 100644 (file)
--- a/plugins/Diaspora/DiasporaPlugin.php
+++ b/plugins/Diaspora/DiasporaPlugin.php
@@ -240,7 +240,7 @@ class DiasporaPlugin extends Plugin
             $client = new HTTPClient();
             $client->setBody('xml=' . Magicsig::base64_url_encode($envxml));
             $response = $client->post($endpoint_uri, $headers);
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (Exception $e) {
             common_log(LOG_ERR, "Diaspora-flavoured Salmon post to $endpoint_uri failed: " . $e->getMessage());
             return false;
         }

diff --git a/plugins/GeoURL/GeoURLPlugin.php b/plugins/GeoURL/GeoURLPlugin.php
index 0e779a4fe8b33ade89ab1619013cba7e837ed7c6..a64ac7f4fd9625702b4dd5d1533d8863a63f548f 100644 (file)
--- a/plugins/GeoURL/GeoURLPlugin.php
+++ b/plugins/GeoURL/GeoURLPlugin.php
@@ -107,7 +107,7 @@ class GeoURLPlugin extends Plugin
                 $request->post($this->ping,
                                null,
                                array('p' => $url));
-            } catch (HTTP_Request2_Exception $e) {
+            } catch (Exception $e) {
                 common_log(LOG_WARNING,
                            "GeoURL.org ping failed for '$url' ($this->ping)");
             }

diff --git a/plugins/Linkback/LinkbackPlugin.php b/plugins/Linkback/LinkbackPlugin.php
index 941e7c4c4b9241705c02dbddefb3e35586973bfe..dbc88188439e9be3a73eade4f7215867dd727c74 100644 (file)
--- a/plugins/Linkback/LinkbackPlugin.php
+++ b/plugins/Linkback/LinkbackPlugin.php
@@ -182,9 +182,8 @@ class LinkbackPlugin extends Plugin
                 common_log(LOG_WARNING,
                            "Webmention request failed for '$url' ($endpoint)");
             }
-        } catch (HTTP_Request2_Exception $e) {
-            common_log(LOG_WARNING,
-                       "Webmention request failed for '$url' ($endpoint)");
+        } catch (Exception $e) {
+            common_log(LOG_WARNING, "Webmention request failed for '{$url}' ({$endpoint}): {$e->getMessage()}");
         }
     }
 
@@ -224,9 +223,8 @@ class LinkbackPlugin extends Plugin
                        "Pingback success for '$url' ($endpoint): ".
                        "'$response'");
             }
-        } catch (HTTP_Request2_Exception $e) {
-            common_log(LOG_WARNING,
-                   "Pingback request failed for '$url' ($endpoint)");
+        } catch (Exception $e) {
+            common_log(LOG_WARNING, "Pingback request failed for '{$url}' ({$endpoint}): {$e->getMessage()}");
         }
     }
 

diff --git a/plugins/OStatus/OStatusPlugin.php b/plugins/OStatus/OStatusPlugin.php
index 7c509f06418900d30bc9059ac15080f2f73e7c75..af458fb40cc69a79973e1a4049abaa85a8d023e3 100644 (file)
--- a/plugins/OStatus/OStatusPlugin.php
+++ b/plugins/OStatus/OStatusPlugin.php
@@ -1404,7 +1404,7 @@ class OStatusPlugin extends Plugin
             $client = new HTTPClient();
             $client->setBody($envxml);
             $response = $client->post($endpoint_uri, $headers);
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (Exception $e) {
             common_log(LOG_ERR, "Salmon post to $endpoint_uri failed: " . $e->getMessage());
             return false;
         }

diff --git a/plugins/OStatus/lib/feeddiscovery.php b/plugins/OStatus/lib/feeddiscovery.php
index 84933e196b45cce578bf800732b46d05da9d5807..02c3ce02122940ebe91a7e2847f287f4962438bf 100644 (file)
--- a/plugins/OStatus/lib/feeddiscovery.php
+++ b/plugins/OStatus/lib/feeddiscovery.php
@@ -118,7 +118,7 @@ class FeedDiscovery
         try {
             $client = new HTTPClient();
             $response = $client->get($url);
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (Exception $e) {
             common_log(LOG_ERR, __METHOD__ . " Failure for $url - " . $e->getMessage());
             throw new FeedSubBadURLException($e->getMessage());
         }

diff --git a/plugins/RSSCloud/lib/rsscloudnotifier.php b/plugins/RSSCloud/lib/rsscloudnotifier.php
index 6efe419770c657fbf0d9f1ce741d8d44cf57bbfc..21d9597302ab4b821beeb7b89f04f2c0fffe944b 100644 (file)
--- a/plugins/RSSCloud/lib/rsscloudnotifier.php
+++ b/plugins/RSSCloud/lib/rsscloudnotifier.php
@@ -63,7 +63,7 @@ class RSSCloudNotifier
         try {
             $client   = new HTTPClient();
             $response = $client->get($url);
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (Exception $e) {
             common_log(LOG_INFO,
                        'RSSCloud plugin - failure testing notify handler ' .
                        $endpoint . ' - '  . $e->getMessage());
@@ -118,7 +118,7 @@ class RSSCloudNotifier
         try {
             $client   = new HTTPClient();
             $response = $client->post($endpoint, $headers, $postdata);
-        } catch (HTTP_Request2_Exception $e) {
+        } catch (Exception $e) {
             common_log(LOG_INFO, 'RSSCloud plugin - failure notifying ' .
                        $endpoint . ' that feed ' . $feed .
                        ' has changed: ' . $e->getMessage());

diff --git a/scripts/importtwitteratom.php b/scripts/importtwitteratom.php
index a29526f27e1726f57f3679dcdab034fbf4350614..1a08dd7488d867d284b7cf5ee0096254340d2550 100755 (executable)
--- a/scripts/importtwitteratom.php
+++ b/scripts/importtwitteratom.php
@@ -108,7 +108,7 @@ function getTweetHtml($url)
     try {
         $client = new HTTPClient();
         $response = $client->get($url);
-    } catch (HTTP_Request2_Exception $e) {
+    } catch (Exception $e) {
         print "ERROR: HTTP response " . $e->getMessage() . "\n";
         return false;
     }