Followup to IIS installer tweaks in [9bb48c36]:

* skip 0-byte config files when initializing, go ahead and redirect to installer if no non-0-byte files
* tweak warning on installer.php to let you know if you have a 0-byte config.php that's not writable, as opposed to generally already having a config.php with data in it

diff --git a/lib/installer.php b/lib/installer.php
index 2eff2d85ac04b23f5fb8c8c3ab4a4fb950548050..c046eadea33a4f44407f40a26eb4949a5a647992 100644 (file)
--- a/lib/installer.php
+++ b/lib/installer.php
@@ -85,7 +85,11 @@ abstract class Installer
         $config = INSTALLDIR.'/config.php';
         if (file_exists($config)) {
             if (!is_writable($config) || filesize($config) > 0) {
-                $this->warning('Config file "config.php" already exists.');
+                if (filesize($config) == 0) {
+                    $this->warning('Config file "config.php" already exists and is empty, but is not writable.');
+                } else {
+                    $this->warning('Config file "config.php" already exists.');
+                }
                 $pass = false;
             }
         }

diff --git a/lib/statusnet.php b/lib/statusnet.php
index 7212a4a47d5ebc7db124580ccb110ff7a30ef5f4..7cb831696bc02ac512a69f6190469242227371c4 100644 (file)
--- a/lib/statusnet.php
+++ b/lib/statusnet.php
@@ -336,8 +336,11 @@ class StatusNet
 
         foreach ($config_files as $_config_file) {
             if (@file_exists($_config_file)) {
-                include($_config_file);
-                self::$have_config = true;
+                // Ignore 0-byte config files
+                if (filesize($_config_file) > 0) {
+                    include($_config_file);
+                    self::$have_config = true;
+                }
             }
         }