]> git.mxchange.org Git - friendica.git/commitdiff
Bugfixing legacy loglevel
authorPhilipp Holzer <admin@philipp.info>
Mon, 7 Jan 2019 20:54:40 +0000 (21:54 +0100)
committerHypolite Petovan <hypolite@mrpetovan.com>
Mon, 21 Jan 2019 15:54:41 +0000 (10:54 -0500)
src/Core/Logger.php
src/Util/LoggerFactory.php

index 425ea82dca1d35fe55da8e024c30731f618d3b6b..19e4d28d74aa176ce44d1de4fd344e7844b8939a 100644 (file)
@@ -83,9 +83,7 @@ class Logger extends BaseObject
                        return;
                }
 
-               if (is_int($loglevel)) {
-                       $loglevel = self::mapLegacyConfigDebugLevel($loglevel);
-               }
+               $loglevel = self::mapLegacyConfigDebugLevel((string)$loglevel);
 
                LoggerFactory::addStreamHandler($logger, $logfile, $loglevel);
 
@@ -107,7 +105,7 @@ class Logger extends BaseObject
         * Mapping a legacy level to the PSR-3 compliant levels
         * @see https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md#5-psrlogloglevel
         *
-        * @param int $level the level to be mapped
+        * @param mixed $level the level to be mapped
         *
         * @return string the PSR-3 compliant level
         */
@@ -115,26 +113,26 @@ class Logger extends BaseObject
        {
                switch ($level) {
                        // legacy WARNING
-                       case 0:
+                       case "0":
                                return LogLevel::ERROR;
                        // legacy INFO
-                       case 1:
+                       case "1":
                                return LogLevel::WARNING;
                        // legacy TRACE
-                       case 2:
+                       case "2":
                                return LogLevel::NOTICE;
                        // legacy DEBUG
-                       case 3:
+                       case "3":
                                return LogLevel::INFO;
                        // legacy DATA
-                       case 4:
+                       case "4":
                                return LogLevel::DEBUG;
                        // legacy ALL
-                       case 5:
+                       case "5":
                                return LogLevel::DEBUG;
                        // default if nothing set
                        default:
-                               return LogLevel::NOTICE;
+                               return $level;
                }
        }
 
index 71239edbb3a6622e6784cd702f6a581dff35bba5..1e7bdcd1603af34a2d8611da53197abdae2cb0ca 100644 (file)
@@ -75,7 +75,13 @@ class LoggerFactory
        public static function addStreamHandler($logger, $stream, $level = LogLevel::NOTICE)
        {
                if ($logger instanceof Monolog\Logger) {
-                       $fileHandler = new Monolog\Handler\StreamHandler($stream, Monolog\Logger::toMonologLevel($level));
+                       $loglevel = Monolog\Logger::toMonologLevel($level);
+
+                       // fallback to notice if an invalid loglevel is set
+                       if (!is_int($loglevel)) {
+                               $loglevel = LogLevel::NOTICE;
+                       }
+                       $fileHandler = new Monolog\Handler\StreamHandler($stream, $loglevel);
 
                        $formatter = new Monolog\Formatter\LineFormatter("%datetime% %channel% [%level_name%]: %message% %context% %extra%\n");
                        $fileHandler->setFormatter($formatter);