Define reasonable min and max values

diff --git a/src/Module/Api/GNUSocial/Statusnet/Conversation.php b/src/Module/Api/GNUSocial/Statusnet/Conversation.php
index 77fdc034baaa5483b25286b85e205fac5fa14a0c..5edcc4099dbf4d4bb93bbfe6de7f4aa6f28638a9 100644 (file)
--- a/src/Module/Api/GNUSocial/Statusnet/Conversation.php
+++ b/src/Module/Api/GNUSocial/Statusnet/Conversation.php
@@ -41,10 +41,10 @@ class Conversation extends BaseApi
 
                // params
                $id       = $this->parameters['id'] ?? 0;
-               $since_id = $this->getRequestValue($request, 'since_id', 0);
-               $max_id   = $this->getRequestValue($request, 'max_id', 0);
-               $count    = $this->getRequestValue($request, 'count', 20);
-               $page     = $this->getRequestValue($request, 'page', 1);
+               $since_id = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id   = $this->getRequestValue($request, 'max_id', 0, 0);
+               $count    = $this->getRequestValue($request, 'count', 20, 1, 100);
+               $page     = $this->getRequestValue($request, 'page', 1, 1);
 
                $start = max(0, ($page - 1) * $count);
 

diff --git a/src/Module/Api/Twitter/DirectMessagesEndpoint.php b/src/Module/Api/Twitter/DirectMessagesEndpoint.php
index a1f519975c1452fba04f2bf918172da907ec2e1a..c0c271dd765dd56d0abc4883ed991c765633e45f 100644 (file)
--- a/src/Module/Api/Twitter/DirectMessagesEndpoint.php
+++ b/src/Module/Api/Twitter/DirectMessagesEndpoint.php
@@ -60,9 +60,9 @@ abstract class DirectMessagesEndpoint extends BaseApi
                // params
                $count    = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page     = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id   = $this->getRequestValue($request, 'max_id', 0, 1);
-               $min_id   = $this->getRequestValue($request, 'min_id', 0, 1);
+               $since_id = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id   = $this->getRequestValue($request, 'max_id', 0, 0);
+               $min_id   = $this->getRequestValue($request, 'min_id', 0, 0);
                $verbose  = $this->getRequestValue($request, 'friendica_verbose', false);
 
                // pagination

diff --git a/src/Module/Api/Twitter/Favorites.php b/src/Module/Api/Twitter/Favorites.php
index 56aa26cda7170f452b17d4f763ce1568e569e53a..e88922af7d18d5dac523cf9661f5ec736149bad9 100644 (file)
--- a/src/Module/Api/Twitter/Favorites.php
+++ b/src/Module/Api/Twitter/Favorites.php
@@ -47,8 +47,8 @@ class Favorites extends BaseApi
                // params
                $count    = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page     = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id   = $this->getRequestValue($request, 'max_id', 0, 1);
+               $since_id = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id   = $this->getRequestValue($request, 'max_id', 0, 0);
 
                $start = max(0, ($page - 1) * $count);
 

diff --git a/src/Module/Api/Twitter/Lists/Statuses.php b/src/Module/Api/Twitter/Lists/Statuses.php
index 268ad81941f28db70c9abb35b1e63d56c49c7fff..87cb1b4ebd38bac92c67a417dc15e4a7152bd987 100644 (file)
--- a/src/Module/Api/Twitter/Lists/Statuses.php
+++ b/src/Module/Api/Twitter/Lists/Statuses.php
@@ -65,12 +65,12 @@ class Statuses extends BaseApi
                }
 
                // params
-               $count           = $this->getRequestValue($request, 'count', 20);
-               $page            = $this->getRequestValue($request, 'page', 1);
-               $since_id        = $this->getRequestValue($request, 'since_id', 0);
-               $max_id          = $this->getRequestValue($request, 'max_id', 0);
+               $count           = $this->getRequestValue($request, 'count', 20, 1, 100);
+               $page            = $this->getRequestValue($request, 'page', 1, 1);
+               $since_id        = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id          = $this->getRequestValue($request, 'max_id', 0, 0);
                $exclude_replies = $this->getRequestValue($request, 'exclude_replies', false);
-               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0);
+               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0, 0);
 
                $start = max(0, ($page - 1) * $count);
 

diff --git a/src/Module/Api/Twitter/Statuses/HomeTimeline.php b/src/Module/Api/Twitter/Statuses/HomeTimeline.php
index c45342a52336bd279bd90586a1c10fca5f49e9c1..41ce9b37e114a72b6922232afbda4326e3923454 100644 (file)
--- a/src/Module/Api/Twitter/Statuses/HomeTimeline.php
+++ b/src/Module/Api/Twitter/Statuses/HomeTimeline.php
@@ -45,10 +45,10 @@ class HomeTimeline extends BaseApi
                // params
                $count           = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page            = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id        = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id          = $this->getRequestValue($request, 'max_id', 0, 1);
+               $since_id        = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id          = $this->getRequestValue($request, 'max_id', 0, 0);
                $exclude_replies = $this->getRequestValue($request, 'exclude_replies', false);
-               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0);
+               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0, 0);
 
                $start = max(0, ($page - 1) * $count);
 

diff --git a/src/Module/Api/Twitter/Statuses/Mentions.php b/src/Module/Api/Twitter/Statuses/Mentions.php
index 954aca57b4c3cec7a417c03e8dd94834f7f46223..0ddabd9a4a7fc9b0909e852a0a32b05f865094b1 100644 (file)
--- a/src/Module/Api/Twitter/Statuses/Mentions.php
+++ b/src/Module/Api/Twitter/Statuses/Mentions.php
@@ -44,8 +44,8 @@ class Mentions extends BaseApi
                // params
                $count    = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page     = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id   = $this->getRequestValue($request, 'max_id', 0, 1);
+               $since_id = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id   = $this->getRequestValue($request, 'max_id', 0, 0);
 
                $start = max(0, ($page - 1) * $count);
 

diff --git a/src/Module/Api/Twitter/Statuses/PublicTimeline.php b/src/Module/Api/Twitter/Statuses/PublicTimeline.php
index 53950573beeac57bb2a39b8c389ce551d1c58a1e..2a71bfe965aa68bca4ca8144ee2cbcc54b65dab2 100644 (file)
--- a/src/Module/Api/Twitter/Statuses/PublicTimeline.php
+++ b/src/Module/Api/Twitter/Statuses/PublicTimeline.php
@@ -43,10 +43,10 @@ class PublicTimeline extends BaseApi
                // params
                $count           = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page            = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id        = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id          = $this->getRequestValue($request, 'max_id', 0, 1);
+               $since_id        = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id          = $this->getRequestValue($request, 'max_id', 0, 0);
                $exclude_replies = $this->getRequestValue($request, 'exclude_replies', false);
-               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0);
+               $conversation_id = $this->getRequestValue($request, 'conversation_id', 0, 0);
 
                $start = max(0, ($page - 1) * $count);