Fixes for E_NOTICE in mod/item.php (#5393)

* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
  the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).

Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.

Signed-off-by: Roland Häder <roland@mxchange.org>

diff --git a/mod/item.php b/mod/item.php
index dbe396e901d9ccf19ca2735971bd9e90a2fc81f0..d075d611a4ab3710fe1b04ecbb95ebe37a69844e 100644 (file)
--- a/mod/item.php
+++ b/mod/item.php
@@ -158,29 +158,32 @@ function item_post(App $a) {
        // Now check that valid personal details have been provided
        if (!can_write_wall($profile_uid) && !$allow_comment) {
                notice(L10n::t('Permission denied.') . EOL) ;
+
                if (x($_REQUEST, 'return')) {
                        goaway($return_path);
                }
+
                killme();
        }
 
-
-       // is this an edited post?
-
+       // Init post instance
        $orig_post = null;
 
-       if ($post_id) {
+       // is this an edited post?
+       if ($post_id > 0) {
                $orig_post = Item::selectFirst(Item::ITEM_FIELDLIST, ['id' => $post_id]);
        }
 
        $user = dba::selectFirst('user', [], ['uid' => $profile_uid]);
+
        if (!DBM::is_result($user) && !$parent) {
                return;
        }
 
        $categories = '';
+       $postopts = '';
 
-       if ($orig_post) {
+       if (!empty($orig_post)) {
                $str_group_allow   = $orig_post['allow_gid'];
                $str_contact_allow = $orig_post['allow_cid'];
                $str_group_deny    = $orig_post['deny_gid'];

diff --git a/src/Model/Item.php b/src/Model/Item.php
index d6635407dc75498412f59c651cda1b70d464fe77..0e01ff7b96b5f65fea46e451b1971470f8095464 100644 (file)
--- a/src/Model/Item.php
+++ b/src/Model/Item.php
@@ -72,7 +72,7 @@ class Item extends BaseObject
                        'title', 'content-warning', 'body', 'location', 'coord', 'app',
                        'rendered-hash', 'rendered-html', 'object-type', 'object', 'target-type', 'target',
                        'author-id', 'author-link', 'author-name', 'author-avatar',
-                       'owner-id', 'owner-link', 'owner-name', 'owner-avatar'];
+                       'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'emailcc'];
 
        // Never reorder or remove entries from this list. Just add new ones at the end, if needed.
        // The item-activity table only stores the index and needs this array to know the matching activity.