Remove get() from config transaction interface

diff --git a/src/Core/Config/Capability/ISetConfigValuesTransactionally.php b/src/Core/Config/Capability/ISetConfigValuesTransactionally.php
index ae193f2ce2b1db152a9c0ace069746be61563a69..501e24f738a4d6d350a3b7612b05db53c9a4a914 100644 (file)
--- a/src/Core/Config/Capability/ISetConfigValuesTransactionally.php
+++ b/src/Core/Config/Capability/ISetConfigValuesTransactionally.php
@@ -29,22 +29,6 @@ use Friendica\Core\Config\Exception\ConfigPersistenceException;
  */
 interface ISetConfigValuesTransactionally
 {
-       /**
-        * Get a particular user's config variable given the category name
-        * ($cat) and a $key.
-        *
-        * Get a particular config value from the given category ($cat)
-        *
-        * @param string  $cat        The category of the configuration value
-        * @param string  $key           The configuration key to query
-        *
-        * @return mixed Stored value or null if it does not exist
-        *
-        * @throws ConfigPersistenceException In case the persistence layer throws errors
-        *
-        */
-       public function get(string $cat, string $key);
-
        /**
         * Sets a configuration value for system config
         *

diff --git a/src/Core/Config/Model/ConfigTransaction.php b/src/Core/Config/Model/ConfigTransaction.php
index 7ec5784ad2fb6c9cecb77bf6b7ea5e42d40b2863..d8c7d7d43e81a3ba5c71ff1e4c0439d5b8224f37 100644 (file)
--- a/src/Core/Config/Model/ConfigTransaction.php
+++ b/src/Core/Config/Model/ConfigTransaction.php
@@ -45,8 +45,20 @@ class ConfigTransaction implements ISetConfigValuesTransactionally
                $this->delCache = new Cache();
        }
 
-       /** {@inheritDoc} */
-       public function get(string $cat, string $key)
+       /**
+        * Get a particular user's config variable given the category name
+        * ($cat) and a $key from the current transaction.
+        *
+        * Isn't part of the interface because of it's rare use case
+        *
+        * @param string  $cat        The category of the configuration value
+        * @param string  $key           The configuration key to query
+        *
+        * @return mixed Stored value or null if it does not exist
+        *
+        * @throws ConfigPersistenceException In case the persistence layer throws errors
+        *
+        */     public function get(string $cat, string $key)
        {
                return !$this->delCache->get($cat, $key) ?
                        ($this->cache->get($cat, $key) ?? $this->config->get($cat, $key)) :