Don't send favorite notifications unless the user wants it.

diff --git a/plugins/Favorite/FavoritePlugin.php b/plugins/Favorite/FavoritePlugin.php
index 0dcd78202e2f4b12b7ef2ac591635801ab5b6ac4..144fef77978173c896d17dd5cbe70f10be752e85 100644 (file)
--- a/plugins/Favorite/FavoritePlugin.php
+++ b/plugins/Favorite/FavoritePlugin.php
@@ -197,7 +197,8 @@ class FavoritePlugin extends ActivityHandlerPlugin
 
         foreach ($mentioned_ids as $id) {
             $mentioned = User::getKV('id', $id);
-            if ($mentioned instanceof User && $mentioned->id != $stored->profile_id) {
+            if ($mentioned instanceof User && $mentioned->id != $stored->profile_id
+                    && $mentioned->email && $mentioned->emailnotifyfav) {   // do we have an email, and does user want it?
                 mail_notify_fave($mentioned, $stored->getProfile(), $stored->getParent());
             }
         }