]> git.mxchange.org Git - addressbook-ejb.git/commitdiff
Please cherry-pick:
authorRoland Häder <roland@mxchange.org>
Sat, 25 Jun 2022 13:08:07 +0000 (15:08 +0200)
committerRoland Häder <roland@mxchange.org>
Sat, 25 Jun 2022 13:29:15 +0000 (15:29 +0200)
- private methods should not have exceptions thrown because these cases cannot
  be unit-tested (or very hard)
- normally only public, package-level or protected methods throw exceptions
  and have made sure that e.g. null-references won't get through to private
  methods

Signed-off-by: Roland Häder <roland@mxchange.org>
src/java/org/mxchange/jcountry/model/data/AddressbookAdminCountrySingletonBean.java

index 0cfce0ff736cbb0c10910f1b62522a3497c5e169..249307badf0ecc5835796f4fa13e15087dd5704e 100644 (file)
@@ -102,20 +102,6 @@ public class AddressbookAdminCountrySingletonBean extends BaseAddressbookEnterpr
         * @return Whether the country was found
         */
        private boolean isCountryAdded (final Country country) {
-               if (null == country) {
-                       // Throw NPE
-                       throw new NullPointerException("country is null"); //NOI18N
-               } else if (country.getCountryCode().isEmpty()) {
-                       // Code is not set
-                       throw new IllegalArgumentException("country.countryCode is empty"); //NOI18N
-               } else if (country.getCountryI18nKey().isEmpty()) {
-                       // I18n key is not set
-                       throw new IllegalArgumentException("country.countryI18nKey is empty"); //NOI18N
-               } else if (country.getCountryId() != null) {
-                       // Should be null
-                       throw new IllegalArgumentException(MessageFormat.format("country.countryId is not null ({0})", country.getCountryId())); //NOI18N
-               }
-
                // Default is not found
                boolean isAdded = false;