Fix many clang errors in UIUC code

- because uiuc_warning_error always called exit(-1), it can be marked
  no return, so Clang realises that when it’s used in the ‘else’
  side of a parsing test, uninitialised variables in the enclosing
  call site are safe.

(Requires Simgear update to define SG_NO_RETURN helper)

diff --git a/src/FDM/UIUCModel/uiuc_warnings_errors.cpp b/src/FDM/UIUCModel/uiuc_warnings_errors.cpp
index 50866ad1450fcdb101aed5af2f0916ea3a511085..b8213363e974a79bb85466df777580dd067e84b4 100644 (file)
--- a/src/FDM/UIUCModel/uiuc_warnings_errors.cpp
+++ b/src/FDM/UIUCModel/uiuc_warnings_errors.cpp
@@ -118,6 +118,9 @@ void uiuc_warnings_errors(int errorCode, std::string line)
       exit(-1);
       break;
     }
+
+    cerr << "UIUC UNKNOWN ERROR" << endl;
+    exit(-1);
 }
 
 // end uiuc_warnings_errors.cpp

diff --git a/src/FDM/UIUCModel/uiuc_warnings_errors.h b/src/FDM/UIUCModel/uiuc_warnings_errors.h
index 62640bb4721d4d8375eab6762c968fcbd83b7b45..ad9aac61b0e74d499fddfe72f5db03af6b31f3c1 100644 (file)
--- a/src/FDM/UIUCModel/uiuc_warnings_errors.h
+++ b/src/FDM/UIUCModel/uiuc_warnings_errors.h
@@ -6,6 +6,6 @@
 #include <string>
 #include <cstdlib>
 
-void uiuc_warnings_errors(int errorCode, std::string line);
+SG_NO_RETURN void uiuc_warnings_errors(int errorCode, std::string line);
 
 #endif  //_WARNINGS_ERRORS_H_