]> git.mxchange.org Git - friendica.git/commitdiff
Remove DiceContainer::fromDice()
authorArt4 <art4@wlabs.de>
Wed, 8 Jan 2025 23:00:38 +0000 (23:00 +0000)
committerArt4 <art4@wlabs.de>
Wed, 8 Jan 2025 23:00:38 +0000 (23:00 +0000)
src/Core/DiceContainer.php
tests/Unit/Core/DiceContainerTest.php

index 7d8b57b14d93505e53773cf0ac1f1a300ddb265b..8e0a95b472b7f7d6deab93a36d9f0c4b98b7f931 100644 (file)
@@ -27,7 +27,7 @@ final class DiceContainer implements Container
 
                $dice = (new Dice())->addRules(require($path));
 
-               return static::fromDice($dice);
+               return new self($dice);
        }
 
        private Dice $container;
@@ -37,18 +37,6 @@ final class DiceContainer implements Container
                $this->container = $container;
        }
 
-       /**
-        * Creates an instance with Dice
-        *
-        * @param Dice $container
-        *
-        * @return self
-        */
-       public static function fromDice(Dice $container): self
-       {
-               return new self($container);
-       }
-
        /**
         * Initialize the container with the given parameters
         *
index d18c551da1da4478b254363d63c900c0814fa310..0b6040029e3acefc2a0c1fb8523dccdef4e894d4 100644 (file)
@@ -50,33 +50,4 @@ class DiceContainerTest extends TestCase
 
                $this->assertInstanceOf(NullLogger::class, $container->create(LoggerInterface::class));
        }
-
-       public function testFromDiceReturnsContainer(): void
-       {
-               $dice = $this->createMock(Dice::class);
-               $dice->expects($this->never())->method('create');
-
-               $container = DiceContainer::fromDice($dice);
-
-               $this->assertInstanceOf(Container::class, $container);
-       }
-
-       public function testCreateFromContainer(): void
-       {
-               $dice = $this->createMock(Dice::class);
-               $dice->expects($this->once())->method('create')->with(LoggerInterface::class)->willReturn(new NullLogger());
-
-               $container = DiceContainer::fromDice($dice);
-
-               $this->assertInstanceOf(NullLogger::class, $container->create(LoggerInterface::class));
-       }
-
-       public function testAddRuleFromContainer(): void
-       {
-               $dice = $this->createMock(Dice::class);
-               $dice->expects($this->once())->method('addRule')->with(LoggerInterface::class, ['constructParams' => ['console']])->willReturn($dice);
-
-               $container = DiceContainer::fromDice($dice);
-               $container->addRule(LoggerInterface::class, ['constructParams' => ['console']]);
-       }
 }