]> git.mxchange.org Git - friendica.git/commitdiff
Shorten "PConfiguration" to "PConfig" again, since the Wrapper is gone
authornupplaPhil <admin@philipp.info>
Sun, 19 Jan 2020 21:23:44 +0000 (22:23 +0100)
committernupplaPhil <admin@philipp.info>
Sun, 19 Jan 2020 21:23:44 +0000 (22:23 +0100)
47 files changed:
index.php
src/App.php
src/App/Authentication.php
src/App/Mode.php
src/App/Page.php
src/Console/AutomaticInstallation.php
src/Console/DatabaseStructure.php
src/Core/BaseConfig.php
src/Core/BasePConfig.php [new file with mode: 0644]
src/Core/Config/Cache.php [new file with mode: 0644]
src/Core/Config/Cache/ConfigCache.php [deleted file]
src/Core/Config/Cache/PConfigCache.php [deleted file]
src/Core/Config/IConfig.php
src/Core/Config/IPConfiguration.php [deleted file]
src/Core/Config/JitConfig.php
src/Core/Config/JitPConfiguration.php [deleted file]
src/Core/Config/PConfiguration.php [deleted file]
src/Core/Config/PreloadConfig.php
src/Core/Config/PreloadPConfiguration.php [deleted file]
src/Core/Installer.php
src/Core/PConfig/Cache.php [new file with mode: 0644]
src/Core/PConfig/IPConfig.php [new file with mode: 0644]
src/Core/PConfig/JitPConfig.php [new file with mode: 0644]
src/Core/PConfig/PreloadPConfig.php [new file with mode: 0644]
src/DI.php
src/Database/Database.php
src/Factory/ConfigFactory.php
src/Model/Notify.php
src/Module/Admin/Summary.php
src/Module/Install.php
src/Util/ConfigFileLoader.php
src/Util/Profiler.php
static/dependencies.config.php
tests/Util/AppMockTrait.php
tests/functional/DependencyCheckTest.php
tests/include/ApiTest.php
tests/src/App/ModeTest.php
tests/src/Console/AutomaticInstallationConsoleTest.php
tests/src/Core/Config/Cache/ConfigCacheTest.php
tests/src/Core/Config/Cache/PConfigCacheTest.php
tests/src/Core/Config/ConfigurationTest.php
tests/src/Core/Config/JitPConfigurationTest.php
tests/src/Core/Config/PConfigurationTest.php
tests/src/Core/Config/PreloadPConfigurationTest.php
tests/src/Core/InstallerTest.php
tests/src/Util/Config/ConfigFileLoaderTest.php
tests/src/Util/ProfilerTest.php

index 1a88a7b283af3dab6cf81c55b91eb7377c7c3a8f..7a6e26b42e02f6fdce75c77d3fbc0e23c79cf322 100644 (file)
--- a/index.php
+++ b/index.php
@@ -22,7 +22,7 @@ $a = \Friendica\DI::app();
 $a->runFrontend(
        $dice->create(\Friendica\App\Module::class),
        $dice->create(\Friendica\App\Router::class),
-       $dice->create(\Friendica\Core\Config\IPConfiguration::class),
+       $dice->create(\Friendica\Core\PConfig\IPConfig::class),
        $dice->create(\Friendica\App\Authentication::class),
        $dice->create(\Friendica\App\Page::class)
 );
index cfe2c1c1b47999a86ab0e2a2f7778ea4b93a5340..ceb11dd797ecdb567691e59208d82343d54626da 100644 (file)
@@ -8,9 +8,9 @@ use Exception;
 use Friendica\App\Arguments;
 use Friendica\App\BaseURL;
 use Friendica\App\Authentication;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Config\IConfig;
-use Friendica\Core\Config\IPConfiguration;
+use Friendica\Core\PConfig\IPConfig;
 use Friendica\Core\L10n;
 use Friendica\Core\System;
 use Friendica\Core\Theme;
@@ -118,14 +118,14 @@ class App
        private $process;
 
        /**
-        * @var IPConfiguration
+        * @var IPConfig
         */
        private $pConfig;
 
        /**
         * Returns the current config cache of this node
         *
-        * @return ConfigCache
+        * @return Cache
         */
        public function getConfigCache()
        {
@@ -153,9 +153,9 @@ class App
         * @param L10n            $l10n     The translator instance
         * @param App\Arguments   $args     The Friendica Arguments of the call
         * @param Core\Process    $process  The process methods
-        * @param IPConfiguration $pConfig  Personal configuration
+        * @param IPConfig        $pConfig  Personal configuration
         */
-       public function __construct(Database $database, IConfig $config, App\Mode $mode, BaseURL $baseURL, LoggerInterface $logger, Profiler $profiler, L10n $l10n, Arguments $args, Core\Process $process, IPConfiguration $pConfig)
+       public function __construct(Database $database, IConfig $config, App\Mode $mode, BaseURL $baseURL, LoggerInterface $logger, Profiler $profiler, L10n $l10n, Arguments $args, Core\Process $process, IPConfig $pConfig)
        {
                $this->database = $database;
                $this->config   = $config;
@@ -432,13 +432,14 @@ class App
         *
         * @param App\Module     $module The determined module
         * @param App\Router     $router
-        * @param IPConfiguration $pconfig
+        * @param IPConfig       $pconfig
         * @param Authentication $auth The Authentication backend of the node
-        * @param App\Page $page The Friendica page printing container
+        * @param App\Page       $page The Friendica page printing container
+        *
         * @throws HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       public function runFrontend(App\Module $module, App\Router $router, IPConfiguration $pconfig, Authentication $auth, App\Page $page)
+       public function runFrontend(App\Module $module, App\Router $router, IPConfig $pconfig, Authentication $auth, App\Page $page)
        {
                $moduleName = $module->getName();
 
index 9dfc6adb15f29bf47ae9b3c331ec3a269d762e1b..c0408a8111e19deeac91bc1207e5cba599675370 100644 (file)
@@ -9,7 +9,7 @@ namespace Friendica\App;
 use Exception;
 use Friendica\App;
 use Friendica\Core\Config\IConfig;
-use Friendica\Core\Config\IPConfiguration;
+use Friendica\Core\PConfig\IPConfig;
 use Friendica\Core\Hook;
 use Friendica\Core\Session;
 use Friendica\Core\System;
@@ -46,7 +46,7 @@ class Authentication
        private $cookie;
        /** @var Session\ISession */
        private $session;
-       /** @var IPConfiguration */
+       /** @var IPConfig */
        private $pConfig;
 
        /**
@@ -60,9 +60,9 @@ class Authentication
         * @param LoggerInterface  $logger
         * @param User\Cookie      $cookie
         * @param Session\ISession $session
-        * @param IPConfiguration  $pConfig
+        * @param IPConfig         $pConfig
         */
-       public function __construct(IConfig $config, App\Mode $mode, App\BaseURL $baseUrl, L10n $l10n, Database $dba, LoggerInterface $logger, User\Cookie $cookie, Session\ISession $session, IPConfiguration $pConfig)
+       public function __construct(IConfig $config, App\Mode $mode, App\BaseURL $baseUrl, L10n $l10n, Database $dba, LoggerInterface $logger, User\Cookie $cookie, Session\ISession $session, IPConfig $pConfig)
        {
                $this->config  = $config;
                $this->mode    = $mode;
index 0a5f98e24f2617d03abc4cbc9ca52d2cb7b80d09..6cef3456b10dc444bc5c8846ec0104abcd26b328 100644 (file)
@@ -3,7 +3,7 @@
 namespace Friendica\App;
 
 use Detection\MobileDetect;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Database\Database;
 use Friendica\Util\BasePath;
 
@@ -65,7 +65,7 @@ class Mode
         *
         * @throws \Exception
         */
-       public function determine(BasePath $basepath, Database $database, ConfigCache $configCache)
+       public function determine(BasePath $basepath, Database $database, Cache $configCache)
        {
                $mode = 0;
 
index 408f803225f95e6da308095d1bd75a5adbec632b..8dd8763465c4309723ad0c5368bab153cead29ee 100644 (file)
@@ -8,7 +8,7 @@ use DOMXPath;
 use Friendica\App;
 use Friendica\Content\Nav;
 use Friendica\Core\Config\IConfig;
-use Friendica\Core\Config\IPConfiguration;
+use Friendica\Core\PConfig\IPConfig;
 use Friendica\Core\Hook;
 use Friendica\Core\L10n;
 use Friendica\Core\Renderer;
@@ -168,15 +168,15 @@ class Page implements ArrayAccess
         * - Infinite scroll data
         * - head.tpl template
         *
-        * @param App             $app     The Friendica App instance
-        * @param Module          $module  The loaded Friendica module
-        * @param L10n            $l10n    The l10n language instance
-        * @param IConfig         $config  The Friendica configuration
-        * @param IPConfiguration $pConfig The Friendica personal configuration (for user)
+        * @param App      $app     The Friendica App instance
+        * @param Module   $module  The loaded Friendica module
+        * @param L10n     $l10n    The l10n language instance
+        * @param IConfig  $config  The Friendica configuration
+        * @param IPConfig $pConfig The Friendica personal configuration (for user)
         *
         * @throws HTTPException\InternalServerErrorException
         */
-       private function initHead(App $app, Module $module, L10n $l10n, IConfig $config, IPConfiguration $pConfig)
+       private function initHead(App $app, Module $module, L10n $l10n, IConfig $config, IPConfig $pConfig)
        {
                $interval = ((local_user()) ? $pConfig->get(local_user(), 'system', 'update_interval') : 40000);
 
@@ -342,17 +342,17 @@ class Page implements ArrayAccess
        /**
         * Executes the creation of the current page and prints it to the screen
         *
-        * @param App             $app     The Friendica App
-        * @param BaseURL         $baseURL The Friendica Base URL
-        * @param Mode            $mode    The current node mode
-        * @param Module          $module  The loaded Friendica module
-        * @param L10n            $l10n    The l10n language class
-        * @param IConfig         $config  The Configuration of this node
-        * @param IPConfiguration $pconfig The personal/user configuration
+        * @param App      $app     The Friendica App
+        * @param BaseURL  $baseURL The Friendica Base URL
+        * @param Mode     $mode    The current node mode
+        * @param Module   $module  The loaded Friendica module
+        * @param L10n     $l10n    The l10n language class
+        * @param IConfig  $config  The Configuration of this node
+        * @param IPConfig $pconfig The personal/user configuration
         *
         * @throws HTTPException\InternalServerErrorException
         */
-       public function run(App $app, BaseURL $baseURL, Mode $mode, Module $module, L10n $l10n, IConfig $config, IPConfiguration $pconfig)
+       public function run(App $app, BaseURL $baseURL, Mode $mode, Module $module, L10n $l10n, IConfig $config, IPConfig $pconfig)
        {
                $moduleName = $module->getName();
 
index 12c3b325ae301796c4feba8b5b3411fbb5f16a1b..f93b50c1e2cf4cb8e2496e2e48e795f628828dc5 100644 (file)
@@ -20,7 +20,7 @@ class AutomaticInstallation extends Console
         */
        private $appMode;
        /**
-        * @var Config\Cache\ConfigCache
+        * @var \Friendica\Core\Config\Cache
         */
        private $configCache;
 
@@ -89,7 +89,7 @@ Examples
 HELP;
        }
 
-       public function __construct(App\Mode $appMode, Config\Cache\ConfigCache $configCache, Config\IConfig $config, Database $dba, array $argv = null)
+       public function __construct(App\Mode $appMode, Config\Cache $configCache, Config\IConfig $config, Database $dba, array $argv = null)
        {
                parent::__construct($argv);
 
@@ -241,13 +241,13 @@ HELP;
        }
 
        /**
-        * @param Installer                 $installer   The Installer instance
-        * @param Config\Cache\ConfigCache $configCache The config cache
+        * @param Installer                    $installer   The Installer instance
+        * @param \Friendica\Core\Config\Cache $configCache The config cache
         *
         * @return bool true if checks were successfully, otherwise false
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       private function runBasicChecks(Installer $installer, Config\Cache\ConfigCache $configCache)
+       private function runBasicChecks(Installer $installer, Config\Cache $configCache)
        {
                $checked = true;
 
index b397c8f50d532ad6a95bc0b64e9c79829ef85f99..d7de1f3d0ca2a1e27c48d0e39aaadcc4b766cf4f 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Console;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Update;
 use Friendica\Database\Database;
 use Friendica\Database\DBStructure;
@@ -22,7 +22,7 @@ class DatabaseStructure extends \Asika\SimpleConsole\Console
         */
        private $dba;
        /**
-        * @var ConfigCache
+        * @var Cache
         */
        private $configCache;
 
@@ -48,7 +48,7 @@ HELP;
                return $help;
        }
 
-       public function __construct(Database $dba, ConfigCache $configCache, $argv = null)
+       public function __construct(Database $dba, Cache $configCache, $argv = null)
        {
                parent::__construct($argv);
 
index b464beed1bbff0aba2abf8acc40ab311169e3fd5..744e5cc49872d88c3f5bee8e95a52948a4181a40 100644 (file)
@@ -15,7 +15,7 @@ use Friendica\Model;
 abstract class BaseConfig implements IConfig
 {
        /**
-        * @var Cache\ConfigCache
+        * @var Cache
         */
        protected $configCache;
 
@@ -25,10 +25,10 @@ abstract class BaseConfig implements IConfig
        protected $configModel;
 
        /**
-        * @param Cache\ConfigCache  $configCache The configuration cache (based on the config-files)
-        * @param Model\Config\Config $configModel The configuration model
+        * @param Cache $configCache The configuration cache (based on the config-files)
+        * @param Model\Config\Config          $configModel The configuration model
         */
-       public function __construct(Cache\ConfigCache $configCache, Model\Config\Config $configModel)
+       public function __construct(Cache $configCache, Model\Config\Config $configModel)
        {
                $this->configCache = $configCache;
                $this->configModel = $configModel;
diff --git a/src/Core/BasePConfig.php b/src/Core/BasePConfig.php
new file mode 100644 (file)
index 0000000..97eca70
--- /dev/null
@@ -0,0 +1,47 @@
+<?php
+
+namespace Friendica\Core;
+
+use Friendica\Core\PConfig\Cache;
+use Friendica\Core\PConfig\IPConfig;
+use Friendica\Model;
+
+/**
+ * This class is responsible for the user-specific configuration values in Friendica
+ * The values are set through the Config-DB-Table (per Config-DB-model @see Model\Config\PConfig)
+ *
+ * The configuration cache (@see Cache\PConfigCache) is used for temporary caching of database calls. This will
+ * increase the performance.
+ */
+abstract class BasePConfig implements IPConfig
+{
+       /**
+        * @var Cache
+        */
+       protected $configCache;
+
+       /**
+        * @var Model\Config\PConfig
+        */
+       protected $configModel;
+
+       /**
+        * @param Cache $configCache The configuration cache
+        * @param Model\Config\PConfig          $configModel The configuration model
+        */
+       public function __construct(Cache $configCache, Model\Config\PConfig $configModel)
+       {
+               $this->configCache = $configCache;
+               $this->configModel = $configModel;
+       }
+
+       /**
+        * Returns the Config Cache
+        *
+        * @return Cache
+        */
+       public function getCache()
+       {
+               return $this->configCache;
+       }
+}
diff --git a/src/Core/Config/Cache.php b/src/Core/Config/Cache.php
new file mode 100644 (file)
index 0000000..a6cb8d9
--- /dev/null
@@ -0,0 +1,179 @@
+<?php
+
+namespace Friendica\Core\Config;
+
+use ParagonIE\HiddenString\HiddenString;
+
+/**
+ * The Friendica config cache for the application
+ * Initial, all *.config.php files are loaded into this cache with the
+ * ConfigFileLoader ( @see ConfigFileLoader )
+ */
+class Cache
+{
+       /**
+        * @var array
+        */
+       private $config;
+
+       /**
+        * @var bool
+        */
+       private $hidePasswordOutput;
+
+       /**
+        * @param array $config             A initial config array
+        * @param bool  $hidePasswordOutput True, if cache variables should take extra care of password values
+        */
+       public function __construct(array $config = [], bool $hidePasswordOutput = true)
+       {
+               $this->hidePasswordOutput = $hidePasswordOutput;
+               $this->load($config);
+       }
+
+       /**
+        * Tries to load the specified configuration array into the config array.
+        * Doesn't overwrite previously set values by default to prevent default config files to supersede DB Config.
+        *
+        * @param array $config
+        * @param bool  $overwrite Force value overwrite if the config key already exists
+        */
+       public function load(array $config, bool $overwrite = false)
+       {
+               $categories = array_keys($config);
+
+               foreach ($categories as $category) {
+                       if (is_array($config[$category])) {
+                               $keys = array_keys($config[$category]);
+
+                               foreach ($keys as $key) {
+                                       $value = $config[$category][$key];
+                                       if (isset($value)) {
+                                               if ($overwrite) {
+                                                       $this->set($category, $key, $value);
+                                               } else {
+                                                       $this->setDefault($category, $key, $value);
+                                               }
+                                       }
+                               }
+                       }
+               }
+       }
+
+       /**
+        * Gets a value from the config cache.
+        *
+        * @param string $cat Config category
+        * @param string $key Config key
+        *
+        * @return null|mixed Returns the value of the Config entry or null if not set
+        */
+       public function get(string $cat, string $key = null)
+       {
+               if (isset($this->config[$cat][$key])) {
+                       return $this->config[$cat][$key];
+               } elseif (!isset($key) && isset($this->config[$cat])) {
+                       return $this->config[$cat];
+               } else {
+                       return null;
+               }
+       }
+
+       /**
+        * Sets a default value in the config cache. Ignores already existing keys.
+        *
+        * @param string $cat   Config category
+        * @param string $key   Config key
+        * @param mixed  $value Default value to set
+        */
+       private function setDefault(string $cat, string $key, $value)
+       {
+               if (!isset($this->config[$cat][$key])) {
+                       $this->set($cat, $key, $value);
+               }
+       }
+
+       /**
+        * Sets a value in the config cache. Accepts raw output from the config table
+        *
+        * @param string $cat   Config category
+        * @param string $key   Config key
+        * @param mixed  $value Value to set
+        *
+        * @return bool True, if the value is set
+        */
+       public function set(string $cat, string $key, $value)
+       {
+               if (!isset($this->config[$cat])) {
+                       $this->config[$cat] = [];
+               }
+
+               if ($this->hidePasswordOutput &&
+                   $key == 'password' &&
+                   is_string($value)) {
+                       $this->config[$cat][$key] = new HiddenString((string)$value);
+               } else {
+                       $this->config[$cat][$key] = $value;
+               }
+               return true;
+       }
+
+       /**
+        * Deletes a value from the config cache.
+        *
+        * @param string $cat Config category
+        * @param string $key Config key
+        *
+        * @return bool true, if deleted
+        */
+       public function delete(string $cat, string $key)
+       {
+               if (isset($this->config[$cat][$key])) {
+                       unset($this->config[$cat][$key]);
+                       if (count($this->config[$cat]) == 0) {
+                               unset($this->config[$cat]);
+                       }
+                       return true;
+               } else {
+                       return false;
+               }
+       }
+
+       /**
+        * Returns the whole configuration
+        *
+        * @return array The configuration
+        */
+       public function getAll()
+       {
+               return $this->config;
+       }
+
+       /**
+        * Returns an array with missing categories/Keys
+        *
+        * @param array $config The array to check
+        *
+        * @return array
+        */
+       public function keyDiff(array $config)
+       {
+               $return = [];
+
+               $categories = array_keys($config);
+
+               foreach ($categories as $category) {
+                       if (is_array($config[$category])) {
+                               $keys = array_keys($config[$category]);
+
+                               foreach ($keys as $key) {
+                                       if (!isset($this->config[$category][$key])) {
+                                               $return[$category][$key] = $config[$category][$key];
+                                       }
+                               }
+                       }
+               }
+
+               return $return;
+       }
+}
diff --git a/src/Core/Config/Cache/ConfigCache.php b/src/Core/Config/Cache/ConfigCache.php
deleted file mode 100644 (file)
index 3119b5d..0000000
+++ /dev/null
@@ -1,179 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config\Cache;
-
-use ParagonIE\HiddenString\HiddenString;
-
-/**
- * The Friendica config cache for the application
- * Initial, all *.config.php files are loaded into this cache with the
- * ConfigFileLoader ( @see ConfigFileLoader )
- */
-class ConfigCache
-{
-       /**
-        * @var array
-        */
-       private $config;
-
-       /**
-        * @var bool
-        */
-       private $hidePasswordOutput;
-
-       /**
-        * @param array $config             A initial config array
-        * @param bool  $hidePasswordOutput True, if cache variables should take extra care of password values
-        */
-       public function __construct(array $config = [], bool $hidePasswordOutput = true)
-       {
-               $this->hidePasswordOutput = $hidePasswordOutput;
-               $this->load($config);
-       }
-
-       /**
-        * Tries to load the specified configuration array into the config array.
-        * Doesn't overwrite previously set values by default to prevent default config files to supersede DB Config.
-        *
-        * @param array $config
-        * @param bool  $overwrite Force value overwrite if the config key already exists
-        */
-       public function load(array $config, bool $overwrite = false)
-       {
-               $categories = array_keys($config);
-
-               foreach ($categories as $category) {
-                       if (is_array($config[$category])) {
-                               $keys = array_keys($config[$category]);
-
-                               foreach ($keys as $key) {
-                                       $value = $config[$category][$key];
-                                       if (isset($value)) {
-                                               if ($overwrite) {
-                                                       $this->set($category, $key, $value);
-                                               } else {
-                                                       $this->setDefault($category, $key, $value);
-                                               }
-                                       }
-                               }
-                       }
-               }
-       }
-
-       /**
-        * Gets a value from the config cache.
-        *
-        * @param string $cat Config category
-        * @param string $key Config key
-        *
-        * @return null|mixed Returns the value of the Config entry or null if not set
-        */
-       public function get(string $cat, string $key = null)
-       {
-               if (isset($this->config[$cat][$key])) {
-                       return $this->config[$cat][$key];
-               } elseif (!isset($key) && isset($this->config[$cat])) {
-                       return $this->config[$cat];
-               } else {
-                       return null;
-               }
-       }
-
-       /**
-        * Sets a default value in the config cache. Ignores already existing keys.
-        *
-        * @param string $cat   Config category
-        * @param string $key   Config key
-        * @param mixed  $value Default value to set
-        */
-       private function setDefault(string $cat, string $key, $value)
-       {
-               if (!isset($this->config[$cat][$key])) {
-                       $this->set($cat, $key, $value);
-               }
-       }
-
-       /**
-        * Sets a value in the config cache. Accepts raw output from the config table
-        *
-        * @param string $cat   Config category
-        * @param string $key   Config key
-        * @param mixed  $value Value to set
-        *
-        * @return bool True, if the value is set
-        */
-       public function set(string $cat, string $key, $value)
-       {
-               if (!isset($this->config[$cat])) {
-                       $this->config[$cat] = [];
-               }
-
-               if ($this->hidePasswordOutput &&
-                   $key == 'password' &&
-                   is_string($value)) {
-                       $this->config[$cat][$key] = new HiddenString((string)$value);
-               } else {
-                       $this->config[$cat][$key] = $value;
-               }
-               return true;
-       }
-
-       /**
-        * Deletes a value from the config cache.
-        *
-        * @param string $cat Config category
-        * @param string $key Config key
-        *
-        * @return bool true, if deleted
-        */
-       public function delete(string $cat, string $key)
-       {
-               if (isset($this->config[$cat][$key])) {
-                       unset($this->config[$cat][$key]);
-                       if (count($this->config[$cat]) == 0) {
-                               unset($this->config[$cat]);
-                       }
-                       return true;
-               } else {
-                       return false;
-               }
-       }
-
-       /**
-        * Returns the whole configuration
-        *
-        * @return array The configuration
-        */
-       public function getAll()
-       {
-               return $this->config;
-       }
-
-       /**
-        * Returns an array with missing categories/Keys
-        *
-        * @param array $config The array to check
-        *
-        * @return array
-        */
-       public function keyDiff(array $config)
-       {
-               $return = [];
-
-               $categories = array_keys($config);
-
-               foreach ($categories as $category) {
-                       if (is_array($config[$category])) {
-                               $keys = array_keys($config[$category]);
-
-                               foreach ($keys as $key) {
-                                       if (!isset($this->config[$category][$key])) {
-                                               $return[$category][$key] = $config[$category][$key];
-                                       }
-                               }
-                       }
-               }
-
-               return $return;
-       }
-}
diff --git a/src/Core/Config/Cache/PConfigCache.php b/src/Core/Config/Cache/PConfigCache.php
deleted file mode 100644 (file)
index b0dd209..0000000
+++ /dev/null
@@ -1,189 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config\Cache;
-
-use ParagonIE\HiddenString\HiddenString;
-
-/**
- * The Friendica config cache for users
- */
-class PConfigCache
-{
-       /**
-        * @var array
-        */
-       private $config;
-
-       /**
-        * @var bool
-        */
-       private $hidePasswordOutput;
-
-       /**
-        * @param bool $hidePasswordOutput True, if cache variables should take extra care of password values
-        */
-       public function __construct(bool $hidePasswordOutput = true)
-       {
-               $this->hidePasswordOutput = $hidePasswordOutput;
-       }
-
-       /**
-        * Tries to load the specified configuration array into the user specific config array.
-        * Doesn't overwrite previously set values by default to prevent default config files to supersede DB Config.
-        *
-        * @param int   $uid
-        * @param array $config
-        */
-       public function load($uid, array $config)
-       {
-               if (!is_int($uid)) {
-                       return;
-               }
-
-               $categories = array_keys($config);
-
-               foreach ($categories as $category) {
-                       if (isset($config[$category]) && is_array($config[$category])) {
-
-                               $keys = array_keys($config[$category]);
-
-                               foreach ($keys as $key) {
-                                       $value = $config[$category][$key];
-                                       if (isset($value)) {
-                                               $this->set($uid, $category, $key, $value);
-                                       }
-                               }
-                       }
-               }
-       }
-
-       /**
-        * Retrieves a value from the user config cache
-        *
-        * @param int    $uid User Id
-        * @param string $cat Config category
-        * @param string $key Config key
-        *
-        * @return null|string The value of the config entry or null if not set
-        */
-       public function get($uid, string $cat, string $key = null)
-       {
-               if (!is_int($uid)) {
-                       return null;
-               }
-
-               if (isset($this->config[$uid][$cat][$key])) {
-                       return $this->config[$uid][$cat][$key];
-               } elseif (!isset($key) && isset($this->config[$uid][$cat])) {
-                       return $this->config[$uid][$cat];
-               } else {
-                       return null;
-               }
-       }
-
-       /**
-        * Sets a value in the user config cache
-        *
-        * Accepts raw output from the pconfig table
-        *
-        * @param int    $uid   User Id
-        * @param string $cat   Config category
-        * @param string $key   Config key
-        * @param mixed  $value Value to set
-        *
-        * @return bool Set successful
-        */
-       public function set($uid, string $cat, string $key, $value)
-       {
-               if (!is_int($uid)) {
-                       return false;
-               }
-
-               if (!isset($this->config[$uid]) || !is_array($this->config[$uid])) {
-                       $this->config[$uid] = [];
-               }
-
-               if (!isset($this->config[$uid][$cat])) {
-                       $this->config[$uid][$cat] = [];
-               }
-
-               if ($this->hidePasswordOutput &&
-                   $key == 'password' &&
-                   !empty($value) && is_string($value)) {
-                       $this->config[$uid][$cat][$key] = new HiddenString((string)$value);
-               } else {
-                       $this->config[$uid][$cat][$key] = $value;
-               }
-
-
-               return true;
-       }
-
-       /**
-        * Deletes a value from the user config cache
-        *
-        * @param int    $uid User Id
-        * @param string $cat Config category
-        * @param string $key Config key
-        *
-        * @return bool true, if deleted
-        */
-       public function delete($uid, string $cat, string $key)
-       {
-               if (!is_int($uid)) {
-                       return false;
-               }
-
-               if (isset($this->config[$uid][$cat][$key])) {
-                       unset($this->config[$uid][$cat][$key]);
-                       if (count($this->config[$uid][$cat]) == 0) {
-                               unset($this->config[$uid][$cat]);
-                               if (count($this->config[$uid]) == 0) {
-                                       unset($this->config[$uid]);
-                               }
-                       }
-
-                       return true;
-               } else {
-                       return false;
-               }
-       }
-
-       /**
-        * Returns the whole configuration
-        *
-        * @return array The configuration
-        */
-       public function getAll()
-       {
-               return $this->config;
-       }
-
-       /**
-        * Returns an array with missing categories/Keys
-        *
-        * @param array $config The array to check
-        *
-        * @return array
-        */
-       public function keyDiff(array $config)
-       {
-               $return = [];
-
-               $categories = array_keys($config);
-
-               foreach ($categories as $category) {
-                       if (is_array($config[$category])) {
-                               $keys = array_keys($config[$category]);
-
-                               foreach ($keys as $key) {
-                                       if (!isset($this->config[$category][$key])) {
-                                               $return[$category][$key] = $config[$category][$key];
-                                       }
-                               }
-                       }
-               }
-
-               return $return;
-       }
-}
index 102f98ec378f5f2e9219ad12b8bc5ae6d97cfa5a..75318c40c870c338498eca95de8fdee33afc2723 100644 (file)
@@ -11,9 +11,7 @@ interface IConfig
        /**
         * Loads all configuration values of family into a cached storage.
         *
-        * All configuration values of the system are stored in the cache ( @see ConfigCache )
-        *
-        * @param string $cat The category of the configuration value
+        * All configuration values of the system are stored in the cache ( @param string $cat The category of the configuration value
         *
         * @return void
         */
@@ -67,7 +65,7 @@ interface IConfig
        /**
         * Returns the Config Cache
         *
-        * @return Cache\ConfigCache
+        * @return Cache
         */
        function getCache();
 }
diff --git a/src/Core/Config/IPConfiguration.php b/src/Core/Config/IPConfiguration.php
deleted file mode 100644 (file)
index 23d75eb..0000000
+++ /dev/null
@@ -1,82 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config;
-
-/**
- * Interface for accessing user specific configurations
- */
-interface IPConfiguration
-{
-
-       /**
-        * Loads all configuration values of a user's config family into a cached storage.
-        *
-        * All configuration values of the given user are stored with the $uid in the cache
-        *
-        * @param int $uid The user_id
-        * @param string $cat The category of the configuration value
-        *
-        * @return void
-        * @see PConfigCache
-        *
-        */
-       function load(int $uid, string $cat = 'config');
-
-       /**
-        * Get a particular user's config variable given the category name
-        * ($cat) and a key.
-        *
-        * Get a particular user's config value from the given category ($cat)
-        * and the $key with the $uid from a cached storage either from the $this->configAdapter
-        * (@see IConfigAdapter) or from the $this->configCache (@see PConfigCache).
-        *
-        * @param int     $uid           The user_id
-        * @param string  $cat           The category of the configuration value
-        * @param string  $key           The configuration key to query
-        * @param mixed   $default_value optional, The value to return if key is not set (default: null)
-        * @param boolean $refresh       optional, If true the config is loaded from the db and not from the cache (default: false)
-        *
-        * @return mixed Stored value or null if it does not exist
-        */
-       function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false);
-
-       /**
-        * Sets a configuration value for a user
-        *
-        * Stores a config value ($value) in the category ($family) under the key ($key)
-        * for the user_id $uid.
-        *
-        * @note  Please do not store booleans - convert to 0/1 integer values!
-        *
-        * @param int    $uid   The user_id
-        * @param string $cat   The category of the configuration value
-        * @param string $key   The configuration key to set
-        * @param mixed  $value The value to store
-        *
-        * @return bool Operation success
-        */
-       function set(int $uid, string $cat, string $key, $value);
-
-       /**
-        * Deletes the given key from the users's configuration.
-        *
-        * Removes the configured value from the stored cache in $this->configCache
-        * (@see ConfigCache) and removes it from the database (@see IConfigAdapter)
-        *  with the given $uid.
-        *
-        * @param int $uid The user_id
-        * @param string $cat The category of the configuration value
-        * @param string $key The configuration key to delete
-        *
-        * @return bool
-        */
-       function delete(int $uid, string $cat, string $key);
-
-
-       /**
-        * Returns the Config Cache
-        *
-        * @return Cache\PConfigCache
-        */
-       function getCache();
-}
index e4cec62cb0960d317767abd0a54fda95b513dd68..05b6a8a45fdfc8f34cbf0d874a289e829b2e43e6 100644 (file)
@@ -20,10 +20,10 @@ class JitConfig extends BaseConfig
        private $db_loaded;
 
        /**
-        * @param Cache\ConfigCache   $configCache The configuration cache (based on the config-files)
+        * @param Cache               $configCache The configuration cache (based on the config-files)
         * @param Model\Config\Config $configModel The configuration model
         */
-       public function __construct(Cache\ConfigCache $configCache, Model\Config\Config $configModel)
+       public function __construct(Cache $configCache, Model\Config\Config $configModel)
        {
                parent::__construct($configCache, $configModel);
                $this->db_loaded = [];
diff --git a/src/Core/Config/JitPConfiguration.php b/src/Core/Config/JitPConfiguration.php
deleted file mode 100644 (file)
index fb5c9d1..0000000
+++ /dev/null
@@ -1,131 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config;
-
-use Friendica\Model;
-
-/**
- * This class implements the Just-In-Time configuration, which will cache
- * user config values in a cache, once they are retrieved.
- *
- * Default Configuration type.
- * Provides the best performance for pages loading few configuration variables.
- */
-class JitPConfiguration extends PConfiguration
-{
-       /**
-        * @var array Array of already loaded db values (even if there was no value)
-        */
-       private $db_loaded;
-
-       /**
-        * @param Cache\PConfigCache   $configCache The configuration cache
-        * @param Model\Config\PConfig $configModel The configuration model
-        */
-       public function __construct(Cache\PConfigCache $configCache, Model\Config\PConfig $configModel)
-       {
-               parent::__construct($configCache, $configModel);
-               $this->db_loaded = [];
-       }
-
-       /**
-        * {@inheritDoc}
-        *
-        */
-       public function load(int $uid, string $cat = 'config')
-       {
-               // If not connected or no uid, do nothing
-               if (!$uid || !$this->configModel->isConnected()) {
-                       return;
-               }
-
-               $config = $this->configModel->load($uid, $cat);
-
-               if (!empty($config[$cat])) {
-                       foreach ($config[$cat] as $key => $value) {
-                               $this->db_loaded[$uid][$cat][$key] = true;
-                       }
-               }
-
-               // load the whole category out of the DB into the cache
-               $this->configCache->load($uid, $config);
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false)
-       {
-               if (!$uid) {
-                       return $default_value;
-               }
-
-               // if the value isn't loaded or refresh is needed, load it to the cache
-               if ($this->configModel->isConnected() &&
-                   (empty($this->db_loaded[$uid][$cat][$key]) ||
-                    $refresh)) {
-
-                       $dbvalue = $this->configModel->get($uid, $cat, $key);
-
-                       if (isset($dbvalue)) {
-                               $this->configCache->set($uid, $cat, $key, $dbvalue);
-                               unset($dbvalue);
-                       }
-
-                       $this->db_loaded[$uid][$cat][$key] = true;
-               }
-
-               // use the config cache for return
-               $result = $this->configCache->get($uid, $cat, $key);
-
-               return (isset($result)) ? $result : $default_value;
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function set(int $uid, string $cat, string $key, $value)
-       {
-               if (!$uid) {
-                       return false;
-               }
-
-               // set the cache first
-               $cached = $this->configCache->set($uid, $cat, $key, $value);
-
-               // If there is no connected adapter, we're finished
-               if (!$this->configModel->isConnected()) {
-                       return $cached;
-               }
-
-               $stored = $this->configModel->set($uid, $cat, $key, $value);
-
-               $this->db_loaded[$uid][$cat][$key] = $stored;
-
-               return $cached && $stored;
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function delete(int $uid, string $cat, string $key)
-       {
-               if (!$uid) {
-                       return false;
-               }
-
-               $cacheRemoved = $this->configCache->delete($uid, $cat, $key);
-
-               if (isset($this->db_loaded[$uid][$cat][$key])) {
-                       unset($this->db_loaded[$uid][$cat][$key]);
-               }
-
-               if (!$this->configModel->isConnected()) {
-                       return $cacheRemoved;
-               }
-
-               $storeRemoved = $this->configModel->delete($uid, $cat, $key);
-
-               return $cacheRemoved || $storeRemoved;
-       }
-}
diff --git a/src/Core/Config/PConfiguration.php b/src/Core/Config/PConfiguration.php
deleted file mode 100644 (file)
index ee90be3..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config;
-
-use Friendica\Model;
-
-/**
- * This class is responsible for the user-specific configuration values in Friendica
- * The values are set through the Config-DB-Table (per Config-DB-model @see Model\Config\PConfig)
- *
- * The configuration cache (@see Cache\PConfigCache) is used for temporary caching of database calls. This will
- * increase the performance.
- */
-abstract class PConfiguration implements IPConfiguration
-{
-       /**
-        * @var Cache\PConfigCache
-        */
-       protected $configCache;
-
-       /**
-        * @var Model\Config\PConfig
-        */
-       protected $configModel;
-
-       /**
-        * @param Cache\PConfigCache   $configCache The configuration cache
-        * @param Model\Config\PConfig $configModel The configuration model
-        */
-       public function __construct(Cache\PConfigCache $configCache, Model\Config\PConfig $configModel)
-       {
-               $this->configCache = $configCache;
-               $this->configModel = $configModel;
-       }
-
-       /**
-        * Returns the Config Cache
-        *
-        * @return Cache\PConfigCache
-        */
-       public function getCache()
-       {
-               return $this->configCache;
-       }
-}
index 50ea9200f9a0755ea26f5f43be9a252e421b2bcf..5b8350cd75cfa5e1a17e9cd0432294a987106f0f 100644 (file)
@@ -17,10 +17,10 @@ class PreloadConfig extends BaseConfig
        private $config_loaded;
 
        /**
-        * @param Cache\ConfigCache   $configCache The configuration cache (based on the config-files)
+        * @param Cache               $configCache The configuration cache (based on the config-files)
         * @param Model\Config\Config $configModel The configuration model
         */
-       public function __construct(Cache\ConfigCache $configCache, Model\Config\Config $configModel)
+       public function __construct(Cache $configCache, Model\Config\Config $configModel)
        {
                parent::__construct($configCache, $configModel);
                $this->config_loaded = false;
diff --git a/src/Core/Config/PreloadPConfiguration.php b/src/Core/Config/PreloadPConfiguration.php
deleted file mode 100644 (file)
index 975a15c..0000000
+++ /dev/null
@@ -1,128 +0,0 @@
-<?php
-
-namespace Friendica\Core\Config;
-
-use Friendica\Model;
-
-/**
- * This class implements the preload configuration, which will cache
- * all user config values per call in a cache.
- *
- * Minimizes the number of database queries to retrieve configuration values at the cost of memory.
- */
-class PreloadPConfiguration extends PConfiguration
-{
-       /** @var array */
-       private $config_loaded;
-
-       /**
-        * @param Cache\PConfigCache   $configCache The configuration cache
-        * @param Model\Config\PConfig $configModel The configuration model
-        */
-       public function __construct(Cache\PConfigCache $configCache, Model\Config\PConfig $configModel)
-       {
-               parent::__construct($configCache, $configModel);
-               $this->config_loaded = [];
-       }
-
-       /**
-        * {@inheritDoc}
-        *
-        * This loads all config values everytime load is called
-        *
-        */
-       public function load(int $uid, string $cat = 'config')
-       {
-               // Don't load the whole configuration twice or with invalid uid
-               if (!$uid || !empty($this->config_loaded[$uid])) {
-                       return;
-               }
-
-               // If not connected, do nothing
-               if (!$this->configModel->isConnected()) {
-                       return;
-               }
-
-               $config                    = $this->configModel->load($uid);
-               $this->config_loaded[$uid] = true;
-
-               // load the whole category out of the DB into the cache
-               $this->configCache->load($uid, $config);
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false)
-       {
-               if (!$uid) {
-                       return $default_value;
-               }
-
-               if (empty($this->config_loaded[$uid])) {
-                       $this->load($uid);
-               } elseif ($refresh) {
-                       if ($this->configModel->isConnected()) {
-                               $config = $this->configModel->get($uid, $cat, $key);
-                               if (isset($config)) {
-                                       $this->configCache->set($uid, $cat, $key, $config);
-                               }
-                       }
-               }
-
-               // use the config cache for return
-               $result = $this->configCache->get($uid, $cat, $key);
-
-               return (isset($result)) ? $result : $default_value;
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function set(int $uid, string $cat, string $key, $value)
-       {
-               if (!$uid) {
-                       return false;
-               }
-
-               if (empty($this->config_loaded[$uid])) {
-                       $this->load($uid);
-               }
-
-               // set the cache first
-               $cached = $this->configCache->set($uid, $cat, $key, $value);
-
-               // If there is no connected adapter, we're finished
-               if (!$this->configModel->isConnected()) {
-                       return $cached;
-               }
-
-               $stored = $this->configModel->set($uid, $cat, $key, $value);
-
-               return $cached && $stored;
-       }
-
-       /**
-        * {@inheritDoc}
-        */
-       public function delete(int $uid, string $cat, string $key)
-       {
-               if (!$uid) {
-                       return false;
-               }
-
-               if (empty($this->config_loaded[$uid])) {
-                       $this->load($uid);
-               }
-
-               $cacheRemoved = $this->configCache->delete($uid, $cat, $key);
-
-               if (!$this->configModel->isConnected()) {
-                       return $cacheRemoved;
-               }
-
-               $storeRemoved = $this->configModel->delete($uid, $cat, $key);
-
-               return $cacheRemoved || $storeRemoved;
-       }
-}
index 01ef1d8c923c5b397ef1e3e3806abdefdba1e594..b780776cc100cd29a1fe0718d43ee47af835baf9 100644 (file)
@@ -6,7 +6,7 @@ namespace Friendica\Core;
 
 use DOMDocument;
 use Exception;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Database\Database;
 use Friendica\Database\DBStructure;
 use Friendica\DI;
@@ -129,12 +129,12 @@ class Installer
         * - Creates `config/local.config.php`
         * - Installs Database Structure
         *
-        * @param ConfigCache $configCache The config cache with all config relevant information
+        * @param Cache $configCache The config cache with all config relevant information
         *
         * @return bool true if the config was created, otherwise false
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       public function createConfig(ConfigCache $configCache)
+       public function createConfig(Cache $configCache)
        {
                $basepath = $configCache->get('system', 'basepath');
 
@@ -618,12 +618,12 @@ class Installer
        /**
         * Setup the default cache for a new installation
         *
-        * @param ConfigCache $configCache The configuration cache
-        * @param string       $basePath    The determined basepath
+        * @param Cache  $configCache The configuration cache
+        * @param string $basePath    The determined basepath
         *
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       public function setUpCache(ConfigCache $configCache, $basePath)
+       public function setUpCache(Cache $configCache, $basePath)
        {
                $configCache->set('config', 'php_path'  , $this->getPHPPath());
                $configCache->set('system', 'basepath'  , $basePath);
diff --git a/src/Core/PConfig/Cache.php b/src/Core/PConfig/Cache.php
new file mode 100644 (file)
index 0000000..5dc399e
--- /dev/null
@@ -0,0 +1,189 @@
+<?php
+
+namespace Friendica\Core\PConfig;
+
+use ParagonIE\HiddenString\HiddenString;
+
+/**
+ * The Friendica config cache for users
+ */
+class Cache
+{
+       /**
+        * @var array
+        */
+       private $config;
+
+       /**
+        * @var bool
+        */
+       private $hidePasswordOutput;
+
+       /**
+        * @param bool $hidePasswordOutput True, if cache variables should take extra care of password values
+        */
+       public function __construct(bool $hidePasswordOutput = true)
+       {
+               $this->hidePasswordOutput = $hidePasswordOutput;
+       }
+
+       /**
+        * Tries to load the specified configuration array into the user specific config array.
+        * Doesn't overwrite previously set values by default to prevent default config files to supersede DB Config.
+        *
+        * @param int   $uid
+        * @param array $config
+        */
+       public function load($uid, array $config)
+       {
+               if (!is_int($uid)) {
+                       return;
+               }
+
+               $categories = array_keys($config);
+
+               foreach ($categories as $category) {
+                       if (isset($config[$category]) && is_array($config[$category])) {
+
+                               $keys = array_keys($config[$category]);
+
+                               foreach ($keys as $key) {
+                                       $value = $config[$category][$key];
+                                       if (isset($value)) {
+                                               $this->set($uid, $category, $key, $value);
+                                       }
+                               }
+                       }
+               }
+       }
+
+       /**
+        * Retrieves a value from the user config cache
+        *
+        * @param int    $uid User Id
+        * @param string $cat Config category
+        * @param string $key Config key
+        *
+        * @return null|string The value of the config entry or null if not set
+        */
+       public function get($uid, string $cat, string $key = null)
+       {
+               if (!is_int($uid)) {
+                       return null;
+               }
+
+               if (isset($this->config[$uid][$cat][$key])) {
+                       return $this->config[$uid][$cat][$key];
+               } elseif (!isset($key) && isset($this->config[$uid][$cat])) {
+                       return $this->config[$uid][$cat];
+               } else {
+                       return null;
+               }
+       }
+
+       /**
+        * Sets a value in the user config cache
+        *
+        * Accepts raw output from the pconfig table
+        *
+        * @param int    $uid   User Id
+        * @param string $cat   Config category
+        * @param string $key   Config key
+        * @param mixed  $value Value to set
+        *
+        * @return bool Set successful
+        */
+       public function set($uid, string $cat, string $key, $value)
+       {
+               if (!is_int($uid)) {
+                       return false;
+               }
+
+               if (!isset($this->config[$uid]) || !is_array($this->config[$uid])) {
+                       $this->config[$uid] = [];
+               }
+
+               if (!isset($this->config[$uid][$cat])) {
+                       $this->config[$uid][$cat] = [];
+               }
+
+               if ($this->hidePasswordOutput &&
+                   $key == 'password' &&
+                   !empty($value) && is_string($value)) {
+                       $this->config[$uid][$cat][$key] = new HiddenString((string)$value);
+               } else {
+                       $this->config[$uid][$cat][$key] = $value;
+               }
+
+
+               return true;
+       }
+
+       /**
+        * Deletes a value from the user config cache
+        *
+        * @param int    $uid User Id
+        * @param string $cat Config category
+        * @param string $key Config key
+        *
+        * @return bool true, if deleted
+        */
+       public function delete($uid, string $cat, string $key)
+       {
+               if (!is_int($uid)) {
+                       return false;
+               }
+
+               if (isset($this->config[$uid][$cat][$key])) {
+                       unset($this->config[$uid][$cat][$key]);
+                       if (count($this->config[$uid][$cat]) == 0) {
+                               unset($this->config[$uid][$cat]);
+                               if (count($this->config[$uid]) == 0) {
+                                       unset($this->config[$uid]);
+                               }
+                       }
+
+                       return true;
+               } else {
+                       return false;
+               }
+       }
+
+       /**
+        * Returns the whole configuration
+        *
+        * @return array The configuration
+        */
+       public function getAll()
+       {
+               return $this->config;
+       }
+
+       /**
+        * Returns an array with missing categories/Keys
+        *
+        * @param array $config The array to check
+        *
+        * @return array
+        */
+       public function keyDiff(array $config)
+       {
+               $return = [];
+
+               $categories = array_keys($config);
+
+               foreach ($categories as $category) {
+                       if (is_array($config[$category])) {
+                               $keys = array_keys($config[$category]);
+
+                               foreach ($keys as $key) {
+                                       if (!isset($this->config[$category][$key])) {
+                                               $return[$category][$key] = $config[$category][$key];
+                                       }
+                               }
+                       }
+               }
+
+               return $return;
+       }
+}
diff --git a/src/Core/PConfig/IPConfig.php b/src/Core/PConfig/IPConfig.php
new file mode 100644 (file)
index 0000000..61ad514
--- /dev/null
@@ -0,0 +1,82 @@
+<?php
+
+namespace Friendica\Core\PConfig;
+
+/**
+ * Interface for accessing user specific configurations
+ */
+interface IPConfig
+{
+
+       /**
+        * Loads all configuration values of a user's config family into a cached storage.
+        *
+        * All configuration values of the given user are stored with the $uid in the cache
+        *
+        * @param int $uid The user_id
+        * @param string $cat The category of the configuration value
+        *
+        * @return void
+        * @see Cache
+        *
+        */
+       function load(int $uid, string $cat = 'config');
+
+       /**
+        * Get a particular user's config variable given the category name
+        * ($cat) and a key.
+        *
+        * Get a particular user's config value from the given category ($cat)
+        * and the $key with the $uid from a cached storage either from the $this->configAdapter
+        * (@see IConfigAdapter) or from the $this->configCache (@see PConfigCache).
+        *
+        * @param int     $uid           The user_id
+        * @param string  $cat           The category of the configuration value
+        * @param string  $key           The configuration key to query
+        * @param mixed   $default_value optional, The value to return if key is not set (default: null)
+        * @param boolean $refresh       optional, If true the config is loaded from the db and not from the cache (default: false)
+        *
+        * @return mixed Stored value or null if it does not exist
+        */
+       function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false);
+
+       /**
+        * Sets a configuration value for a user
+        *
+        * Stores a config value ($value) in the category ($family) under the key ($key)
+        * for the user_id $uid.
+        *
+        * @note  Please do not store booleans - convert to 0/1 integer values!
+        *
+        * @param int    $uid   The user_id
+        * @param string $cat   The category of the configuration value
+        * @param string $key   The configuration key to set
+        * @param mixed  $value The value to store
+        *
+        * @return bool Operation success
+        */
+       function set(int $uid, string $cat, string $key, $value);
+
+       /**
+        * Deletes the given key from the users's configuration.
+        *
+        * Removes the configured value from the stored cache in $this->configCache
+        * (@see ConfigCache) and removes it from the database (@see IConfigAdapter)
+        *  with the given $uid.
+        *
+        * @param int $uid The user_id
+        * @param string $cat The category of the configuration value
+        * @param string $key The configuration key to delete
+        *
+        * @return bool
+        */
+       function delete(int $uid, string $cat, string $key);
+
+
+       /**
+        * Returns the Config Cache
+        *
+        * @return Cache
+        */
+       function getCache();
+}
diff --git a/src/Core/PConfig/JitPConfig.php b/src/Core/PConfig/JitPConfig.php
new file mode 100644 (file)
index 0000000..758183b
--- /dev/null
@@ -0,0 +1,132 @@
+<?php
+
+namespace Friendica\Core\PConfig;
+
+use Friendica\Core\BasePConfig;
+use Friendica\Model;
+
+/**
+ * This class implements the Just-In-Time configuration, which will cache
+ * user config values in a cache, once they are retrieved.
+ *
+ * Default Configuration type.
+ * Provides the best performance for pages loading few configuration variables.
+ */
+class JitPConfig extends BasePConfig
+{
+       /**
+        * @var array Array of already loaded db values (even if there was no value)
+        */
+       private $db_loaded;
+
+       /**
+        * @param Cache                $configCache The configuration cache
+        * @param Model\Config\PConfig $configModel The configuration model
+        */
+       public function __construct(Cache $configCache, Model\Config\PConfig $configModel)
+       {
+               parent::__construct($configCache, $configModel);
+               $this->db_loaded = [];
+       }
+
+       /**
+        * {@inheritDoc}
+        *
+        */
+       public function load(int $uid, string $cat = 'config')
+       {
+               // If not connected or no uid, do nothing
+               if (!$uid || !$this->configModel->isConnected()) {
+                       return;
+               }
+
+               $config = $this->configModel->load($uid, $cat);
+
+               if (!empty($config[$cat])) {
+                       foreach ($config[$cat] as $key => $value) {
+                               $this->db_loaded[$uid][$cat][$key] = true;
+                       }
+               }
+
+               // load the whole category out of the DB into the cache
+               $this->configCache->load($uid, $config);
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false)
+       {
+               if (!$uid) {
+                       return $default_value;
+               }
+
+               // if the value isn't loaded or refresh is needed, load it to the cache
+               if ($this->configModel->isConnected() &&
+                   (empty($this->db_loaded[$uid][$cat][$key]) ||
+                    $refresh)) {
+
+                       $dbvalue = $this->configModel->get($uid, $cat, $key);
+
+                       if (isset($dbvalue)) {
+                               $this->configCache->set($uid, $cat, $key, $dbvalue);
+                               unset($dbvalue);
+                       }
+
+                       $this->db_loaded[$uid][$cat][$key] = true;
+               }
+
+               // use the config cache for return
+               $result = $this->configCache->get($uid, $cat, $key);
+
+               return (isset($result)) ? $result : $default_value;
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function set(int $uid, string $cat, string $key, $value)
+       {
+               if (!$uid) {
+                       return false;
+               }
+
+               // set the cache first
+               $cached = $this->configCache->set($uid, $cat, $key, $value);
+
+               // If there is no connected adapter, we're finished
+               if (!$this->configModel->isConnected()) {
+                       return $cached;
+               }
+
+               $stored = $this->configModel->set($uid, $cat, $key, $value);
+
+               $this->db_loaded[$uid][$cat][$key] = $stored;
+
+               return $cached && $stored;
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function delete(int $uid, string $cat, string $key)
+       {
+               if (!$uid) {
+                       return false;
+               }
+
+               $cacheRemoved = $this->configCache->delete($uid, $cat, $key);
+
+               if (isset($this->db_loaded[$uid][$cat][$key])) {
+                       unset($this->db_loaded[$uid][$cat][$key]);
+               }
+
+               if (!$this->configModel->isConnected()) {
+                       return $cacheRemoved;
+               }
+
+               $storeRemoved = $this->configModel->delete($uid, $cat, $key);
+
+               return $cacheRemoved || $storeRemoved;
+       }
+}
diff --git a/src/Core/PConfig/PreloadPConfig.php b/src/Core/PConfig/PreloadPConfig.php
new file mode 100644 (file)
index 0000000..e53fd97
--- /dev/null
@@ -0,0 +1,129 @@
+<?php
+
+namespace Friendica\Core\PConfig;
+
+use Friendica\Core\BasePConfig;
+use Friendica\Model;
+
+/**
+ * This class implements the preload configuration, which will cache
+ * all user config values per call in a cache.
+ *
+ * Minimizes the number of database queries to retrieve configuration values at the cost of memory.
+ */
+class PreloadPConfig extends BasePConfig
+{
+       /** @var array */
+       private $config_loaded;
+
+       /**
+        * @param Cache                $configCache The configuration cache
+        * @param Model\Config\PConfig $configModel The configuration model
+        */
+       public function __construct(Cache $configCache, Model\Config\PConfig $configModel)
+       {
+               parent::__construct($configCache, $configModel);
+               $this->config_loaded = [];
+       }
+
+       /**
+        * {@inheritDoc}
+        *
+        * This loads all config values everytime load is called
+        *
+        */
+       public function load(int $uid, string $cat = 'config')
+       {
+               // Don't load the whole configuration twice or with invalid uid
+               if (!$uid || !empty($this->config_loaded[$uid])) {
+                       return;
+               }
+
+               // If not connected, do nothing
+               if (!$this->configModel->isConnected()) {
+                       return;
+               }
+
+               $config                    = $this->configModel->load($uid);
+               $this->config_loaded[$uid] = true;
+
+               // load the whole category out of the DB into the cache
+               $this->configCache->load($uid, $config);
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function get(int $uid, string $cat, string $key, $default_value = null, bool $refresh = false)
+       {
+               if (!$uid) {
+                       return $default_value;
+               }
+
+               if (empty($this->config_loaded[$uid])) {
+                       $this->load($uid);
+               } elseif ($refresh) {
+                       if ($this->configModel->isConnected()) {
+                               $config = $this->configModel->get($uid, $cat, $key);
+                               if (isset($config)) {
+                                       $this->configCache->set($uid, $cat, $key, $config);
+                               }
+                       }
+               }
+
+               // use the config cache for return
+               $result = $this->configCache->get($uid, $cat, $key);
+
+               return (isset($result)) ? $result : $default_value;
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function set(int $uid, string $cat, string $key, $value)
+       {
+               if (!$uid) {
+                       return false;
+               }
+
+               if (empty($this->config_loaded[$uid])) {
+                       $this->load($uid);
+               }
+
+               // set the cache first
+               $cached = $this->configCache->set($uid, $cat, $key, $value);
+
+               // If there is no connected adapter, we're finished
+               if (!$this->configModel->isConnected()) {
+                       return $cached;
+               }
+
+               $stored = $this->configModel->set($uid, $cat, $key, $value);
+
+               return $cached && $stored;
+       }
+
+       /**
+        * {@inheritDoc}
+        */
+       public function delete(int $uid, string $cat, string $key)
+       {
+               if (!$uid) {
+                       return false;
+               }
+
+               if (empty($this->config_loaded[$uid])) {
+                       $this->load($uid);
+               }
+
+               $cacheRemoved = $this->configCache->delete($uid, $cat, $key);
+
+               if (!$this->configModel->isConnected()) {
+                       return $cacheRemoved;
+               }
+
+               $storeRemoved = $this->configModel->delete($uid, $cat, $key);
+
+               return $cacheRemoved || $storeRemoved;
+       }
+}
index 1109b1afb3f940863603c007b3c5e082d707c359..22c81079b9a715fbb50f28f91b170b12cc8a2e85 100644 (file)
@@ -141,11 +141,11 @@ abstract class DI
        }
 
        /**
-        * @return Core\Config\IPConfiguration
+        * @return \Friendica\Core\PConfig\IPConfig
         */
        public static function pConfig()
        {
-               return self::$dice->create(Core\Config\IPConfiguration::class);
+               return self::$dice->create(Core\PConfig\IPConfig::class);
        }
 
        /**
index 3afbfbc8f209ccf58f9828c82b7b4fbfe5786f48..8a893ab9350c0aac19e6bc78c492d5790e99e789 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Database;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\System;
 use Friendica\Network\HTTPException\InternalServerErrorException;
 use Friendica\Util\DateTimeFormat;
@@ -25,7 +25,7 @@ class Database
        protected $connected = false;
 
        /**
-        * @var ConfigCache
+        * @var Cache
         */
        protected $configCache;
        /**
@@ -47,7 +47,7 @@ class Database
        protected $in_retrial     = false;
        private $relation       = [];
 
-       public function __construct(ConfigCache $configCache, Profiler $profiler, LoggerInterface $logger, array $server = [])
+       public function __construct(Cache $configCache, Profiler $profiler, LoggerInterface $logger, array $server = [])
        {
                // We are storing these values for being able to perform a reconnect
                $this->configCache   = $configCache;
index f912399345622560ac14dd72900ac9db723f7c9b..585d6eb7eed192f9acf9b84ae7ed919ca7b60e02 100644 (file)
@@ -13,23 +13,23 @@ class ConfigFactory
        /**
         * @param ConfigFileLoader $loader The Config Cache loader (INI/config/.htconfig)
         *
-        * @return Cache\ConfigCache
+        * @return Cache
         */
        public function createCache(ConfigFileLoader $loader)
        {
-               $configCache = new Cache\ConfigCache();
+               $configCache = new Cache();
                $loader->setupCache($configCache);
 
                return $configCache;
        }
 
        /**
-        * @param Cache\ConfigCache $configCache The config cache of this adapter
-        * @param ConfigModel       $configModel The configuration model
+        * @param Cache       $configCache The config cache of this adapter
+        * @param ConfigModel $configModel The configuration model
         *
         * @return Config\IConfig
         */
-       public function createConfig(Cache\ConfigCache $configCache, ConfigModel $configModel)
+       public function createConfig(Cache $configCache, ConfigModel $configModel)
        {
                if ($configCache->get('system', 'config_adapter') === 'preload') {
                        $configuration = new Config\PreloadConfig($configCache, $configModel);
@@ -42,18 +42,18 @@ class ConfigFactory
        }
 
        /**
-        * @param Cache\ConfigCache  $configCache  The config cache
-        * @param Cache\PConfigCache $pConfigCache The personal config cache
-        * @param PConfigModel       $configModel  The configuration model
+        * @param Cache                         $configCache  The config cache
+        * @param \Friendica\Core\PConfig\Cache $pConfigCache The personal config cache
+        * @param PConfigModel                  $configModel  The configuration model
         *
-        * @return Config\IPConfiguration
+        * @return \Friendica\Core\PConfig\IPConfig
         */
-       public function createPConfig(Cache\ConfigCache $configCache, Cache\PConfigCache $pConfigCache, PConfigModel $configModel)
+       public function createPConfig(Cache $configCache, \Friendica\Core\PConfig\Cache $pConfigCache, PConfigModel $configModel)
        {
                if ($configCache->get('system', 'config_adapter') === 'preload') {
-                       $configuration = new Config\PreloadPConfiguration($pConfigCache, $configModel);
+                       $configuration = new \Friendica\Core\PConfig\PreloadPConfig($pConfigCache, $configModel);
                } else {
-                       $configuration = new Config\JitPConfiguration($pConfigCache, $configModel);
+                       $configuration = new \Friendica\Core\PConfig\JitPConfig($pConfigCache, $configModel);
                }
 
                return $configuration;
index 9912f5dffbced1ae3d2d063105b1ac27b532d340..a27635a07e722bd161ed0098fb16d58bbd2afd8c 100644 (file)
@@ -6,7 +6,7 @@ use Exception;
 use Friendica\App;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
-use Friendica\Core\Config\IPConfiguration;
+use Friendica\Core\PConfig\IPConfig;
 use Friendica\Core\L10n;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
@@ -71,13 +71,13 @@ final class Notify
        private $args;
        /** @var App\BaseURL */
        private $baseUrl;
-       /** @var IPConfiguration */
+       /** @var IPConfig */
        private $pConfig;
        /** @var LoggerInterface */
        private $logger;
 
        public function __construct(Database $dba, L10n $l10n, App\Arguments $args, App\BaseURL $baseUrl,
-                                   IPConfiguration $pConfig, LoggerInterface $logger)
+                                   IPConfig $pConfig, LoggerInterface $logger)
        {
                $this->dba     = $dba;
                $this->l10n    = $l10n;
index c74f877268d5ba1c193e190a1e0a558bf613c02b..e5adc271866dffc86d33ff0092acab3add85317c 100644 (file)
@@ -110,7 +110,7 @@ class Summary extends BaseAdminModule
 
                // check legacy basepath settings
                $configLoader = new ConfigFileLoader($a->getBasePath());
-               $configCache = new Config\Cache\ConfigCache();
+               $configCache = new Config\Cache();
                $configLoader->setupCache($configCache);
                $confBasepath = $configCache->get('system', 'basepath');
                $currBasepath = DI::config()->get('system', 'basepath');
index e20d80f2055bb6351a57ddf02c5b36b38c692f7c..392adaab1bcf6eaccd939216cc4fb08287ac1e6e 100644 (file)
@@ -5,7 +5,7 @@ namespace Friendica\Module;
 use Friendica\App;
 use Friendica\BaseModule;
 use Friendica\Core;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Renderer;
 use Friendica\DI;
 use Friendica\Network\HTTPException;
@@ -332,13 +332,13 @@ class Install extends BaseModule
        /**
         * Checks the $_POST settings and updates the config Cache for it
         *
-        * @param ConfigCache $configCache The current config cache
+        * @param Cache       $configCache The current config cache
         * @param array       $post        The $_POST data
         * @param string      $cat         The category of the setting
         * @param string      $key         The key of the setting
         * @param null|string $default     The default value
         */
-       private static function checkSetting(ConfigCache $configCache, array $post, $cat, $key, $default = null)
+       private static function checkSetting(Cache $configCache, array $post, $cat, $key, $default = null)
        {
                $configCache->set($cat, $key,
                        Strings::escapeTags(
index 80da4018c09e63efed1edd83dca011c53fbe0b09..5acf4630d88efa9f8db02fcc876e7c62593d15d8 100644 (file)
@@ -4,10 +4,10 @@ namespace Friendica\Util;
 
 use Exception;
 use Friendica\Core\Addon;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 
 /**
- * The ConfigFileLoader loads config-files and stores them in a ConfigCache ( @see ConfigCache )
+ * The ConfigFileLoader loads config-files and stores them in a ConfigCache ( @see Cache )
  *
  * It is capable of loading the following config files:
  * - *.config.php   (current)
@@ -77,12 +77,12 @@ class ConfigFileLoader
         * First loads the default value for all the configuration keys, then the legacy configuration files, then the
         * expected local.config.php
         *
-        * @param ConfigCache $config The config cache to load to
-        * @param bool        $raw    Setup the raw config format
+        * @param Cache $config The config cache to load to
+        * @param bool  $raw    Setup the raw config format
         *
         * @throws Exception
         */
-       public function setupCache(ConfigCache $config, $raw = false)
+       public function setupCache(Cache $config, $raw = false)
        {
                // Load static config files first, the order is important
                $config->load($this->loadStaticConfig('defaults'));
@@ -128,13 +128,13 @@ class ConfigFileLoader
        /**
         * Tries to load the specified core-configuration into the config cache.
         *
-        * @param ConfigCache $config The Config cache
+        * @param Cache $config The Config cache
         *
         * @return array The config array (empty if no config found)
         *
         * @throws Exception if the configuration file isn't readable
         */
-       private function loadCoreConfig(ConfigCache $config)
+       private function loadCoreConfig(Cache $config)
        {
                // try to load legacy ini-files first
                foreach ($this->getConfigFiles(true) as $configFile) {
index e4061f51941d251ef2d448fb1bfcaa723e5c3ac2..c3fddfac70f4a3751d356ef2dca941b046c7c360 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Util;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Config\IConfig;
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
@@ -56,9 +56,9 @@ class Profiler implements ContainerInterface
        }
 
        /**
-        * @param ConfigCache $configCache The configuration cache
+        * @param Cache $configCache The configuration cache
         */
-       public function __construct(ConfigCache $configCache)
+       public function __construct(Cache $configCache)
        {
                $this->enabled = $configCache->get('system', 'profiler');
                $this->rendertime = $configCache->get('rendertime', 'callstack');
index cf2d6dd3ff959e2889fbe3313b58105db1892b8a..51fff622898a1dfda0f72c605fcc53e25a5cc4b4 100644 (file)
@@ -48,43 +48,43 @@ return [
                        $_SERVER
                ]
        ],
-       Util\BasePath::class            => [
+       Util\BasePath::class         => [
                'constructParams' => [
                        dirname(__FILE__, 2),
                        $_SERVER
                ]
        ],
-       Util\ConfigFileLoader::class    => [
+       Util\ConfigFileLoader::class => [
                'shared'          => true,
                'constructParams' => [
                        [Dice::INSTANCE => '$basepath'],
                ],
        ],
-       Config\Cache\ConfigCache::class => [
+       Config\Cache::class          => [
                'instanceOf' => Factory\ConfigFactory::class,
                'call'       => [
                        ['createCache', [], Dice::CHAIN_CALL],
                ],
        ],
-       App\Mode::class                 => [
+       App\Mode::class              => [
                'call' => [
                        ['determineRunMode', [true, $_SERVER], Dice::CHAIN_CALL],
                        ['determine', [], Dice::CHAIN_CALL],
                ],
        ],
-       Config\IConfig::class           => [
+       Config\IConfig::class                   => [
                'instanceOf' => Factory\ConfigFactory::class,
                'call'       => [
                        ['createConfig', [], Dice::CHAIN_CALL],
                ],
        ],
-       Config\IPConfiguration::class   => [
+       \Friendica\Core\PConfig\IPConfig::class => [
                'instanceOf' => Factory\ConfigFactory::class,
                'call'       => [
                        ['createPConfig', [], Dice::CHAIN_CALL],
                ]
        ],
-       Database::class                 => [
+       Database::class                         => [
                'constructParams' => [
                        [Dice::INSTANCE => \Psr\Log\NullLogger::class],
                        $_SERVER,
index 353676932fc5e91774c8b173ae71edf2176f5109..6e929e5f218c1bc383081ef0808b12c445651a9d 100644 (file)
@@ -52,9 +52,9 @@ trait AppMockTrait
                $this->dice = \Mockery::mock(Dice::class)->makePartial();
                $this->dice = $this->dice->addRules(include __DIR__ . '/../../static/dependencies.config.php');
 
-               $this->configMock = \Mockery::mock(Config\Cache\ConfigCache::class);
+               $this->configMock = \Mockery::mock(Config\Cache::class);
                $this->dice->shouldReceive('create')
-                          ->with(Config\Cache\ConfigCache::class)
+                          ->with(Config\Cache::class)
                           ->andReturn($this->configMock);
                $this->mode = \Mockery::mock(App\Mode::class);
                $this->dice->shouldReceive('create')
index 468e967d65f32992cdb56a75a9ece0aa63350c78..944b6239050c0b5d5ece96fd63a88418ecafd94d 100644 (file)
@@ -6,7 +6,7 @@ use Dice\Dice;
 use Friendica\App;
 use Friendica\Core\Cache\ICache;
 use Friendica\Core\Cache\IMemoryCache;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Config\IConfig;
 use Friendica\Core\Lock\ILock;
 use Friendica\Database\Database;
@@ -59,7 +59,7 @@ class dependencyCheck extends TestCase
 
                $this->assertInstanceOf(ConfigFileLoader::class, $configFileLoader);
 
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
                $configFileLoader->setupCache($configCache);
 
                $this->assertNotEmpty($configCache->getAll());
@@ -77,7 +77,7 @@ class dependencyCheck extends TestCase
 
                $this->assertInstanceOf(Profiler::class, $profiler);
 
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'system' => [
                                'profiler' => true,
                        ],
index 5180d3b36df75b06760b37a03acdddef368ad05e..466248f652e5dbdcaa940bcd517435e39c23c362 100644 (file)
@@ -8,7 +8,7 @@ namespace Friendica\Test;
 use Dice\Dice;
 use Friendica\App;
 use Friendica\Core\Config\IConfig;
-use Friendica\Core\Config\IPConfiguration;
+use Friendica\Core\PConfig\IPConfig;
 use Friendica\Core\Protocol;
 use Friendica\Core\Session;
 use Friendica\Core\Session\ISession;
@@ -827,7 +827,7 @@ class ApiTest extends DatabaseTest
         */
        public function testApiGetUserWithFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfiguration::class);
+               $pConfig = $this->dice->create(IPConfig::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', 'red');
                $user = api_get_user($this->app);
                $this->assertSelfUser($user);
@@ -843,7 +843,7 @@ class ApiTest extends DatabaseTest
         */
        public function testApiGetUserWithCustomFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfiguration::class);
+               $pConfig = $this->dice->create(IPConfig::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', '---');
                $pConfig->set($this->selfUser['id'], 'frio', 'nav_bg', '#123456');
                $pConfig->set($this->selfUser['id'], 'frio', 'link_color', '#123456');
@@ -862,7 +862,7 @@ class ApiTest extends DatabaseTest
         */
        public function testApiGetUserWithEmptyFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfiguration::class);
+               $pConfig = $this->dice->create(IPConfig::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', '---');
                $user = api_get_user($this->app);
                $this->assertSelfUser($user);
index 12ec2b4db86fc4759fb4bb157e0351063bcf643c..2fbb6863c09935b9832f22f49f0e827bab83e7c8 100644 (file)
@@ -29,7 +29,7 @@ class ModeTest extends MockedTest
        private $databaseMock;
 
        /**
-        * @var Config\Cache\ConfigCache|MockInterface
+        * @var \Friendica\Core\Config\Cache|MockInterface
         */
        private $configCacheMock;
 
@@ -41,7 +41,7 @@ class ModeTest extends MockedTest
 
                $this->basePathMock = \Mockery::mock(BasePath::class);
                $this->databaseMock = \Mockery::mock(Database::class);
-               $this->configCacheMock = \Mockery::mock(Config\Cache\ConfigCache::class);
+               $this->configCacheMock = \Mockery::mock(Config\Cache::class);
        }
 
        public function testItEmpty()
index ab879b31945095be535403f5cfb6a44cc25e0aae..ed31661673755ae866053c7a54454cc5a9a7ef78 100644 (file)
@@ -5,7 +5,7 @@ namespace Friendica\Test\src\Console;
 use Dice\Dice;
 use Friendica\App;
 use Friendica\Console\AutomaticInstallation;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Installer;
 use Friendica\Core\L10n;
 use Friendica\Core\Logger;
@@ -37,7 +37,7 @@ class AutomaticInstallationConsoleTest extends ConsoleTest
        private $assertFileDb;
 
        /**
-        * @var ConfigCache The configuration cache to check after each test
+        * @var Cache The configuration cache to check after each test
         */
        private $configCache;
 
@@ -79,7 +79,7 @@ class AutomaticInstallationConsoleTest extends ConsoleTest
 
                DI::init($this->dice);
 
-               $this->configCache = new ConfigCache();
+               $this->configCache = new Cache();
                $this->configCache->set('system', 'basepath', $this->root->url());
                $this->configCache->set('config', 'php_path', trim(shell_exec('which php')));
                $this->configCache->set('system', 'theme', 'smarty3');
index d8ac3eaea4d8cbe2aa63c5d22ae3eb57d5d635a7..6d0b045db48da6fe3a85e0a46c3f1e71995d8579 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Test\src\Core\Config\Cache;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Test\MockedTest;
 use ParagonIE\HiddenString\HiddenString;
 
@@ -29,7 +29,7 @@ class ConfigCacheTest extends MockedTest
                ];
        }
 
-       private function assertConfigValues($data, ConfigCache $configCache)
+       private function assertConfigValues($data, Cache $configCache)
        {
                foreach ($data as $cat => $values) {
                        foreach ($values as $key => $value) {
@@ -44,7 +44,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testLoadConfigArray($data)
        {
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
                $configCache->load($data);
 
                $this->assertConfigValues($data, $configCache);
@@ -63,7 +63,7 @@ class ConfigCacheTest extends MockedTest
                        ]
                ];
 
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
                $configCache->load($data);
                $configCache->load($override);
 
@@ -81,7 +81,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testLoadConfigArrayWrong()
        {
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                // empty dataset
                $configCache->load([]);
@@ -102,7 +102,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testGetAll($data)
        {
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
                $configCache->load($data);
 
                $all = $configCache->getAll();
@@ -117,7 +117,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testSetGet($data)
        {
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                foreach ($data as $cat => $values) {
                        foreach ($values as $key => $value) {
@@ -133,7 +133,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testGetEmpty()
        {
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $this->assertNull($configCache->get('something', 'value'));
        }
@@ -143,7 +143,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testGetCat()
        {
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'system' => [
                                'key1' => 'value1',
                                'key2' => 'value2',
@@ -171,7 +171,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testDelete($data)
        {
-               $configCache = new ConfigCache($data);
+               $configCache = new Cache($data);
 
                foreach ($data as $cat => $values) {
                        foreach ($values as $key => $value) {
@@ -188,7 +188,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testKeyDiffWithResult($data)
        {
-               $configCache = new ConfigCache($data);
+               $configCache = new Cache($data);
 
                $diffConfig = [
                        'fakeCat' => [
@@ -205,7 +205,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testKeyDiffWithoutResult($data)
        {
-               $configCache = new ConfigCache($data);
+               $configCache = new Cache($data);
 
                $diffConfig = $configCache->getAll();
 
@@ -217,7 +217,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testPasswordHide()
        {
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'database' => [
                                'password' => 'supersecure',
                                'username' => 'notsecured',
@@ -234,7 +234,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testPasswordShow()
        {
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'database' => [
                                'password' => 'supersecure',
                                'username' => 'notsecured',
@@ -251,7 +251,7 @@ class ConfigCacheTest extends MockedTest
         */
        public function testEmptyPassword()
        {
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'database' => [
                                'password' => '',
                                'username' => '',
@@ -265,7 +265,7 @@ class ConfigCacheTest extends MockedTest
 
        public function testWrongTypePassword()
        {
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'database' => [
                                'password' => new \stdClass(),
                                'username' => '',
@@ -275,7 +275,7 @@ class ConfigCacheTest extends MockedTest
                $this->assertNotEmpty($configCache->get('database', 'password'));
                $this->assertEmpty($configCache->get('database', 'username'));
 
-               $configCache = new ConfigCache([
+               $configCache = new Cache([
                        'database' => [
                                'password' => 23,
                                'username' => '',
index 283a5bc6abf926afe828e0710dcf7affb0fb7760..1d5a96f6954ebafa6607eb177f31a1be36121257 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Test\src\Core\Config\Cache;
 
-use Friendica\Core\Config\Cache\PConfigCache;
+use Friendica\Core\PConfig\Cache;
 use Friendica\Test\MockedTest;
 
 class PConfigCacheTest extends MockedTest
@@ -28,7 +28,7 @@ class PConfigCacheTest extends MockedTest
                ];
        }
 
-       private function assertConfigValues($data, PConfigCache $configCache, $uid)
+       private function assertConfigValues($data, Cache $configCache, $uid)
        {
                foreach ($data as $cat => $values) {
                        foreach ($values as $key => $value) {
@@ -44,7 +44,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testSetGet($data)
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
                $uid         = 345;
 
                foreach ($data as $cat => $values) {
@@ -62,7 +62,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testGetCat()
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
                $uid         = 345;
 
                $configCache->load($uid, [
@@ -94,7 +94,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testDelete($data)
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
                $uid         = 345;
 
                foreach ($data as $cat => $values) {
@@ -119,7 +119,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testKeyDiffWithResult($data)
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $diffConfig = [
                        'fakeCat' => [
@@ -137,7 +137,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testKeyDiffWithoutResult($data)
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, $data);
 
@@ -151,7 +151,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testPasswordHide()
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, [
                        'database' => [
@@ -170,7 +170,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testPasswordShow()
        {
-               $configCache = new PConfigCache(false);
+               $configCache = new Cache(false);
 
                $configCache->load(1, [
                        'database' => [
@@ -189,7 +189,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testEmptyPassword()
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, [
                        'database' => [
@@ -204,7 +204,7 @@ class PConfigCacheTest extends MockedTest
 
        public function testWrongTypePassword()
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, [
                        'database' => [
@@ -216,7 +216,7 @@ class PConfigCacheTest extends MockedTest
                $this->assertNotEmpty($configCache->get(1, 'database', 'password'));
                $this->assertEmpty($configCache->get(1, 'database', 'username'));
 
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, [
                        'database' => [
@@ -234,7 +234,7 @@ class PConfigCacheTest extends MockedTest
         */
        public function testTwoUid()
        {
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $configCache->load(1, [
                        'cat1' => [
@@ -265,7 +265,7 @@ class PConfigCacheTest extends MockedTest
                // bad UID!
                $uid = null;
 
-               $configCache = new PConfigCache();
+               $configCache = new Cache();
 
                $this->assertNull($configCache->get($uid, 'cat1', 'cat2'));
 
index 4090407aea28170a67c9707be63a4358b99a852e..b36d0ac31e5d7afeb9769d6025525ec9b3c6f949 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Test\src\Core\Config;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Config\IConfig;
 use Friendica\Model\Config\Config as ConfigModel;
 use Friendica\Test\MockedTest;
@@ -14,7 +14,7 @@ abstract class ConfigurationTest extends MockedTest
        /** @var ConfigModel|MockInterface */
        protected $configModel;
 
-       /** @var ConfigCache */
+       /** @var Cache */
        protected $configCache;
 
        /** @var IConfig */
@@ -42,7 +42,7 @@ abstract class ConfigurationTest extends MockedTest
 
                // Create the config model
                $this->configModel = Mockery::mock(ConfigModel::class);
-               $this->configCache = new ConfigCache();
+               $this->configCache = new Cache();
        }
 
        /**
@@ -142,7 +142,7 @@ abstract class ConfigurationTest extends MockedTest
                                  ->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // assert config is loaded everytime
                $this->assertConfig('config', $data['config']);
@@ -154,7 +154,7 @@ abstract class ConfigurationTest extends MockedTest
        public function testLoad(array $data, array $possibleCats, array $load)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                foreach ($load as $loadedCats) {
                        $this->testedConfig->load($loadedCats);
@@ -235,7 +235,7 @@ abstract class ConfigurationTest extends MockedTest
        public function testCacheLoadDouble(array $data1, array $data2, array $expect)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                foreach ($data1 as $cat => $data) {
                        $this->testedConfig->load($cat);
@@ -260,7 +260,7 @@ abstract class ConfigurationTest extends MockedTest
                $this->configModel->shouldReceive('load')->withAnyArgs()->andReturn([])->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertEmpty($this->testedConfig->getCache()->getAll());
        }
@@ -277,7 +277,7 @@ abstract class ConfigurationTest extends MockedTest
                                  ->times(3);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertTrue($this->testedConfig->set('test', 'it', $data));
 
@@ -295,7 +295,7 @@ abstract class ConfigurationTest extends MockedTest
                $this->configModel->shouldReceive('set')->with('test', 'it', $data)->andReturn(true)->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertTrue($this->testedConfig->set('test', 'it', $data));
 
@@ -309,7 +309,7 @@ abstract class ConfigurationTest extends MockedTest
        public function testGetWrongWithoutDB()
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // without refresh
                $this->assertNull($this->testedConfig->get('test', 'it'));
@@ -334,7 +334,7 @@ abstract class ConfigurationTest extends MockedTest
                $this->configCache->load(['test' => ['it' => 'now']]);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // without refresh
                $this->assertEquals('now', $this->testedConfig->get('test', 'it'));
@@ -359,7 +359,7 @@ abstract class ConfigurationTest extends MockedTest
                $this->configCache->load(['test' => ['it' => $data]]);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertEquals($data, $this->testedConfig->get('test', 'it'));
                $this->assertEquals($data, $this->testedConfig->getCache()->get('test', 'it'));
@@ -396,7 +396,7 @@ abstract class ConfigurationTest extends MockedTest
                                  ->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(ConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // directly set the value to the cache
                $this->testedConfig->getCache()->set('test', 'it', 'now');
index 8ceea93ff46dfc94b950b247b94b3983c23675d3..c45584f137232d89a6bc893361c15ffda4301bd6 100644 (file)
@@ -2,13 +2,13 @@
 
 namespace Friendica\Test\src\Core\Config;
 
-use Friendica\Core\Config\JitPConfiguration;
+use Friendica\Core\PConfig\JitPConfig;
 
 class JitPConfigurationTest extends PConfigurationTest
 {
        public function getInstance()
        {
-               return new JitPConfiguration($this->configCache, $this->configModel);
+               return new JitPConfig($this->configCache, $this->configModel);
        }
 
        /**
index 40c6970a5cb9bc261e3b1ffff7a1bf089e853ade..c8429b2d0056f81e3f053b607fcafa37124ac555 100644 (file)
@@ -2,8 +2,8 @@
 
 namespace Friendica\Test\src\Core\Config;
 
-use Friendica\Core\Config\Cache\PConfigCache;
-use Friendica\Core\Config\PConfiguration;
+use Friendica\Core\PConfig\Cache;
+use Friendica\Core\BasePConfig;
 use Friendica\Model\Config\PConfig as PConfigModel;
 use Friendica\Test\MockedTest;
 use Mockery;
@@ -14,10 +14,10 @@ abstract class PConfigurationTest extends MockedTest
        /** @var PConfigModel|MockInterface */
        protected $configModel;
 
-       /** @var PConfigCache */
+       /** @var Cache */
        protected $configCache;
 
-       /** @var PConfiguration */
+       /** @var BasePConfig */
        protected $testedConfig;
 
        /**
@@ -44,11 +44,11 @@ abstract class PConfigurationTest extends MockedTest
 
                // Create the config model
                $this->configModel = Mockery::mock(PConfigModel::class);
-               $this->configCache = new PConfigCache();
+               $this->configCache = new Cache();
        }
 
        /**
-        * @return PConfiguration
+        * @return BasePConfig
         */
        public abstract function getInstance();
 
@@ -145,7 +145,7 @@ abstract class PConfigurationTest extends MockedTest
        public function testSetUp(int $uid, array $data)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertEmpty($this->testedConfig->getCache()->getAll());
        }
@@ -156,7 +156,7 @@ abstract class PConfigurationTest extends MockedTest
        public function testLoad(int $uid, array $data, array $possibleCats, array $load)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                foreach ($load as $loadedCats) {
                        $this->testedConfig->load($uid, $loadedCats);
@@ -239,7 +239,7 @@ abstract class PConfigurationTest extends MockedTest
        public function testCacheLoadDouble(int $uid, array $data1, array $data2, array $expect)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                foreach ($data1 as $cat => $data) {
                        $this->testedConfig->load($uid, $cat);
@@ -263,7 +263,7 @@ abstract class PConfigurationTest extends MockedTest
        public function testSetGetWithoutDB(int $uid, $data)
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertTrue($this->testedConfig->set($uid, 'test', 'it', $data));
 
@@ -284,7 +284,7 @@ abstract class PConfigurationTest extends MockedTest
                                  ->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertTrue($this->testedConfig->set($uid, 'test', 'it', $data));
 
@@ -298,7 +298,7 @@ abstract class PConfigurationTest extends MockedTest
        public function testGetWrongWithoutDB()
        {
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // without refresh
                $this->assertNull($this->testedConfig->get(0, 'test', 'it'));
@@ -323,7 +323,7 @@ abstract class PConfigurationTest extends MockedTest
                $this->configCache->load($uid, ['test' => ['it' => 'now']]);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // without refresh
                $this->assertEquals('now', $this->testedConfig->get($uid, 'test', 'it'));
@@ -348,7 +348,7 @@ abstract class PConfigurationTest extends MockedTest
                $this->configCache->load($uid, ['test' => ['it' => $data]]);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertEquals($data, $this->testedConfig->get($uid, 'test', 'it'));
                $this->assertEquals($data, $this->testedConfig->getCache()->get($uid, 'test', 'it'));
@@ -387,7 +387,7 @@ abstract class PConfigurationTest extends MockedTest
                                  ->once();
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                // directly set the value to the cache
                $this->testedConfig->getCache()->set($uid, 'test', 'it', 'now');
@@ -447,7 +447,7 @@ abstract class PConfigurationTest extends MockedTest
                $this->configCache->load($data2['uid'], $data2['data']);
 
                $this->testedConfig = $this->getInstance();
-               $this->assertInstanceOf(PConfigCache::class, $this->testedConfig->getCache());
+               $this->assertInstanceOf(Cache::class, $this->testedConfig->getCache());
 
                $this->assertConfig($data1['uid'], 'cat1', $data1['data']['cat1']);
                $this->assertConfig($data1['uid'], 'cat2', $data1['data']['cat2']);
index 270a7a2e0bf4af79712fb0254840c9e1292f94c8..79d0d49db36c2e179fa73aa41211d083bc6fde5e 100644 (file)
@@ -2,13 +2,13 @@
 
 namespace Friendica\Test\src\Core\Config;
 
-use Friendica\Core\Config\PreloadPConfiguration;
+use Friendica\Core\PConfig\PreloadPConfig;
 
 class PreloadPConfigurationTest extends PConfigurationTest
 {
        public function getInstance()
        {
-               return new PreloadPConfiguration($this->configCache, $this->configModel);
+               return new PreloadPConfig($this->configCache, $this->configModel);
        }
 
        /**
index abc20876384dc4144c944a442a445319495e2450..371932caf2110fbd6df2f449494b3107a82c9e28 100644 (file)
@@ -4,7 +4,7 @@
 namespace Friendica\Core;
 
 use Dice\Dice;
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\DI;
 use Friendica\Network\CurlResult;
 use Friendica\Test\MockedTest;
@@ -419,7 +419,7 @@ class InstallerTest extends MockedTest
                $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                $install = new Installer();
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('set')->with('config', 'php_path', \Mockery::any())->once();
                $configCache->shouldReceive('set')->with('system', 'basepath', '/test/')->once();
 
index aa9a11cb080aeb02fcc86a2cf3277228c915782e..59b2f39cb063723fff671e3b735f86da5c7119dc 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Test\src\Util\Config;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Test\MockedTest;
 use Friendica\Test\Util\VFSTrait;
 use Friendica\Util\ConfigFileLoader;
@@ -27,7 +27,7 @@ class ConfigFileLoaderTest extends MockedTest
                $this->delConfigFile('local.config.php');
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -48,7 +48,7 @@ class ConfigFileLoaderTest extends MockedTest
                        ->setContent('<?php return true;');
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
        }
@@ -72,7 +72,7 @@ class ConfigFileLoaderTest extends MockedTest
                        ->setContent(file_get_contents($file));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -104,7 +104,7 @@ class ConfigFileLoaderTest extends MockedTest
                        ->setContent(file_get_contents($file));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -135,7 +135,7 @@ class ConfigFileLoaderTest extends MockedTest
                        ->setContent(file_get_contents($file));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -216,7 +216,7 @@ class ConfigFileLoaderTest extends MockedTest
                         ->setContent(file_get_contents($fileDir . 'B.config.php'));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -245,7 +245,7 @@ class ConfigFileLoaderTest extends MockedTest
                         ->setContent(file_get_contents($fileDir . 'B.ini.php'));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
@@ -274,7 +274,7 @@ class ConfigFileLoaderTest extends MockedTest
                         ->setContent(file_get_contents($fileDir . 'B.ini.php'));
 
                $configFileLoader = new ConfigFileLoader($this->root->url());
-               $configCache = new ConfigCache();
+               $configCache = new Cache();
 
                $configFileLoader->setupCache($configCache);
 
index 400d557c34d924cf770c88476655ec90d4cbce66..cfd28af1743b338e92270c16c05588d38e3628d9 100644 (file)
@@ -2,7 +2,7 @@
 
 namespace Friendica\Test\src\Util;
 
-use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\Core\Config\Cache;
 use Friendica\Core\Config\IConfig;
 use Friendica\Test\MockedTest;
 use Friendica\Util\Profiler;
@@ -28,7 +28,7 @@ class ProfilerTest extends MockedTest
         */
        public function testSetUp()
        {
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('get')
                            ->withAnyArgs()
                            ->andReturn(true)
@@ -103,7 +103,7 @@ class ProfilerTest extends MockedTest
         */
        public function testSaveTimestamp($timestamp, $name, array $functions)
        {
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('get')
                            ->withAnyArgs()
                            ->andReturn(true)
@@ -124,7 +124,7 @@ class ProfilerTest extends MockedTest
         */
        public function testReset($timestamp, $name, array $functions)
        {
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('get')
                            ->withAnyArgs()
                            ->andReturn(true)
@@ -187,7 +187,7 @@ class ProfilerTest extends MockedTest
                        ->shouldReceive('info')
                        ->once();
 
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('get')
                            ->withAnyArgs()
                            ->andReturn(true)
@@ -218,7 +218,7 @@ class ProfilerTest extends MockedTest
         */
        public function testEnableDisable()
        {
-               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache = \Mockery::mock(Cache::class);
                $configCache->shouldReceive('get')
                            ->with('system', 'profiler')
                            ->andReturn(true)