Apply suggestions from code review

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>

diff --git a/mod/item.php b/mod/item.php
index ca97f4e0018f76349536be452c3d99d7fed17678..f43e78e6ba35fe32c89cda0e010fabbf50189e70 100644 (file)
--- a/mod/item.php
+++ b/mod/item.php
@@ -156,7 +156,7 @@ function item_insert(int $uid, array $request, bool $preview, string $return_pat
 
        if (!empty($request['parent'])) {
                $parent_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $request['parent']]);
-               if (DBA::isResult($parent_item)) {
+               if ($parent_item) {
                        // if this isn't the top-level parent of the conversation, find it
                        if ($parent_item['gravity'] != Item::GRAVITY_PARENT) {
                                $toplevel_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $parent_item['parent']]);
@@ -206,7 +206,7 @@ function item_insert(int $uid, array $request, bool $preview, string $return_pat
        }
 
        $post = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $post_id]);
-       if (!DBA::isResult($post)) {
+       if (!$post) {
                Logger::error('Item couldn\'t be fetched.', ['post_id' => $post_id]);
                if ($return_path) {
                        DI::baseUrl()->redirect($return_path);

diff --git a/src/Content/Item.php b/src/Content/Item.php
index 2518f4d3189f29a93c84d0f80ba820041375cb1b..a60b12663de03a4fa11a2b90c73f6813d0366274 100644 (file)
--- a/src/Content/Item.php
+++ b/src/Content/Item.php
@@ -856,7 +856,7 @@ class Item
                }
 
                $user = User::getById($post['uid'], ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']);
-               if (!DBA::isResult($user)) {
+               if (!$user) {
                        throw new HTTPException\NotFoundException($this->l10n->t('Unable to locate original post.'));
                }