Workaround for http_build_query() oddities in low-level router parent code when PHP...

diff --git a/lib/router.php b/lib/router.php
index 417206e6bffb291921a1201fe063316af2638a3e..ab8c40668ddb5eca4da2182419933d771f095c0d 100644 (file)
--- a/lib/router.php
+++ b/lib/router.php
@@ -863,7 +863,16 @@ class Router
         if ($qpos !== false) {
             $url = substr($url, 0, $qpos+1) .
               str_replace('?', '&', substr($url, $qpos+1));
+
+            // @fixme this is a hacky workaround for http_build_query in the
+            // lower-level code and bad configs that set the default separator
+            // to & instead of &. Encoded &s in parameters will not be
+            // affected.
+            $url = substr($url, 0, $qpos+1) .
+              str_replace('&', '&', substr($url, $qpos+1));
+
         }
+
         return $url;
     }
 }